From: Jens Axboe <axboe@kernel.dk>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
tj@kernel.org, josef@toxicpanda.com
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, shikemeng@huawei.com,
linfeilong@huawei.com, liuzhiqiang26@huawei.com
Subject: Re: [PATCH v3 1/9] blk-throttle: correct stale comment in throtl_pd_init
Date: Mon, 5 Dec 2022 13:43:26 -0700 [thread overview]
Message-ID: <be8563d8-1992-f9bc-928f-e9e5f3227c1c@kernel.dk> (raw)
In-Reply-To: <20221205115709.251489-2-shikemeng@huaweicloud.com>
On 12/5/22 4:57?AM, Kemeng Shi wrote:
> From: Kemeng Shi <shikemeng@huawei.com>
>
> On the default hierarchy (cgroup2), the throttle interface files don't
> exist in the root cgroup, so the ablity to limit the whole system
> by configuring root group is not existing anymore. In general, cgroup
> doesn't wanna be in the business of restricting resources at the
> system level, so correct the stale comment that we can limit whole
> system to we can only limit subtree.
>
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Which one should be used? You have duplicate SOBs in each of the
commits. It's marked as being from Kemeng Shi <shikemeng@huawei.com> so
that is what I'll use.
--
Jens Axboe
next prev parent reply other threads:[~2022-12-05 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 11:57 [PATCH v3 0/9] A few bugfix and cleanup patches for blk-throttle Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 1/9] blk-throttle: correct stale comment in throtl_pd_init Kemeng Shi
2022-12-05 20:43 ` Jens Axboe [this message]
2022-12-06 1:17 ` Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 2/9] blk-throttle: Fix that bps of child could exceed bps limited in parent Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 3/9] blk-throttle: ignore cgroup without io queued in blk_throtl_cancel_bios Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 4/9] blk-throttle: correct calculation of wait time in tg_may_dispatch Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 5/9] blk-throttle: simpfy low limit reached check in throtl_tg_can_upgrade Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 6/9] blk-throttle: fix typo in comment of throtl_adjusted_limit Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 7/9] blk-throttle: remove incorrect comment for tg_last_low_overflow_time Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 8/9] blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade Kemeng Shi
2022-12-05 11:57 ` [PATCH v3 9/9] blk-throttle: Use more siutable time_after check for update of slice_start Kemeng Shi
2022-12-05 20:46 ` [PATCH v3 0/9] A few bugfix and cleanup patches for blk-throttle Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be8563d8-1992-f9bc-928f-e9e5f3227c1c@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linfeilong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=shikemeng@huawei.com \
--cc=shikemeng@huaweicloud.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®