From: Robin Murphy <robin.murphy@arm.com>
To: Markus Reichl <m.reichl@fivetechno.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: exynos: Assign a fixed index to mmc devices on exynos4412 based ODROID boards
Date: Thu, 5 Nov 2020 11:26:00 +0000 [thread overview]
Message-ID: <be911d41-c707-f482-4966-476b9330bde7@arm.com> (raw)
In-Reply-To: <2ddf7343-799b-418b-bb00-a926f1030db7@fivetechno.de>
On 2020-11-05 08:31, Markus Reichl wrote:
> Hi Marek,
>
> on rk3399 the proposed ordering [1] is according to base address in DT.
FWIW, note that in RK3399's case the SoC itself provides no logical
numbering to follow - the pin groups are named "EMMC", "SDIO0" and
"SDMMC0" in the datasheet, while the TRM uses "emmc", "sdio" and "sdmmc"
in signal and register names.
If the SoC *does* have an inherent notion of numbered interfaces, I
would agree that following that numbering is the most logical thing to do.
Robin.
>
> [1]
> https://patchwork.kernel.org/patch/11881427
>
> Am 04.11.20 um 14:44 schrieb Marek Szyprowski:
>> On 04.11.2020 14:13, Marek Szyprowski wrote:
>>> On 04.11.2020 14:06, Markus Reichl wrote:
>>>> Am 04.11.20 um 13:25 schrieb Marek Szyprowski:
>>>>> On 04.11.2020 11:25, Markus Reichl wrote:
>>>>>> Recently introduced async probe on mmc devices can shuffle block IDs.
>>>>>> Pin them to fixed values to ease booting in evironments where UUIDs
>>>>>> ar not practical.
>>>>>> Use newly introduced aliases for mmcblk devices from [1].
>>>>>>
>>>>>> [1]
>>>>>> https://patchwork.kernel.org/patch/11747669/
>>>>>>
>>>>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>> ---
>>>>>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
>>>>>> 1 file changed, 5 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> index a5c1ce1e396c..aa10d5bc7e1c 100644
>>>>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>>>>> @@ -13,6 +13,11 @@
>>>>>> #include "exynos-mfc-reserved-memory.dtsi"
>>>>>> / {
>>>>>> + aliases {
>>>>>> + mmc0 = &sdhci_2;
>>>>>> + mmc1 = &mshc_0;
>>>>> Like in the OdroidXU3-family patch, I would use 0 for the eMMC
>>>>> (mshc_0)
>>>>> and 2 for the SD-card (sdhci_2).
>>>> How to deal then with sdhci_0 (from exynos4.dtsi) vc. mshc_0 (from
>>>> exynos4412.dts)?
>>> sdhci_0 and mshc_0 both operate on the same physical MMC0 bus, so this
>>> is not an issue. They cannot be used simultaneously. The latter is just
>>> faster, the first one has been left there mainly for the software
>>> compatibility.
>>
>> I've thought a bit more on this and I would simply prefer to add generic
>> MMC aliases to the top-level Exynos dtsi files (3250, 4210, 4412, 5250,
>> 5410, 5420) to keep Linux logical MMC bus numbers in sync with the HW
>> bus numbers on all boards.
>>
>> Best regards
>>
>
> Gruß,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2020-11-05 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201104102634eucas1p2ec7b705dd5092afa25d9877d1014f46a@eucas1p2.samsung.com>
2020-11-04 10:25 ` Markus Reichl
2020-11-04 12:25 ` Marek Szyprowski
2020-11-04 12:43 ` Markus Reichl
2020-11-04 13:06 ` Markus Reichl
2020-11-04 13:13 ` Marek Szyprowski
2020-11-04 13:44 ` Marek Szyprowski
2020-11-04 13:50 ` Markus Reichl
2020-11-05 8:22 ` Krzysztof Kozlowski
2020-11-05 8:31 ` Markus Reichl
2020-11-05 11:26 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be911d41-c707-f482-4966-476b9330bde7@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®