From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbdGSMgq (ORCPT ); Wed, 19 Jul 2017 08:36:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42288 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbdGSMgo (ORCPT ); Wed, 19 Jul 2017 08:36:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 99352267F1 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=prarit@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 99352267F1 Subject: Re: [PATCH 0/7] turbostat, Fix AMD output by making turbostat aware of nodes To: linux-kernel@vger.kernel.org References: <1500238203-14507-1-git-send-email-prarit@redhat.com> Cc: nhorman@redhat.com, Len Brown , Len Brown From: Prarit Bhargava Message-ID: Date: Wed, 19 Jul 2017 08:36:43 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1500238203-14507-1-git-send-email-prarit@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 19 Jul 2017 12:36:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Forgot to cc Len at his kernel.org address ... P. On 07/16/2017 04:49 PM, Prarit Bhargava wrote: > AMD family processors do not show all cores in the output of turbostat. This > occurs because AMD has multiple nodes per socket and enumerates cores > within each node from 0. For example, socket 0 may have two nodes (0 and 1) > and those nodes both have cores enumerated from 0 through 7. turbostat cannot > handle this configuration, and as a result only shows 1/2 the cores in its > output. > > This patchset makes turbostate aware of nodes. It has been tested on > various AMD and Intel systems and no issues have been found. > > Signed-off-by: Prarit Bhargava > Cc: Len Brown > > Prarit Bhargava (7): > turbostat: set max_num_cpus equal to the cpumask length > turbostat: Fix node and siblings lookup data > turbostat: Calculate additional node information for a > turbostat: track thread ID in cpu_topology > turbostat: rename num_cores_per_pkg to num_cores_per_node > turbostat: remove num_ from cpu_topology struct > turbostat: add node information into turbostat calculations > > tools/power/x86/turbostat/turbostat.c | 419 +++++++++++++++++++++------------- > 1 file changed, 259 insertions(+), 160 deletions(-) >