From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDE71DFE15; Wed, 4 Sep 2024 15:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.73 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725465098; cv=fail; b=jUKwoP98zCp2mrgT06XXt3dN3xd0w2qzjMbtwYkDTGJFhFy5WZlScLacsAkeAuCsr5tMLaYy7GLNyz6iY2SeD94hcQvmbVdu56WrHd2EQIuv35Yt+EXVc2Edjgvrw3dZhq3v1XZrfDTiDSfjorJk2t+S5C8u+KceOxDc4Exogdw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725465098; c=relaxed/simple; bh=zCGbFh5+ALYM7dm1Fnb94X8Qc97EwV3JKr6ZJGoSIjM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=Xos5ngZC+MMoqwfI0pDiMwRDMxG8NmMxI9f8uuo++4+DRIJACa5G2sACZWzX8DbXJ9rUSga7sG45fk40Wqt+PfM6GKB2NZJ9cf7yM/5gZz2qFMwdjj9WHj7MaZPK7lMIgQOwGHD7oqKPENUB4esdko+5gV3+NYVGwdBvVLaLq7c= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=EU5vAAyw; arc=fail smtp.client-ip=40.107.93.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="EU5vAAyw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gtev3wQpxeLFEtVHCcTL0OPDvTYV0SGVmRjcyxNjYOkTrSpn+T0r3j4pobH61JlYAsXYCcxeCNg5jcoymwvx7ydP+qTeQT64Hyv/qoI4mi0oCEl8bpxP8CKE2uYmpMJdL/t+TncGHycqgO4U9WFwNZMBvxLtJ/xKbhh8pxUyMD7QyhooIe4oYN4erTBCBwo2kePuiD6keUOMdKknVrhLRNxtlpVCIYVK36Q68sybL+k2KUrH7gvGLL7BKOmxjueMyfR4Kqco3bVpTIJ4VvUcuOxdwgiKw30xl2SwVWmHCd5OfisvmP6M/KapK2XM+XGFmQB/TO6vkSN+zD0zMEjgPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FEC8i1kDs19w9SIj8mszmlU6HkQQLSAsoxRfOMh/xDw=; b=nVndtWtj4Z0ohs2P9Vxp3j6cKSvI3SWkx0DPV74lNzerZQ/N0SDw63+gnz5nuPeNfw1eOscL732r009LHmGXsV9IT9zcZP2HRuTysZw6qnJfzHNqK0aoz1BJu5QhpRMDgWlxGXrJ7hUTK+ZNCowaEohFoniLk1ggp4ER/fU8WSXQm9qdDr8+xyPMLIbvxkCcLlNdpPGx3k541IH41/FKrUYp89eOyIPVgKPOtj0jzyhdmhwpHPj9KQDt127agWZHhp8tsq+VD6csNsDulX6mm9iHBWmkPF/92gjzQfeMsBCP9u3GeEDvMIqtC+ku3kzbqzaXS/TB5D/0ZWNMdx4Osg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FEC8i1kDs19w9SIj8mszmlU6HkQQLSAsoxRfOMh/xDw=; b=EU5vAAywwoG4iJ04uFDqVS8FtOQH0nQhdcoxkH0tuKbL4bLqsQD7iiJycwaMMvn3UyCM9zPKQGITBoDhjzBpewFNq76Qvpy1r4PfdiVxTJjdpm5t9MkIwFlzkQGS7hLckoBSbMnWvZg/muQDPElZ7oGCIWCbRvcdX8KLXRwzQOE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS0PR12MB6583.namprd12.prod.outlook.com (2603:10b6:8:d1::12) by PH7PR12MB8040.namprd12.prod.outlook.com (2603:10b6:510:26b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.27; Wed, 4 Sep 2024 15:51:33 +0000 Received: from DS0PR12MB6583.namprd12.prod.outlook.com ([fe80::c8a9:4b0d:e1c7:aecb]) by DS0PR12MB6583.namprd12.prod.outlook.com ([fe80::c8a9:4b0d:e1c7:aecb%6]) with mapi id 15.20.7918.024; Wed, 4 Sep 2024 15:51:32 +0000 Message-ID: Date: Wed, 4 Sep 2024 08:51:28 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] ionic: Convert comma to semicolon To: Chen Ni , brett.creeley@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240904081728.1353260-1-nichen@iscas.ac.cn> Content-Language: en-US From: "Nelson, Shannon" In-Reply-To: <20240904081728.1353260-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN9PR03CA0409.namprd03.prod.outlook.com (2603:10b6:408:111::24) To DS0PR12MB6583.namprd12.prod.outlook.com (2603:10b6:8:d1::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6583:EE_|PH7PR12MB8040:EE_ X-MS-Office365-Filtering-Correlation-Id: 0719e8d0-f000-4919-192a-08dcccf97270 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cCtYYjltTmkvb3kxcUxDQmZEbXY0NXVJOTIzZzJkVEQ2MTV6QkpxYVBMT21N?= =?utf-8?B?Z3E5THprMmkxN3FNUFdpTzFFNC9FNlRQazlEN0dKYWlUU2ErMmN1QWlLNTFt?= =?utf-8?B?RitmZXZLSTFES25QYUsrbTU5WFg3cDRDZFFETkYrQ0NaUElzQWcxc1YrbDRF?= =?utf-8?B?eUNjWnJMdDY2SFFxd29CWGs0Mno2TEN2Z05QTnlXQW84QUtMVnVycERZb2JF?= =?utf-8?B?M1BTeHp2Nk91czdZNFBnQ1VnU091M1hDdDVmWm94dFM1c2RiQ2xiTlBtWFpG?= =?utf-8?B?MlB1WTBHbnhmRDF2a2VYVTZ2aVFiQUNHcEdibTVlYlpiNDZGSCt6NEM3aVVu?= =?utf-8?B?VkY0U1RYQnRodENBQ1RmY0N4bExwdW04U0dKYXVxWnZ3UmVNYXhPLytFVkdH?= =?utf-8?B?VDkwT25mU0ZLVk5aYjMwM1dDcnY1VXY4TVdYMkhmN2FuNlQwWUtyQVU5cmhj?= =?utf-8?B?blFDdkRqT2Ztd0tRa25BcldYTmg4ckVpdTVLRmt4T3lkRnhMNVBoQjZHR3VW?= =?utf-8?B?M29QcmJIMUV2QitjYUc0NGRhVkN3YjlOQitaQTEweDNGRGZEZGo5M1haYzNK?= =?utf-8?B?RW4waFI0Q1N4ZkRkT25kK2xJeGp0R2Q4VmVtNDRKdk5PVWxCeWFvWHpKb2Q5?= =?utf-8?B?QUFnRU5qanQ1WUhvbXNMUVJZRVZ2eTZuWkJOT2JIR2JhbDhkdERyVWxQbDBn?= =?utf-8?B?SGFtRlZFN2pFdUQyN2N6TlpVVGQyM1ZCYmhuM0pRVDViSzRVSVpGUVp5YXc3?= =?utf-8?B?MEFuV1BMZEVLTUFzbW45a3cvVU9pYUVQeEpKanlkbjVxMjkrRDZTN0N3YUxB?= =?utf-8?B?WWVteWcrRUVJK1R5UlhCS2xUMzVkelFHZEJPSFF3bkNUV0NCMk93OFd3Uzc4?= =?utf-8?B?Z0syNlN1c0Ziem9LZEtiU1B6VU84YXh1YWtHRWN1UVhDZjcyckM5bnlKcWxK?= =?utf-8?B?SzhrUTZGNW16SUJZWnNwTm1xUHI4dm9WOEpTV0dpK3h2bERJSlZraUhJR3d3?= =?utf-8?B?dnI1Wng0Q3IwSmFyWXNhYTN4WUwvRHk0V3o5d05qMGtJT0hwT1VVeHJoNVRU?= =?utf-8?B?V3l2TE95TEphY3hZWE81S1FIcGgvVkl4TE5SQUd3L0g4bzRWdGVmRlNjQStH?= =?utf-8?B?ZjNWSTBRVVZwLyt3Y3FGbnZZMENLQ213WEp0V0ZURFB2b1FKWnNQQnlJY0Ft?= =?utf-8?B?Nkx6S1AxM25SaEJaaGxZSHU3cXFwY0lhM3R5Z1FnMDN5R3ZVNHFYdjN6Q0Zy?= =?utf-8?B?K1VmcWNnU0xFTm9hMDBnWEVLUldJOEl0SFMyUno0a2dZN3R4a1ord3J1TElD?= =?utf-8?B?MUM4bG54Um5WYkFYdVJqZmJNN3MzRjBubTk5VkZTZU8xS2RMbkM1QTU3NWFa?= =?utf-8?B?a3orcWpmTFFzV2ltdkk1SHM4UTU1SjdXc3VTNEs2eFlWV0VDK0FWenp4eVpl?= =?utf-8?B?ZmJMc2RwWThHMnFyYnNJU1JVY2o0NkRjbnBmUXhhWnB6VjlFQ2dkUno3OVVn?= =?utf-8?B?eHExNmxxT0Jld2h1dWUrWHZJb0x6OW9TdEVvTU1vUkpNRm5ZVkhtWFBHNngz?= =?utf-8?B?UTZQRURwQXBpU1N6M2NlSUhIRnBPZ3RtU1dITFNhRTBGQTJrTTRQc2FtWGM0?= =?utf-8?B?UTdQRHUwTkR0TTFwZHJia2UxQ09tdjVKa29zRS9oOTllZUZzaGI2SkNqTVFR?= =?utf-8?B?Nk9DWHRodEowOFVGblhUL0xONXlwTzVLWDVEeEJVMi90cm1wVG1ja2t4M3dz?= =?utf-8?B?ZGhkcmtLSlpiK0F2ZnhSRkJZK0dOTkpISHFSZ01TOTFGcnlsalJ6RkZjV3Q5?= =?utf-8?B?bFh6ZDNZeGowQWt4UnpoZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6583.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUczNU00QmsrZFNHVFZtSE9YN3lKMzcvWERIbTZucVJUbmhRRDBmM3gwaXhO?= =?utf-8?B?WENqZzc5ZWVQeE5nMUhKbzE2UXp0YWh1Rk9Zdkk1cXBweG9iTHMxNmhUZTdz?= =?utf-8?B?R1FDc3ZtK2hSOGl4Z2RRa0NNZmc3bkJYZkJnalp6T0pJL0FSYzVCR1IvSHVQ?= =?utf-8?B?MklHcmdhWUkrWWptcC8xSDdSQjc0dVpFMzdtRUpldE5McGhzU3RNTlE3K3I2?= =?utf-8?B?dEdPU2RRdmp5NmNNY3R5RFVIQ1BId2ZtNjErdEJCdktzMWFLOFRPVVNQV2Ra?= =?utf-8?B?RFg1QTR1UzVRQ2lkSFQ2Sjd3b3hXWWhiRkNVR0tQQXNZMmVGWE9tbGJZOVRa?= =?utf-8?B?dUttVHNIV2FyT3BhNkNGamQvQnYxQXBnNHNYWUxEYk4rNVNJbUpBM0tsc3M1?= =?utf-8?B?a01aNGFsK1hyUy9oSk1qWm9wNzdGM0JHMnNWWXJGeXNtQTI0TTVncEdBVEVJ?= =?utf-8?B?SVl3a05EWGJIUE5Za2t3WUhVS0VJNUNmYlZDaGI3KzRRN2FuN2JvYXk1L0lE?= =?utf-8?B?U0RtNzFKenp3eWh2ZXlJTlNDeEgxWU1abVE2SkUwb1BqVTZGYXFtWWlRL1VF?= =?utf-8?B?SzNlZS92K1k1aDlFUlREaDJiQloxc1JRR3ZBWU93MTUwaGhPUkRBRWRoWE1Q?= =?utf-8?B?NmxFdnRtS09TcTVXM25yczZ5SUdubVlHbUVNVVViMEZSeUdnMndvQ2F5QVd1?= =?utf-8?B?VHcrL0prRmNWai9VVVVjMWsyclJsZENGTWZTSGg4NVpmUVBySTE3RnUxUVYy?= =?utf-8?B?VE1sbnBhUTQ2cTlHNWh0UXEvcjJuZThLOWdzZVhFSHBiT3RNb0FiWVF4WEdV?= =?utf-8?B?SGpqM3hQVmFNK3Zvb2RkWVNhN3QvTTRidnpBZk5mTk1XTCtPdXg0QTlpRDRS?= =?utf-8?B?aTBIR2hqY0s1Q3ZlVis3NmdsVFNDRHRKdDk5akRaL291U25yRG11UGNoYkU0?= =?utf-8?B?RVppdDRCcTVWaWRianRIVk1LRjVnc0tnTU5sNWZnNWxtdkFKS24zMEdlTHBS?= =?utf-8?B?MTNZR1h4SjVpTlI0YU9GRTFmSmtrcExGd0ltRit4UXBzTnUwdGZPQVJraEhr?= =?utf-8?B?cjJiUW9LdmZBWUVmb0dybnZOMnhialpXMDJFaVBVTXJrOUl4T2IyNWZocDI0?= =?utf-8?B?ZUVqN0hsTFhuNFl2R3lkZFJZWjY5dnJjc3I1TFFQRDNYWTMxa3p2cUFOYis4?= =?utf-8?B?WDRMYjNDMGRGU3RJdk9HOUFrc0RBUy9MS2N6QkhPcGhjQlBBZENiZDVXQlRY?= =?utf-8?B?WG9hUkxaODRSdFBMNGRTejdDenZHZWtJdEQxL1JKaWcxVnFWNWJDcHZ0eVRW?= =?utf-8?B?aGtLSVRod1oycnBpUVA3dS9nTWh4Ky96UGdZZjNVS2xRckdIaFNJeERDbHZE?= =?utf-8?B?K1U1dU5MYjM1dTMvVytoVy96M3JJVlVPTUczRHVuamJhSEVGbzRQc294Mldk?= =?utf-8?B?dWlXRmI2QU9MUy9tNXkzYUZReXRuN2F1dy9MTnBEaFZ0VkpaWC9vS0NVMlhD?= =?utf-8?B?QWRad0RLWnJ1Z2lTZ25tYlN1K2laVXNqOVVWVVBFM29laUhlZ1N2SC9QQldD?= =?utf-8?B?RTJiMVBxYmVlOXoxY21QekhVVTdyMW5CdTg1VkJrdnhjaDNDZDdoQWo1SzM4?= =?utf-8?B?dE05bGMvaTZsaWlhY1lSVGVVeUN3Y3A3RzdxR3gwM1BFNUpXOTNxRjBqV09p?= =?utf-8?B?MTg1aytSdWdpTy9sOWpyaWlqZHp0ZS84b1ZkaVZ6KzFPak1yMGhDZUdhODNs?= =?utf-8?B?VDdKNGczMjdRTkU1dzFLdUNESXJYWnhqQ1MxL1dFSjltVUtCUnJlblZZOVY1?= =?utf-8?B?eGVubGxyTnJGVVRWa3dtN3JOM01IVTE4MTh2YXFzTWgxR1B3QnpoR085L2Vw?= =?utf-8?B?bGtqdUhSZEtnSlV0NHIvTEZucURvdzdaL0tkSE1wd01QTVJLTzM0UjZnTEFS?= =?utf-8?B?QzFmblBENmlYZzM0SlFNWXIyS3Fkc1d3SGlhV0F3ZTFudVBSY3h0WThRcW0x?= =?utf-8?B?dUZrK0VoZXVBWFdHVmJJbDhtWTBTM0RPVGt5UVNpUXNUdStmNFhUZmY2UVp2?= =?utf-8?B?eEFDMFprT2hXUVNzcCtpdmlRY1YxYlFEeHY2UWRTY2xjeTdZaVZNaVRKZStU?= =?utf-8?Q?TSh+pS4WB5t1pHG+JLmBbG5Io?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0719e8d0-f000-4919-192a-08dcccf97270 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 15:51:32.0071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fzC+Ol+J9xi18FCxpgPSHnY5wIWGTqdECClvHy9No8BgeWa0ggRFPaHj9189EClKtmQk4O5JapFEjIXqbDdwOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8040 On 9/4/2024 1:17 AM, Chen Ni wrote: > > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. > > Found by inspection. > No functional change intended. > Compile tested only. > > Signed-off-by: Chen Ni > --- > drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c > index 1ee2f285cb42..528114877677 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c > @@ -312,8 +312,8 @@ static int ionic_lif_filter_add(struct ionic_lif *lif, > int err = 0; > > ctx.cmd.rx_filter_add = *ac; > - ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD, > - ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index), > + ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD; > + ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index); > > spin_lock_bh(&lif->rx_filters.lock); > f = ionic_rx_filter_find(lif, &ctx.cmd.rx_filter_add); > -- > 2.25.1 > Thanks for catching that. Reviewed-by: Shannon Nelson