Re: [PATCH v8 0/5] add debugfs to migration driver

[liulongfang <liulongfang@huawei.com>]

On 2023/2/17 16:48, Longfang Liu wrote:
> Add a debugfs function to the migration driver in VFIO to provide
> a step-by-step test function for the migration driver.
> 
> When the execution of live migration fails, the user can view the
> status and data during the migration process separately from the
> source and the destination, which is convenient for users to analyze
> and locate problems.
> 
> Changes v7 -> v8
> 	Add support for platform devices.
> 
> Changes v6 -> v7
> 	Fix some code style issues.
> 
> Changes v5 -> v6
> 	Control the creation of debugfs through the CONFIG_DEBUG_FS.
> 
> Changes v4 -> v5
> 	Remove the newly added vfio_migration_ops and use seq_printf
> 	to optimize the implementation of debugfs.
> 
> Changes v3 -> v4
> 	Change the migration_debug_operate interface to debug_root file.
> 
> Changes v2 -> v3
> 	Extend the debugfs function from hisilicon device to vfio.
> 
> Changes v1 -> v2
> 	Change the registration method of root_debugfs to register
> 	with module initialization.
> 
> Longfang Liu (5):
>   vfio/migration: Add debugfs to live migration driver
>   hisi_acc_vfio_pci: extract public functions for container_of
>   hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
>   Documentation: add debugfs description for vfio
>   vfio: update live migration device status
> 
>  .../ABI/testing/debugfs-hisi-migration        |  28 ++
>  Documentation/ABI/testing/debugfs-vfio        |  17 +
>  drivers/vfio/Makefile                         |   2 +-
>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c    | 306 +++++++++++++++++-
>  .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h    |  11 +
>  drivers/vfio/pci/mlx5/main.c                  |   3 +
>  drivers/vfio/vfio.h                           |  14 +
>  drivers/vfio/vfio_debugfs.c                   |  82 +++++
>  drivers/vfio/vfio_main.c                      |   5 +
>  include/linux/vfio.h                          |   8 +
>  10 files changed, 465 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration
>  create mode 100644 Documentation/ABI/testing/debugfs-vfio
>  create mode 100644 drivers/vfio/vfio_debugfs.c
> 
Hi Alex:
please help to review this patchset.
thanks.

Longfang.