mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Wenchao Chen <wenchao.chen666@gmail.com>,
	ulf.hansson@linaro.org, orsonzhai@gmail.com,
	baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	megoo.tang@gmail.com, lzx.stg@gmail.com
Subject: Re: [PATCH] mmc: sdhci-sprd: Fix minimum clock limit
Date: Tue, 11 Oct 2022 09:45:13 +0300	[thread overview]
Message-ID: <beae901e-0fcd-c4ae-8a6e-a1a4357078da@intel.com> (raw)
In-Reply-To: <20221011063043.11074-1-wenchao.chen666@gmail.com>

On 11/10/22 09:30, Wenchao Chen wrote:
> From: Wenchao Chen <wenchao.chen@unisoc.com>
> 
> The minimum clock supported by SPRD Host is 100000.

Commit messages are better if they say why a change
is being made.

This begs the question, was there a problem with 400 kHz?
Are there cases that benefit from this change?
Should it have a fixes tag,cc stable?

> 
> Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com>
> ---
>  drivers/mmc/host/sdhci-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 46c55ab4884c..b92a408f138d 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -309,7 +309,7 @@ static unsigned int sdhci_sprd_get_max_clock(struct sdhci_host *host)
>  
>  static unsigned int sdhci_sprd_get_min_clock(struct sdhci_host *host)
>  {
> -	return 400000;
> +	return 100000;
>  }
>  
>  static void sdhci_sprd_set_uhs_signaling(struct sdhci_host *host,


  reply	other threads:[~2022-10-11  6:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  6:30 Wenchao Chen
2022-10-11  6:45 ` Adrian Hunter [this message]
2022-10-11  8:40   ` Wenchao Chen
2022-10-11  8:48     ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=beae901e-0fcd-c4ae-8a6e-a1a4357078da@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=lzx.stg@gmail.com \
    --cc=megoo.tang@gmail.com \
    --cc=orsonzhai@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wenchao.chen666@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®