From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A94E340A4D for ; Fri, 6 Mar 2026 21:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772833182; cv=none; b=VR2BfM4QSn5yE/RLmpCs6aOONRgtvhGDmXaoUpZUnmKeVaNSh+mMW5dA7Nj8cyNiX8sHz7TpNCFp4I/oQMk5xJ6RC6Lm9afVd9hdocdibU5BkRXxgiG4CKFZGGwklU5W2CO1Wc61hgwYmGynVmkDXL2HqjFOs7sOTKey2KEPw8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772833182; c=relaxed/simple; bh=y9lwu8NiuYdesQCgprGV36ulvdHYqH9WXGseuu0y9MQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IxMq/f6Mt05QwitlLbUzR39tMMG0vjih5jZse6vzi8RlmTT0oN0JR//vyxlhdvjEd8UyNEgBHBPTAI6YEAAEykQQFIZ1JX7hl5RprhLCrvvuNj8v5Jo1H/DcqRpXW7Wh+Lw33OPAr/1JV7Ja68/CbM/1Tv1YjH/nPpOERls1cgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pbj0w1kW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LnQArHWt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pbj0w1kW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LnQArHWt" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626KXJL12625875 for ; Fri, 6 Mar 2026 21:39:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PMkU+4O21mSQ3lkP6yl/iUl6aZcUeJ/Rm0S5HObAZCI=; b=pbj0w1kWHHRb8I7D dfWYcpCQdGxNFADtjV/1azHVBRSkBDVSzDNurXi01erOFUER1P+Ydr+8NM2w0dh+ 4mZ/gRPwz+EpZ1sbaRqsxklZyBmf2vETV+MFx/fGtLGwvXq9QuTZvKSI4Gdr4ZvN 4cXzQo9JP39mLUMhfRhGIwCNjPbLwKfOlNU4dEOsj7oZ4d/dTI1/8vw3zBLTHSpV /kWM+fHP+S+1AM9zr5P+g8yX+KwB4HY78vE4ym49g9sTulEy+o43zO/czvdiVSEq OSzDQNA2ItYzHC8BnV/mMDP+5vUgDlppD+nZO9nUWtOrfv2yDxGQhPYVcwBasVHo v/U6RQ== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqv9aj9g6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 21:39:34 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2be21146933so7270223eec.1 for ; Fri, 06 Mar 2026 13:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772833174; x=1773437974; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PMkU+4O21mSQ3lkP6yl/iUl6aZcUeJ/Rm0S5HObAZCI=; b=LnQArHWt2rL5aVNwFfIJIj/6yh0zsblQx8cOC3l8gn5AbJaUqFXj8QeWGsikDWyIx5 ++y+paxWxanOdfeyAH6kBcc63X51HkTlxLdk1f3iC6OdnQYCWzIfqCW2GlI6Vgm142wm C0QhAloHrJqd+WJfqeNa14pXS6yM8a3BqOU36+OTn7RRnWPOUaEwWqsSkRQJlksTn4Hg vHUet5SEwAuecuXZ6z8SOSFNLF15RenJLgKkp0fQew+YAKDL716Vlp4Z95UJ16T8xPbe xVEW2SJuJ8ccHSmWeYwSu7pRj5jnNCKRfYthj/Eu39Zjdhbs+8mwEAvHB47FUg8L108M 2Lhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772833174; x=1773437974; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PMkU+4O21mSQ3lkP6yl/iUl6aZcUeJ/Rm0S5HObAZCI=; b=q17caWJOkXwb0+/W6ZukVEin4nx8yJgDMF49sDv7+1ePx+32x+aiIjELRpPyfr8pYL l1IaiT0X6z7+4OSC0gESgzY3RUKS+Z5Fg9+UPeEeNy1RJN9jXDd4JIz03Ej6rorX5Ast lsrl00HCjSYsCK4/VErrmHrWs/2DaFIRhBj04nKUaqi5ku0mFhdwaPRW4ei1CvRX8hPC W3MUSX0/83/LT88P53rvZwjdPWK7m+uVvVJKcrJjtc3m97R5jrczCHTVSmLq6ywQEjZp D3q3ttvI0k1DKdYLu0Fq0lxpOFpLQlX/eL95Y5Ju0fEU9AdHiQazvCWHDHo41KjZhrVb jkjA== X-Forwarded-Encrypted: i=1; AJvYcCWLXsqFMefSNmOzvTVV0s9JQYiQGK4O0/lJNeiZnTNaPOSG/Uy+iAV0ATo5GL34bcHjTelCqDkfN9b0P2k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1sLOKP/y9tdeyQbaxQjgY4qXgcqEKtKZN7JRmD8qcvLOuKeqb zvPV784MtTtbl3c7jIvRLoHNXa3dUPQUQXEroqEHzqOGZoSSuugmrjvgh6pXut9CgiY7pazAnRT matYTL8yktDKF032P+zc+MhJ/hqHlyUrdQAD74EJyRqxR9G6G7htlu0Xr6ulUhIDy9bE= X-Gm-Gg: ATEYQzz/P6kqYf6JRgtH+s4ol2B5DWcYX7WSCVVcTqZLK9EKgvAEktpyYKMKilwTZfz uz7Ad5zErAALwkMc9hP/30YkZOAOXuV7kqTDeTJhAT5zvtgqXiMxdWfptRAUItAAumRMMjK8FY5 eozaK4TsyYXo8dc4C/auLGF0fQxHonsGn04gC6ImzWOcPPmqh+cTIBfQQbJvQVM+zsYJZGGMPK0 9UAmDq20zjF+T6cSety/7183oJtnV581DaE3MP64QxWxYDmQ2swkxpcAhwqydDSNkIXDW64+Rgk 9joqVSabjP1mv8cf+d3PHYJlKmvm2vfGSbPOG0QTDJeKun9VMnpdmxx9tC4sDHo0IdLEFOAeIm0 Qe/8c+WrlWDWntF6Y1adyiLy1KQk1EnX40HAluRCntoyBMj5rosSRIFBslgrz7FXTFhIOK13dLc oHRtUErq3KTMpSCQ== X-Received: by 2002:a05:7300:ed0b:b0:2b7:fdb6:ccc2 with SMTP id 5a478bee46e88-2be4dfcaf2dmr1321785eec.16.1772833173867; Fri, 06 Mar 2026 13:39:33 -0800 (PST) X-Received: by 2002:a05:7300:ed0b:b0:2b7:fdb6:ccc2 with SMTP id 5a478bee46e88-2be4dfcaf2dmr1321770eec.16.1772833173322; Fri, 06 Mar 2026 13:39:33 -0800 (PST) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f94823esm2232796eec.20.2026.03.06.13.39.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 13:39:32 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 13:39:30 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/18] wifi: drop redundant USB device references To: Johan Hovold , linux-wireless@vger.kernel.org, Johannes Berg Cc: Jeff Johnson , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hy?= =?UTF-8?Q?gensen?= , Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Greg Kroah-Hartman , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260306085144.12064-1-johan@kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260306085144.12064-1-johan@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: j4hwEb0NFfGzj2c-_o2EYq-f1XfnTLD8 X-Proofpoint-ORIG-GUID: j4hwEb0NFfGzj2c-_o2EYq-f1XfnTLD8 X-Authority-Analysis: v=2.4 cv=G4wR0tk5 c=1 sm=1 tr=0 ts=69ab4996 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=0Zwkj1O83uEaq0GU0uIA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDIwMCBTYWx0ZWRfXwYVLrZoPP3Sr yXylokBiurm4wZZftODtPFQ1EtaT3Hogid59ONUNWcG40rRdxJnXsYoCQ1d1e/RKMhCPYkEIikZ BPi941NFShWh2oe0KvLDSTdI96NDUf4hMXkN5wXa3eGNbH7grvo3pM3tcnhRKZnVl6J9lOGi61F pkSKQeznNgChJn6fnsWmRsvMl7iv5sAe7nqDWbITgFzGRzOTWdxvN7M7sjOAtvbyiBtJ4B768hh s3JBzwQcf+7Bco93gak0aQ/HnjYcgKvE5S53uUp4tED7m1985sUlsWPxo55iYXi0sYL5ShlWoue V1WtXHYSEm++0x4n1SfUD59ls8ANDtwMA3BoqoH8T/l1vrweDLuD/yyK/xg/0tvc7LlqtyFc7M3 1RVUoP7sKGpmkGmpc1j7ObGyj0cm1UUiRwaQ40pTZ3wMf0oz3ZBoDwp0Q9aScja0et/9+fDJbnC QVxMktWLyICTEKqXpfQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_06,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060200 On 3/6/2026 12:51 AM, Johan Hovold wrote: > Driver core holds a reference to the USB interface and its parent USB > device while the interface is bound to a driver and there is no need to > take additional references unless the structures are needed after > disconnect. > > Drop redundant device references to reduce cargo culting, make it easier > to spot drivers where an extra reference is needed, and reduce the risk > of memory leaks when drivers fail to release them. > > Note that I sent an ath9k patch separately here: > > https://lore.kernel.org/all/20260305105803.17011-1-johan@kernel.org/ > > but I included it here in v2 for completeness. > > Also note that Greg had already sent a fix for rtw88 which has been > picked up by Ping-Ke, but who asked me to send a replacement. If an > incremental patch is preferred I can instead send a follow up for that > one later. > > Johan > > > Changes in v2: > - include ath9k, previously submitted separately > - include ath6kl and ath10k > - rename the ath6kl and ath10k disconnect callbacks > - fix a reference leak in rtw88 previously reported (and fixed > differently) by Greg > > > Johan Hovold (18): > wifi: ath6kl: drop redundant device reference > wifi: ath6kl: rename disconnect callback > wifi: ath9k: drop redundant device reference > wifi: ath10k: drop redundant device reference > wifi: ath10k: rename disconnect callback > wifi: at76c50x: drop redundant device reference > wifi: libertas: drop redundant device reference > wifi: libertas_tf: drop redundant device reference > wifi: mwifiex: drop redundant device reference > wifi: mt76: drop redundant device reference > wifi: mt76x0u: drop redundant device reference > wifi: mt76x2u: drop redundant device reference > wifi: mt76: mt792xu: drop redundant device reference > wifi: mt7601u: drop redundant device reference > wifi: rt2x00: drop redundant device reference > wifi: rtl818x: drop redundant device reference > wifi: rtl8xxxu: drop redundant device reference > wifi: rtw88: fix device leak on probe failure > > drivers/net/wireless/ath/ath10k/usb.c | 8 ++------ > drivers/net/wireless/ath/ath6kl/usb.c | 16 ++++------------ > drivers/net/wireless/ath/ath9k/hif_usb.c | 4 ---- > drivers/net/wireless/atmel/at76c50x-usb.c | 12 ++++-------- > drivers/net/wireless/marvell/libertas/if_usb.c | 3 --- > .../net/wireless/marvell/libertas_tf/if_usb.c | 2 -- > drivers/net/wireless/marvell/mwifiex/usb.c | 4 ---- > drivers/net/wireless/mediatek/mt76/mt7615/usb.c | 3 --- > drivers/net/wireless/mediatek/mt76/mt76x0/usb.c | 3 --- > drivers/net/wireless/mediatek/mt76/mt76x2/usb.c | 4 ---- > drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 2 -- > drivers/net/wireless/mediatek/mt76/mt7925/usb.c | 2 -- > drivers/net/wireless/mediatek/mt76/mt792x_usb.c | 1 - > drivers/net/wireless/mediatek/mt7601u/usb.c | 3 --- > drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 12 +----------- > .../net/wireless/realtek/rtl818x/rtl8187/dev.c | 4 ---- > drivers/net/wireless/realtek/rtl8xxxu/core.c | 11 +++-------- > drivers/net/wireless/realtek/rtw88/usb.c | 3 +-- > 18 files changed, 15 insertions(+), 82 deletions(-) > Johannes, will you be taking the entire series via wireless-next? Or should the individual wireless driver maintainers take their patches through their individual trees? I'm OK either way. /jeff