From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758771AbcIXN5U (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 09:57:20 -0400
Received: from mail-lf0-f50.google.com ([209.85.215.50]:36272 "EHLO
        mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751900AbcIXN5S (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 09:57:18 -0400
Subject: Re: [PATCH] mos7840: fix chars_in_buffer() return value
To: Stas Sergeev <stsp@list.ru>
References: <1474724823-28872-1-git-send-email-stsp@list.ru>
Cc: Caylan Van Larson <i@caylan.net>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
        Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <beb242ad-aad1-cb42-6d10-a997dfe98e45@cogentembedded.com>
Date: Sat, 24 Sep 2016 16:57:15 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1474724823-28872-1-git-send-email-stsp@list.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 9/24/2016 4:47 PM, Stas Sergeev wrote:

> The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
> a correct behaviour of that.
> mos7840 implements it wrongly: if you write just one char, TIOCOUTQ
> will return 32.
> This patch should fix it by accounting the number of chars actually
> writCaylan Van Larson <i@caylan.net>ten.

    ???

> This patch, unfortunately, misses the Tesed-by tag.

    Tested-by.

> The reported didn't test it, and I don't have the hardware in question.

    Reporter?

> Signed-off-by: Stas Sergeev <stsp@list.ru>
> Reported-by: Caylan Van Larson <i@caylan.net>
> CC: Caylan Van Larson <i@caylan.net>
> CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
> CC: Johan Hovold <johan@kernel.org>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: linux-usb@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
[...]

MBR, Sergei