From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: qcom: starqltechn: enable more features
Date: Wed, 18 Oct 2023 16:23:33 +0200 [thread overview]
Message-ID: <beb42f6d-3c3b-47ea-897b-2a0656ab5c0a@kernel.org> (raw)
In-Reply-To: <20231018123033.301005-5-dsankouski@gmail.com>
On 18/10/2023 14:30, Dzmitry Sankouski wrote:
> - enable usb 2.0
> - enable debug uart (uart9)
> - enable touchscreen
> - enable ipa so that we can bring up mobile data
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> &usb_1_dwc3 {
> /* Until we have Type C hooked up we'll force this as peripheral. */
> dr_mode = "peripheral";
> +
> + maximum-speed = "high-speed";
> };
>
> &usb_1_hsphy {
> @@ -444,4 +580,53 @@ sd_card_det_n_state: sd-card-det-n-state {
> function = "gpio";
> bias-pull-up;
> };
> +
> + s2dos05_irq: s2dos05_irq {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-18 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 12:30 [PATCH 0/6] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2023-10-18 12:30 ` [PATCH 1/6] dt-bindings: regulator: add Samsung s2dos05 pmic Dzmitry Sankouski
2023-10-18 14:22 ` Krzysztof Kozlowski
2023-10-18 12:30 ` [PATCH 2/6] regulator: s2dos05: add Samsung s2dos05 driver Dzmitry Sankouski
2023-10-18 12:30 ` [PATCH 3/6] arm64: dts: qcom: starqltechn: remove wifi Dzmitry Sankouski
2023-10-18 12:30 ` [PATCH 4/6] arm64: dts: qcom: starqltechn: enable more features Dzmitry Sankouski
2023-10-18 14:23 ` Krzysztof Kozlowski [this message]
2023-10-18 12:30 ` [PATCH 5/6] arm64: dts: qcom: starqltechn: disable crypto Dzmitry Sankouski
2023-10-18 12:30 ` [PATCH 6/6] arm64: dts: qcom: starqltechn: add supply to framebuffer Dzmitry Sankouski
2023-10-29 7:20 ` [PATCH 0/6] This is continued work on Samsung S9(SM-9600) starqltechn Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb42f6d-3c3b-47ea-897b-2a0656ab5c0a@kernel.org \
--to=krzk@kernel.org \
--cc=dsankouski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®