Re: [PATCH] riscv: select ARCH_USE_SYM_ANNOTATIONS

["Clément Léger" <cleger@rivosinc.com>]

On 05/07/2024 15:23, Jisheng Zhang wrote:
> After commit 76329c693924 ("riscv: Use SYM_*() assembly macros instead
> of deprecated ones"), riscv has been to the new style SYM_ assembler
> annotations. So select ARCH_USE_SYM_ANNOTATIONS to ensure the
> deprecated macros such as ENTRY(), END(), WEAK() and so on are not
> available and we don't regress.

Hi Jisheng,

On which branch/series is it based ? I tried it and it fails on
errata_cip-435.s which still contains some uses of ENTRY():

ENTRY(sifive_cip_453_page_fault_trp)

Thanks,

Clément

> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  arch/riscv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0525ee2d63c7..c51b32a8ddff 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -62,6 +62,7 @@ config RISCV
>  	select ARCH_USE_CMPXCHG_LOCKREF if 64BIT
>  	select ARCH_USE_MEMTEST
>  	select ARCH_USE_QUEUED_RWLOCKS
> +	select ARCH_USE_SYM_ANNOTATIONS
>  	select ARCH_USES_CFI_TRAPS if CFI_CLANG
>  	select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH if MMU
>  	select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU