From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B283930C167 for ; Sat, 6 Jun 2026 20:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780778063; cv=none; b=CcLwEB8VPrC/02dynq3q1l/tXqxS+wiC26bkpI+ICqQ74YPpJuUTm7oRm7YYSuU0RE7CQvXm3NfDQ0QiRgHie+aDs7qKHdyFBSu3WWEguGzOvaXJXChn/MXucjib6jsKEwTBxhqXJzJIr1uu+5m+Q4DBgTefXzsDWqkKreWgTbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780778063; c=relaxed/simple; bh=BnWRu81zM0qbnsw2zv0pp5nf8QxwugmmRPI9Onn6C10=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=h6gqL9TCW9Ld5z8X1go6HIjdFQ6D5CTrJt4jTCxWi2nB7pd/pdmjhys7VRapfpE4aLXSuXVNhpOvy+ITqKnBUQksPLZqHnI6YbK8jlH3JgzZpISSchTETZLbdFGZMTK0o0HQpSpNOsLYwjusML0qVg5qJ9s6z0x7Y4MBoM3JGnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UL3BtY95; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UL3BtY95" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36d98b9aa9aso2738466a91.3 for ; Sat, 06 Jun 2026 13:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780778062; x=1781382862; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BnWRu81zM0qbnsw2zv0pp5nf8QxwugmmRPI9Onn6C10=; b=UL3BtY95p5HXO2pzP50Q3eK5X/09Dgd0hQKFaoASwu55+qXPRTu5ONMOlUJQM9EsVN rMih08x+ZXvEaKkG2Vqt2omDSWPGpAf2QNREQC/cRj/Tzlb7vIrLMU46f8Ak+Aj+gQPf 9AVJZsFN9k8pHwp7vtMq4x3ncoc+VzirgC4TKDA7O2GHZYRinXhyraHlrBYZ2SVml6ko ZvzSrFAs2W3tJlFskVCtj4Zx45QkahlcgC1MX/R83LE2cK53OM2kzLpZC5nIau567l4p AoJn4hxBnIpQ0kBwn2jkBoObLFfW+3JS3H/SdH0V0h+sKd5SEP9R0+hVgNMnXDbZazkv I/2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780778062; x=1781382862; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BnWRu81zM0qbnsw2zv0pp5nf8QxwugmmRPI9Onn6C10=; b=U8dI1Gt2GsNxQhb8ZTkES7EEOgW5HWkCOR2sBkmXV1lisdwN9w6/xyyyPcHeMb1W+Q KpadhbluXxylT9yBtz4XBxSYJ4Hrql9rrMrb6EdWkq4ddbQAEfqidpnWV/T9qsQWv2UK uDeKyvrN6Gw4vALwti3/OFlTzTEEHp+jnIaVxi7PaUMjMcuOAmCA47qLvRt6r3xFll1X KLXB6hc6mIVmoyUffUHNmoxNBMuIqVxogkLDXrE8XVV9oiQP/7Zf70UkfTy9/U1M7XYB G5F45eexXfk7KtVSKZ+FbwF29Lkkt4SYZLC+eXk8JTfI03NP4kLB6DZs3Rop7yoQQ6Ge j1mA== X-Forwarded-Encrypted: i=1; AFNElJ9uMaCi6wyqiV1xbHUyDiuU3YbNdbS8BM5GwQR70Diclt66TH1UNbS4XMerZONlwjLPlCJDhxDqyQPVI+I=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwd9v5zyOdgOOTZJ5TMX+9jHIrlfs7ZNeD61qSk7Ii1Spbzf9k RaNMgVtxfGfI60noZimKj9Y4iE7C8RHRyVOur6FmgbQYkGbrZeyBqPJe X-Gm-Gg: Acq92OEPX74pYxnCuaG42pd254zRMjek87SSrb+efcxTtWQGEL7PEHRyr+Vq9m/oAsI fivLcPF42QxBJvSf/sCzHI/nvlFYEYmT6NK5L90mZVaB+v3wWNFZ8qPH5AqE1NHE601Bhvp1t2H T4wDnT613ZdKa9HIuKipkiiQKNn5AuEvSO4nc7egs0Gtu9Vnz+H+Yf/nTdc77Y9UanMHTQ4nGJ3 hk/krilOApKFxahvUDe1+snQk80PQfWCvhboPtDGAyna1xGwbvElZRvtzG8ZYbKmPUt7KD2gkNF U6USgMGPBey+Zr5BpuCpQF3ekup1TLQQB7Ty0vT3S/IHB9HkwDT2VFJqib3OQaHbJHc0Dg9Fxy+ 1rdUCMrMqjkkcMcum0DXIYflRLiulSCkD8+/2nENsnmBbl2BCjsAfvKcAoD3Dik277JTevnED8u R6CB9W19mpoV6oPIB3hTmpUu1kDwJGiWfZsOIQEOTfI0787BPs+vCNndBNjbrQKA== X-Received: by 2002:a17:90b:558b:b0:369:de03:29c8 with SMTP id 98e67ed59e1d1-370f122c744mr12490424a91.23.1780778062093; Sat, 06 Jun 2026 13:34:22 -0700 (PDT) Received: from [192.168.0.13] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf82fecsm10869882a91.3.2026.06.06.13.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 13:34:21 -0700 (PDT) Message-ID: Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: add tests for PTR_TO_FLOW_KEYS offset bounds From: Eduard Zingerman To: Nuoqi Gui , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: John Fastabend , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Sat, 06 Jun 2026 13:34:18 -0700 In-Reply-To: <20260606-c3-01-v3-v3-2-97c51f592f15@mails.tsinghua.edu.cn> References: <20260606-c3-01-v3-v3-0-97c51f592f15@mails.tsinghua.edu.cn> <20260606-c3-01-v3-v3-2-97c51f592f15@mails.tsinghua.edu.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-9 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-06-06 at 18:50 +0800, Nuoqi Gui wrote: > Add verifier tests covering pointer arithmetic on a PTR_TO_FLOW_KEYS > register. This covers the bpf-next regression where an out-of-bounds > constant offset introduced as flow_keys +=3D K and then dereferenced at > insn->off 0 was accepted, while the equivalent flow_keys + K direct offse= t > was rejected. >=20 > The tests check that in-bounds constant arithmetic on the keys pointer is > still accepted, out-of-bounds constant arithmetic is rejected for both re= ad > and write, and a truly varying offset from bpf_get_prandom_u32() remains > rejected by the existing PTR_TO_FLOW_KEYS pointer arithmetic rules. >=20 > Signed-off-by: Nuoqi Gui > --- Acked-by: Eduard Zingerman [...]