From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010014.outbound.protection.outlook.com [52.101.61.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521A33793BF; Wed, 8 Apr 2026 15:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775662931; cv=fail; b=ZMLhdXURkWgz02sjigZaNaYcXge1BcyHhR80g53+k5LNikznF0XwsXtHZD0gUaGPffcGZKdM6+SaU87a0BiurxS2wLNnABP8pT3K6ORLMcO7fSErtQWeUlTBoQsu773uD+ibTVjSeSS0cMTCKoR7gCF0NLVgZa5hJ9EkMXcaca8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775662931; c=relaxed/simple; bh=TKjEFJA35ceJIg6uSlqeHfK9DshEN7WRsGWODMl2Dkw=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=utg/nPyiekthjbbPXwndC8ELwfTNx7zhOHeNdM9qjkl/9Uac97/dKrTLBNr1tPQ+c4saxrw/No0wikxdby051GKaQYzK9GNo0sb9AvaTCAKhVsJGLV1X01MJB7o2yjhPPWRVsnZfyqTg6SKaJc8vpE+kpUvSDs7qQHHNwqtdBTE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eGusi1Oy; arc=fail smtp.client-ip=52.101.61.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eGusi1Oy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RHC+1SEP6cNjTaUYQOpzZk/MsCo5uEAcywmK0zXIC5TdEFxV5OHFw6zXi54I4RFhuikDyPBb7AWhmWo+LU/EM1vU2zaI44yzYOdDGXclBiA3cMfbxCr8x2+yF6IIus6iGOlAS5LlbTFAERXEN3pBHTbQiGb4E1y2gK96EnCk/VwfhHxLcpHdImci29CvxsUGkzl/Nyh7rJ0jC3Q2h2jr6gFAtmU06cLnFccrkkFJTyeVMMbiksGdh13l/6QwL8VwKRkPR2jHjlLymO9Dlpgh31pRKsvmJ78l1e83P9//heLBybYiBLWkeny+er46uuK7p8cCu/L9ZC/ptMe79da+BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dk14xnyVe1Pfk0w81az+3HTXr68N9blI2ikzFrR9i4c=; b=LQmlQf9ljDWeYraGyovK1r1uTUQfCgmVE14nDS8i7CH5SGiI9bM8o9+QNU3RHoeTJxXEHfGX2vijYCKldQKtbfKDuB8F4nsexInGyMCF95VsaFaCkM7sgd1TT3KEi/qv9GwZEVeEOExNIYwyPgTVkQIwTRpoWll4r7V4HazY+yCqOVuE1V1IswfUPihKDQo4bbYZgC/JudmFjsLhYF3jOGuUwCbbbJMrZKn4U60mp6t4LUdoqyhCwr6N0rlj3M3JtV8vPXPibA2sFdSlPBEw3KlIEYTgG9H2CH1Z+AgZ1kcIne9QWvqq4DH9AMWvz2UJKJSx1dal52cK0txpRzEPJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dk14xnyVe1Pfk0w81az+3HTXr68N9blI2ikzFrR9i4c=; b=eGusi1OyBb4M/5UZsmg0HT8fuF7TIDL7FnLVljM9V5DViMcyJvEAClff1B/HOV8/7yFWSnncN3kAw6Fbd7PDwyosTeTGCzlOGAhTWekMaQOsNl7qcNkYU25m53aZNxdbt+yJ40FXKURDL+1JerjLjsjQVkCHhGN0D3wh72sf5gg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS2PR12MB9567.namprd12.prod.outlook.com (2603:10b6:8:27c::8) by DS4PR12MB9635.namprd12.prod.outlook.com (2603:10b6:8:281::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.19; Wed, 8 Apr 2026 15:42:06 +0000 Received: from DS2PR12MB9567.namprd12.prod.outlook.com ([fe80::636:1b52:24ca:d7e5]) by DS2PR12MB9567.namprd12.prod.outlook.com ([fe80::636:1b52:24ca:d7e5%3]) with mapi id 15.20.9769.017; Wed, 8 Apr 2026 15:42:06 +0000 Message-ID: Date: Wed, 8 Apr 2026 21:11:58 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ASoC: amd: acp: update DMI quirk and add ACP DMIC for Lenovo platforms To: Syed Saba Kareem , broonie@kernel.org, alsa-devel@alsa-project.org Cc: Sunil-kumar.Dommati@amd.com, Mark Pearson , Venkata Prasad Potturu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Charles Keepax , "Mario Limonciello (AMD)" , Hasun Park , Krzysztof Kozlowski , Kees Cook , "open list:AMD ASoC DRIVERS" , open list References: <20260408133029.1368317-1-syed.sabakareem@amd.com> Content-Language: en-US From: "Mukunda,Vijendar" In-Reply-To: <20260408133029.1368317-1-syed.sabakareem@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN4P287CA0126.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:2b2::9) To DS2PR12MB9567.namprd12.prod.outlook.com (2603:10b6:8:27c::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PR12MB9567:EE_|DS4PR12MB9635:EE_ X-MS-Office365-Filtering-Correlation-Id: d103ba82-2c06-46a1-6ff4-08de95856349 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MAnNg17B4vVVv/P/6Fy42UBVNyoPtrYg+/z3+pf8FakH7GBJUF02WkcT0pDu2QApK9UhU/ysXxwAQW2wbwyG0SB7Cqi+PnhDhUC6jMvArkpUMAhurCwSTCCkxeNFNPMvVEYLoChvrDXeNbm172boJXah0dyTLRWZ4xZwe2e+E8A6cn8hZAIoLEBZrtSYyULpUfuUs8AkrKfCqPXQpPf17A9EHayTRjAaRl3WscpfcSwccsb/wpQqyW32IbCEBWeAUN0+OhAb+hCcQzKnb0S62gqLtsqCleUVvb7CveWOG147TET/+uvwxxIppJgWrzEdx4NQ/HnD84TReVmT4sqQ6bZifRMk9hl0PJdNDb58RpCRIPv93EZMubBvcmt5AqiF1GnVp2BTXK/LKxkRnjdN8zGBfz72DRS2vQGLFcLAq/9QFrck5udbWkzBmdLhqROWnIgP1hswo9O2hIGclqQlbPLS2i7r4XgSAwdETLNDIoG43huVDd6h8ap8xY3ZQFPoeYcnnRjnynC7odW4t2ZLnoBDkOIWHnRQ+gB5k8xblENEOkYi657/REG+R46m11+AwroO8pTeFjz6Kpr4wcgpRD99S92esAZPpGLvmIXv/rT3dou6jBkuR9mghnqWtWWfP1jTi1oGhS7mnJ+4LReE+p10W+bcvMZzsHZpA0DQpTWujtIQTpBdBy5pq/NLM9FJZUco8e7ik9oTasLi1cZ9ukhsTHHNgRy9RChYg/sC08Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9567.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEdaRUp2WG1rT3NJeHBMMWIrREtacFRSekdxdWdoSDJvbGoyOE9TeDVjQXZT?= =?utf-8?B?aGJSS0Z5WlZITVpTajdERkNSWFYxZ1hVdVpPeGRLZW9MV24yTmZPT3NtNm5T?= =?utf-8?B?TFBRVVRvem81dldQb1JlWm5URUdIMU05YkxPSTZxZVZ5b3BWQ1RNdmtBc2Z3?= =?utf-8?B?a1ZCWWZOeldMWTZxS0RZVTNvMzBTTXpIcFNubVlzcDV3bFpWL082VG1PV0Nz?= =?utf-8?B?M3ZpcWozdVlWMEgxTXhQbzVTNytTR3N6RVBIQWtvMEdWV2lVaktRWG1JV3li?= =?utf-8?B?THRBNkFYeks5MWNWNTF2dGRoZEhrUW9ReUZlNkVlNW9UcnpWd1JBUDdWK0Nj?= =?utf-8?B?SGdjdXFSaE9ZQXVLMlJXaXFHRXdQYjBFMTJUcysydk4xRlNsV240dDI5R0t6?= =?utf-8?B?MjR3YTcxZjdOc3pjUUxXOG9XUVo5RkJIemVtNHFtRGdNT21lNnJhbytEcHFv?= =?utf-8?B?cDdBM1d3YXNudVlIZnRMTDQyRU5tY2RwalllS0c3SjNLaFFlTjIzRVhzY0ZJ?= =?utf-8?B?VDJVSFp0QmNKN0xqLzg1aHJuQ0MrMGJxZW11SWJuMitPTXhnNWFuSUphL2RM?= =?utf-8?B?VHVuVWJuaTU2S0F0djZ0ZDdkajc0dXVyWUtCMmtaeHdSdWowSHRKRktVSUti?= =?utf-8?B?bVBSNDR6Q3duTFhGZ2xMMjF3TXEvdEwzWDRtckFLSmZQUFR4TkJBdEJFek5S?= =?utf-8?B?MU9zZFBUbmlaRktpbS8vZktEWTgvZTR4TStLcGFoVnFlMWszREoxdmM3WXlS?= =?utf-8?B?MjBYakEwZEZMNWJMb0pFY1RjSmNSUkg2YmpTMnFMQkMySmpUNVhCbDZRVHhQ?= =?utf-8?B?Q2tyWUhKMyswSWhlbnEyWEZ0ZHNTb2N1OU5naFlFODZYOXhQWTN0dU92cHRu?= =?utf-8?B?QzVQMGVOY3FWRi9QM29lMVRIV09XNXdUWTdwdUt6T2hJb29KcmFxV1NRNEdM?= =?utf-8?B?UlkzVDFJSVV3QXJOQTNXWXJPYmplVkF0aEVMSG9jY3Naa2dvb0J2ajRKUzJX?= =?utf-8?B?enlQOXJ2dGdxY0taL3d0dEQzSDc5UUNmK0Fqald2Y3FwZ0Znam8ybFVORHFI?= =?utf-8?B?cVhWUXJpSlI2SnIzSXkrU29MMWdydUo1TS9QNkUrYlJBb2xDNCthVGZ4cXFB?= =?utf-8?B?UDhOTDBsR1lqa2o5NThHSVBLYnFaVGw5eWZoZTVxMjRwVlRmcHNXVXhzUUhj?= =?utf-8?B?ci9rTXlMeGRZR2lZUUovTEtQbDlob3BKcGY0S08xdVhBRFlabytQT0xKR05s?= =?utf-8?B?cDJML0Zqc0dnRkZZc2pRRzF3TEQ4K0lrZ0pvU3Z0YjVNUThFc1ltMTRleDcw?= =?utf-8?B?em5YaTljVUQrQjdkTEpDaXNtRnJLSU40ZFBKWmptOVJQaGNrQk5vcWo1STVZ?= =?utf-8?B?aklqaUUvK3BQRUY2eU9lczdZaERaVkpMSjNVOThvZC82ZXovUzgwbG00a1Rk?= =?utf-8?B?NU8zd0tVcm93SHlhMFg0QmxnbW1pMmwxN25hcFkveDd2N2NZSWR6U3kweEVE?= =?utf-8?B?SWJ3ZWU2MUw3NnlLTFpwSm43alhpTGRhanZhcXJ1YjRHSisreHM0c1BuN21K?= =?utf-8?B?TWZVdHZzb2F3UDNQZU9rOEtQL3VNakVkYVdMRkVnRUltbGFKSnVxY3RsU2po?= =?utf-8?B?dVZqSVFYVlhqNzFZTkl4dk80ZUthQWlEMTg5Njc3QW13RDh4SkprOW1hbDli?= =?utf-8?B?L0VjTVhiYmt3eHdkMzZ5K2tJRW9rVnlIMDBKVmIvcmVremlNZjlhL0c1ZElR?= =?utf-8?B?VHBCVTNOK0QwNktMaUpXTWI0ZWxNQk5YYmpIeVN6TTJDdUZKNnYrTDBwcWs0?= =?utf-8?B?blM4TW5MU09vSXQ0ZUZUaW9sdUgyT3YzdVFNbGs5WEpxcXRpRjVkMjNQeXdy?= =?utf-8?B?NkN1K1Ria1VtbVlDbnJ4cWh2UTZVSTRBS21RVlV5QUlZekFmdWhZSUo2SXo1?= =?utf-8?B?YXk5cklEMnVpZ2hQSENxeTFxelVjN3VYN3VjTHp2ZVBBMkpoQ1ZyNTIyR3N4?= =?utf-8?B?TGVpaU9IWkJSajFoZnBhVUQ5NGlGd0NsVEtwNm1HeEhtU1h1ZnhXTUtmcWFz?= =?utf-8?B?SmdBMzVCcFpJa0tZUGZzZDAxREpSbnBPMENGWjU2SDFQUGJNR1ZxTEUvWWVJ?= =?utf-8?B?M1NuWGdFZ1ZTKzBHUXZzaW0yajh0S0dIV1h5OFlGZHpLZ2xhV3hSU0tJVjZn?= =?utf-8?B?RDdJaWF6OHA4K3lmckNDMHZweXpPekhidDJYamFuTXdzY3c0TmVRSlVLMjgw?= =?utf-8?B?Tm4yekZyYTdqQmJncVpOMkhicFdQQjhsT0lwakFsbC8rdjFMbUR2eG96ZENx?= =?utf-8?B?MStXNzNhT0RVRW5uSFNHeVczenFrOFJpa1lGdGRTa1BYNzlkaURZUT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d103ba82-2c06-46a1-6ff4-08de95856349 X-MS-Exchange-CrossTenant-AuthSource: DS2PR12MB9567.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2026 15:42:06.3795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hOzDloKLIa3PhWSpmJdGoTeSqeu4yacv5r1I1/aA2YhMgz3GYlSw64HxJC+Rj7BVac384X4XOiBHY7VoPEtUEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR12MB9635 On 4/8/26 19:00, Syed Saba Kareem wrote: > From: Syed Saba Kareem > > Replace DMI_EXACT_MATCH with DMI_MATCH for Lenovo SKU entries (21YW, > 21YX) so the quirk applies to all variants of these models, not just > exact SKU matches. > > Add ASOC_SDW_ACP_DMIC flag alongside ASOC_SDW_CODEC_SPKR in driver_data > for these Lenovo platform entries, as these platforms use ACP PDM DMIC > instead of SoundWire DMIC for digital microphone support. > > Fixes: 3acf517e1ae0 ("ASoC: amd: amd_sdw: add machine driver quirk for Lenovo models") > Tested-by: Mark Pearson > Reviewed-by: Mark Pearson > Signed-off-by: Syed Saba Kareem Reviewed-by: Vijendar Mukunda > --- > > Changes since v1: > - Updated DMI_MATCH to replace DMI_EXACT_MATCH for Lenovo SKU entries > (21YW, 21YX) to ensure the quirk applies to all variants of these > models. > > sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c > index f86d14adc721..0f21e5f64531 100644 > --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c > +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c > @@ -99,17 +99,17 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = { > .callback = soc_sdw_quirk_cb, > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YW"), > + DMI_MATCH(DMI_PRODUCT_SKU, "21YW"), > }, > - .driver_data = (void *)(ASOC_SDW_CODEC_SPKR), > + .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | (ASOC_SDW_ACP_DMIC)), > }, > { > .callback = soc_sdw_quirk_cb, > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YX"), > + DMI_MATCH(DMI_PRODUCT_SKU, "21YX"), > }, > - .driver_data = (void *)(ASOC_SDW_CODEC_SPKR), > + .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | (ASOC_SDW_ACP_DMIC)), > }, > { > .callback = soc_sdw_quirk_cb,