From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F701C001B0 for ; Wed, 5 Jul 2023 12:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231987AbjGEMr2 (ORCPT ); Wed, 5 Jul 2023 08:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230488AbjGEMr0 (ORCPT ); Wed, 5 Jul 2023 08:47:26 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3CF910F5 for ; Wed, 5 Jul 2023 05:47:24 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b6a084a34cso100553321fa.1 for ; Wed, 05 Jul 2023 05:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688561243; x=1691153243; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k7AhrM/NDMrVR6eVPD7oN790ZYJE1/FcirAMl2b04pQ=; b=mCeVcIOm1PPFrD2UKvevfj8L2uOKCTQBZ4OJCsj5Hp29KJ0/XkNI5HxrDMTdPmM9N1 1ex36PNrVwZf+ZrHdkJQDp1Rc0WWzru+ZUY16eEh7R1vze2VLkVwHiwsPG6Lu/EEfhB9 5yIN/V1FABMjagHcNwNeGHOlZxS1yVcMVIrgSyxhyEES05ngtAN0yF3JN76m1hPLc/Pw QtlbzEPj11xkqsHFVOAwyZgJnplHZTLdQkAdYBxDN8Vb/0ct79wzVjZDNMHc4Um7nfZJ zwJN01lwdZFoj+6/9VXv4XpC8/Z0oyNKYHsZCiALRA1Xv+KRdgB6nY3ExDtAlYjfXZzg H1TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688561243; x=1691153243; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k7AhrM/NDMrVR6eVPD7oN790ZYJE1/FcirAMl2b04pQ=; b=DM2YOogscT2DocWF/jz9caji8NuDAize0PfjTQjuAiJ7+qD6USFG0AEUJsoRRjp1sM NKkpY2IFiHeNhmRcbAzadWHnWOXhdou3DRqRIKyV6XPmQdcp68dx7Y2Nv3mi5Oo1ip2H fXD261it17v8f5YE2x7s7vQxwTRXFigVR8d3T8at12a/Uy6kMr6QRD0wFMqil+5+nmaV eQkarYIgC7uGTWWFeDxSS8C1aq44wkG1/3X4+cl/tOS2f018FK42niUe4MOihotvDxn+ Bueguc9Sv03PASGreBpaEkONa/wNliNHZ0FTs841o0gWfynfEuReH9JKSkKLvUYI/V/8 lIiw== X-Gm-Message-State: ABy/qLYK+ejXYDODc6GlGG99gbYLUvmHVvvMdnQA+R8L9uLPl/TkfB+i i0D4KzN18QTD9x2q2w+GgaKpjCki1qcUEbN1s/1OXQ== X-Google-Smtp-Source: APBJJlGzWamSYpfesn8gFD1Q+Sg/TrWeLhLTFZLCfS3wI3IL97fduA0ZhIzKK1xWYaARlKInulx8JQ== X-Received: by 2002:a2e:8783:0:b0:2b7:2ea:2e27 with SMTP id n3-20020a2e8783000000b002b702ea2e27mr164767lji.19.1688561243243; Wed, 05 Jul 2023 05:47:23 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id s6-20020a2e83c6000000b002b69febf515sm5714758ljh.125.2023.07.05.05.47.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 05:47:22 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 14:47:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH RFT RFC 1/3] arm64: dts: qcom: sc8280xp: Add lower cluster idle states Content-Language: en-US To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski References: <20230619-topic-sc8280xp-idle-v1-0-35a8b98451d0@linaro.org> <20230619-topic-sc8280xp-idle-v1-1-35a8b98451d0@linaro.org> From: Konrad Dybcio In-Reply-To: <20230619-topic-sc8280xp-idle-v1-1-35a8b98451d0@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.06.2023 18:18, Konrad Dybcio wrote: > Apart from a total LLCC + APSS power collapse, SC8280XP can also put > either the DSU rail (CPU + L3), or VDD_CX in power collapse. > > Add support for these lower idle states to allow more flexibility. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index ac0596dfdbc4..d524f851cb53 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -285,7 +285,23 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 { > }; > > domain-idle-states { > - CLUSTER_SLEEP_0: cluster-sleep-0 { > + CLUSTER_SLEEP_L3_PC: cluster-sleep-0 { I guess this is misleading. cluster-sleep-0 would be APSS_OFF (cores and caches have no power) cluster-sleep-1 is ok (the CX rail is 0.0W) cluster-sleep-2 would be AOSS_SLEEP (a.k.a. we've entered the SLEEP state within RPMh and the system needs to be woken up by PDC) Konrad > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x41000044>; > + entry-latency-us = <2752>; > + exit-latency-us = <3048>; > + min-residency-us = <6118>; > + }; > + > + CLUSTER_SLEEP_CX_OFF: cluster-sleep-1 { > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x41002344>; > + entry-latency-us = <3263>; > + exit-latency-us = <4562>; > + min-residency-us = <8467>; > + }; > + > + CLUSTER_SLEEP_APSS_OFF: cluster-sleep-2 { > compatible = "domain-idle-state"; > arm,psci-suspend-param = <0x4100c344>; > entry-latency-us = <3263>; > @@ -632,7 +648,7 @@ CPU_PD7: power-domain-cpu7 { > > CLUSTER_PD: power-domain-cpu-cluster0 { > #power-domain-cells = <0>; > - domain-idle-states = <&CLUSTER_SLEEP_0>; > + domain-idle-states = <&CLUSTER_SLEEP_L3_PC &CLUSTER_SLEEP_CX_OFF &CLUSTER_SLEEP_APSS_OFF>; > }; > }; > >