From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 467B81D0DC6; Fri, 6 Sep 2024 15:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725638105; cv=none; b=OQbxXBJbKPxkst8tvncQEinfvu4LZShtg1C547tvf4ZCOfF7P0NuWHPq2AFmcVWoKlYsUnU6f8VCkPhHhh6+Ar3aZY3YiwkRncw4IIxM1i6gQ23LCVQc6wno8O6Z82m9/zoQriViY5kElltQTuHAdc0RXfcNymJG2ux/ZgZCFi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725638105; c=relaxed/simple; bh=vZcy0j14JHhKQjyRF3aCzSfotzc+fODYaeaV+eyJ68k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WuzyawXWd+BpVmCtwNdzGwsJDs5ICxcpmOzmh9o8jGneUegmJ/QJT20jl7kALPAMiARQYUayWwusmxR2wus9IdARZZXC5WivuKhZUHNb+cP6/66Z91S/UnllyiueqbVwv0NUXYjSVHLZsq6ZAEE2pAaWM15U8GNzCB0S6cL+WnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=d/dX/Yqd; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="d/dX/Yqd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9gmhx+3YknuSIRL8TWBm0tczYK/bI4fx8rop8t+Isog=; b=d/dX/Yqd0hvLno6IuvSrJq3xLG PbkPQAz2jDR0MsAmvM+UHgwGumgp8WU0yfGOJ+1eaXlo02U7z9N2n86a60JsHrRxCEREopRF7hjaB zgt77qavOK9oYqjQjAvGWb5O5G77kcRFj/J1uZFc9js/BsCQFSfCZHyVnbKlpZnczrZM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1smbIP-006qHD-FL; Fri, 06 Sep 2024 17:54:49 +0200 Date: Fri, 6 Sep 2024 17:54:49 +0200 From: Andrew Lunn To: Jeff Daly Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ixgbe: Manual AN-37 for troublesome link partners for X550 SFI Message-ID: References: <20240906104145.9587-1-jeffd@silicom-usa.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240906104145.9587-1-jeffd@silicom-usa.com> On Fri, Sep 06, 2024 at 06:41:45AM -0400, Jeff Daly wrote: > Resubmit commit 565736048bd5 ("ixgbe: Manual AN-37 for troublesome link > partners for X550 SFI") > > Some (Juniper MX5) SFP link partners exhibit a disinclination to > autonegotiate with X550 configured in SFI mode. This patch enables > a manual AN-37 restart to work around the problem. > > Resubmitted patch includes a module parameter (default disabled) to > isolate changes. Module parameters are not liked in networking code. They are very user unfriendly, and poorly documented. Why do you need it? Is this change risky? Andrew