mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Alan Tull <atull@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Pantelis Antoniou <panto@antoniou-consulting.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Jailhouse <jailhouse-dev@googlegroups.com>
Subject: Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT
Date: Wed, 25 Apr 2018 07:38:02 +0200	[thread overview]
Message-ID: <becdd908-f075-e434-1ac0-6bc9cfe3829e@web.de> (raw)
In-Reply-To: <CANk1AXT=zuKHgV4yUVTyWTHmbh5mYtNaO5GfiyDo99zhe4sQXQ@mail.gmail.com>

On 2018-04-24 20:26, Alan Tull wrote:
> On Tue, Apr 24, 2018 at 11:08 AM, Alan Tull <atull@kernel.org> wrote:
>> On Tue, Apr 24, 2018 at 12:29 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
>>>
>>> We have drivers/fpga/of-fpga-region.c in-tree, and that does not seem to
>>> store any pointers to objects, rather consumes them in-place. And I
>>> would consider it fair to impose such a limitation on the notifier
>>> interface.
>>
>> The FPGA code was written assuming that overlays could be removed.
> 
> To be more specific, drivers/fpga/of-fpga-region.c currently saves a
> pointer to the overlay and uses it only during the pre-apply
> notification.

Even more exactly: You are saving a reference during pre-apply and
freeing that one again on the corresponding post-remove. That is what I
would have expected as normal usage of the notification API as well.

Jan

  reply	other threads:[~2018-04-25  5:38 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-04  0:17 [PATCH v7 0/5] of: change overlay apply input data from unflattened frowand.list
2018-03-04  0:17 ` [PATCH v7 1/5] x86: devicetree: fix config option around x86_flattree_get_config() frowand.list
2018-03-04  0:27   ` Frank Rowand
2018-03-04  7:20     ` Thomas Gleixner
2018-03-04  0:17 ` [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT frowand.list
2018-04-04 22:35   ` Jan Kiszka
2018-04-05  0:55     ` Rob Herring
2018-04-05  7:22       ` Jan Kiszka
2018-04-05 19:16         ` Frank Rowand
2018-04-05 19:26           ` Rob Herring
2018-04-05 19:37             ` Frank Rowand
2018-04-05 19:13       ` Frank Rowand
2018-04-05 19:17         ` Jan Kiszka
2018-04-05 18:59     ` Frank Rowand
2018-04-05 19:13       ` Jan Kiszka
2018-04-05 19:28         ` Frank Rowand
2018-04-05 19:38           ` Jan Kiszka
2018-04-05 20:33             ` Frank Rowand
2018-04-05 21:12           ` Rob Herring
2018-04-11  5:42             ` Jan Kiszka
2018-04-22 10:30               ` Jan Kiszka
2018-04-23 22:38                 ` Frank Rowand
2018-04-24  5:29                   ` Jan Kiszka
2018-04-24 16:08                     ` Alan Tull
2018-04-24 18:26                       ` Alan Tull
2018-04-25  5:38                         ` Jan Kiszka [this message]
2018-04-24 21:15                     ` Frank Rowand
2018-04-25  5:22                       ` Jan Kiszka
2018-04-25 18:56                         ` Frank Rowand
2018-04-25 19:02                           ` Frank Rowand
2018-04-25 19:40                             ` Jan Kiszka
2018-04-25 19:53                               ` Geert Uytterhoeven
2018-04-25 20:09                                 ` Jan Kiszka
2018-04-25 23:07                               ` Frank Rowand
2018-04-24 20:56                   ` Frank Rowand
2018-04-25  5:23                     ` Jan Kiszka
2018-04-25 18:40                       ` Frank Rowand
2018-04-25 20:07                         ` Jan Kiszka
2018-04-25 20:26                           ` Alan Tull
2018-04-26  0:20                           ` Frank Rowand
2018-04-25 14:59                     ` Alan Tull
2018-04-25 17:41                       ` Frank Rowand
2018-04-25 18:19                         ` Alan Tull
2018-04-26  0:07                           ` Frank Rowand
2018-04-26  0:10                             ` Frank Rowand
2018-03-04  0:17 ` [PATCH v7 3/5] of: Documentation: of_overlay_apply() replaced by of_overlay_fdt_apply() frowand.list
2018-03-04  0:17 ` [PATCH v7 4/5] of: convert unittest overlay devicetree source to sugar syntax frowand.list
2018-03-04  0:17 ` [PATCH v7 5/5] of: improve reporting invalid overlay target path frowand.list

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=becdd908-f075-e434-1ac0-6bc9cfe3829e@web.de \
    --to=jan.kiszka@web.de \
    --cc=atull@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=jailhouse-dev@googlegroups.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=panto@antoniou-consulting.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®