mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ge Yang <yangge1116@126.com>, ardb@kernel.org
Cc: jarkko@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com,
	 ilias.apalodimas@linaro.org, jgg@ziepe.ca,
	linux-efi@vger.kernel.org,  linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, liuzixing@hygon.cn
Subject: Re: [PATCH V3] efi/tpm: Fix the issue where the CC platforms event log header can't be correctly identified
Date: Fri, 11 Jul 2025 05:32:00 -0700	[thread overview]
Message-ID: <bed58d57f3d2aa2a5a3c1498d24d109be5717612.camel@HansenPartnership.com> (raw)
In-Reply-To: <ec847802-5189-461a-a372-f81839938579@126.com>

On Fri, 2025-07-11 at 09:23 +0800, Ge Yang wrote:
> 在 2025/7/11 5:58, James Bottomley 写道:
[...]
> > I think someone has misread the spec.  EV_NO_ACTION events produce
> > no PCR extension.  So the PCR value zero is conventional (and
> > required by the TCG) since nothing gets logged.  Therefore even if
> > you're technically using PCR0 for something else EV_NO_ACTION
> > events should still have the conventional PCR = 0 value to conform
> > to the TCG spec. I assume it's too late to correct this in the
> > implementation?
> > 
> 
> According to Table 14 in Section 10.4.1 of the TCG PC Client 
> Specification, for EV_NO_ACTION events, the PCR (Platform
> Configuration Register) value can be 0 or other values, such as 6.
> 
> Link: 
> https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClient_PFP_r1p05_v23_pub.pdf

You're selectively quoting one part of the spec out of context. 
Section 10.4.5 (which is the normative one about EV_NO_ACTION events)
says:

   1. All EV_NO_ACTION events SHALL set TCG_PCR_EVENT2.pcrIndex = 0,
   unless otherwise specified.

And the only update to this is in 10.4.5.4 where it says a vendor
specific EV_NO_ACTION event may set pcrIndex to 6.  Since the log
header is not vendor specific, it must have pcr = 0.

Regards,

James




      reply	other threads:[~2025-07-11 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07  3:14 yangge1116
2025-07-08  1:19 ` Ard Biesheuvel
2025-07-08  7:39   ` Ge Yang
2025-07-10 21:58 ` James Bottomley
2025-07-11  1:23   ` Ge Yang
2025-07-11 12:32     ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bed58d57f3d2aa2a5a3c1498d24d109be5717612.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=ardb@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuzixing@hygon.cn \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=yangge1116@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®