From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com,
wens@csie.org, mcuos.com@gmail.com, linux@roeck-us.net,
linux@armlinux.org.uk, lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10 v3] Input: twl4030-pwrbutton: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 16:25:15 +0530 [thread overview]
Message-ID: <bed6484b6919f26e7119934a33b6f9b1e94de3c9.1510999334.git.arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <a9a25cd5775ba4c76d47e8b66934e470f58d9e72.1510999558.git.arvind.yadav.cs@gmail.com>
In-Reply-To: <76d6a73ba51e1a8a86d8d9a1d0bbbf7723d5153a.1510999334.git.arvind.yadav.cs@gmail.com>
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
return irq instead of -ENODEV.
changes in v3 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
drivers/input/misc/twl4030-pwrbutton.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index b307cca..0dcf311 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -58,6 +58,9 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
int irq = platform_get_irq(pdev, 0);
int err;
+ if (irq <= 0)
+ return irq;
+
pwr = devm_input_allocate_device(&pdev->dev);
if (!pwr) {
dev_err(&pdev->dev, "Can't allocate power button\n");
--
2.7.4
next prev parent reply other threads:[~2017-11-18 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 10:55 [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav
2017-11-18 10:55 ` [PATCH 02/10 v3] Input: omap4-keypad: " Arvind Yadav
2017-11-18 10:55 ` [PATCH 03/10 v3] Input: twl4030_keypad: " Arvind Yadav
2017-11-18 10:55 ` [PATCH 04/10 v3] Input: serio: " Arvind Yadav
2017-11-18 10:55 ` [PATCH 05/10 v3] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Arvind Yadav
[not found] ` <76d6a73ba51e1a8a86d8d9a1d0bbbf7723d5153a.1510999334.git.arvind.yadav.cs@gmail.com>
2017-11-18 10:55 ` [PATCH 06/10 v2] Input: w90p910_ts: " Arvind Yadav
2017-11-18 10:55 ` Arvind Yadav [this message]
2017-11-18 10:55 ` [PATCH 09/10 v2] Input: sirfsoc-onkey: " Arvind Yadav
2017-11-18 10:55 ` [PATCH 10/10 v2] Input: palmas-pwrbutton: " Arvind Yadav
2017-11-18 10:55 ` [PATCH 07/10 v3] Input: sun4i-ts: " Arvind Yadav
2017-11-18 18:30 ` [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking Dmitry Torokhov
2017-11-20 16:24 ` arvindY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bed6484b6919f26e7119934a33b6f9b1e94de3c9.1510999334.git.arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=mcuos.com@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®