mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Yunlei He <heyunlei@huawei.com>,
	Sheng Yong <shengyong1@huawei.com>,
	<linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] f2fs: rework fault injection handling to avoid a warning
Date: Tue, 14 Aug 2018 14:05:52 +0800	[thread overview]
Message-ID: <bee2baa8-1768-4e80-9f63-baf52d6359b9@huawei.com> (raw)
In-Reply-To: <20180813213909.3125189-1-arnd@arndb.de>

On 2018/8/14 5:38, Arnd Bergmann wrote:
> When CONFIG_F2FS_FAULT_INJECTION is disabled, we get a warning about an
> unused label:
> 
> fs/f2fs/segment.c: In function '__submit_discard_cmd':
> fs/f2fs/segment.c:1059:1: error: label 'submit' defined but not used [-Werror=unused-label]
> 
> This could be fixed by adding another #ifdef around it, but the more
> reliable way of doing this seems to be to remove the other #ifdefs
> where that is easily possible.
> 
> By defining time_to_inject() as a trivial stub, most of the checks for
> CONFIG_F2FS_FAULT_INJECTION can go away. This also leads to nicer
> formatting of the code.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


      reply	other threads:[~2018-08-14  6:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 21:38 Arnd Bergmann
2018-08-14  6:05 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bee2baa8-1768-4e80-9f63-baf52d6359b9@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=arnd@arndb.de \
    --cc=heyunlei@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shengyong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®