From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751042AbdCQGvb (ORCPT ); Fri, 17 Mar 2017 02:51:31 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3899 "EHLO dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750877AbdCQGva (ORCPT ); Fri, 17 Mar 2017 02:51:30 -0400 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix stale ATOMIC_WRITTEN_PAGE private pointer To: Jaegeuk Kim , , , References: <20170317020906.28165-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Fri, 17 Mar 2017 14:51:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170317020906.28165-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58CB8769.02A4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b9a43d38d8ed8b1c521b03e4dafc1c61 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/3/17 10:09, Jaegeuk Kim wrote: > When I forced to enable atomic operations intentionally, I could hit the below > panic, since we didn't clear page->private in f2fs_invalidate_page called by > file truncation. > > The panic occurs due to NULL mapping having page->private. > > BUG: unable to handle kernel paging request at ffffffffffffffff > IP: drop_buffers+0x38/0xe0 > PGD 5d00c067 > PUD 5d00e067 > PMD 0 > CPU: 3 PID: 1648 Comm: fsstress Tainted: G D OE 4.10.0+ #5 > Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 > task: ffff9151952863c0 task.stack: ffffaaec40db4000 > RIP: 0010:drop_buffers+0x38/0xe0 > RSP: 0018:ffffaaec40db74c8 EFLAGS: 00010292 > Call Trace: > ? page_referenced+0x8b/0x170 > try_to_free_buffers+0xc5/0xe0 > try_to_release_page+0x49/0x50 > shrink_page_list+0x8bc/0x9f0 > shrink_inactive_list+0x1dd/0x500 > ? shrink_active_list+0x2c0/0x430 > shrink_node_memcg+0x5eb/0x7c0 > shrink_node+0xe1/0x320 > do_try_to_free_pages+0xef/0x2e0 > try_to_free_pages+0xe9/0x190 > __alloc_pages_slowpath+0x390/0xe70 > __alloc_pages_nodemask+0x291/0x2b0 > alloc_pages_current+0x95/0x140 > __page_cache_alloc+0xc4/0xe0 > pagecache_get_page+0xab/0x2a0 > grab_cache_page_write_begin+0x20/0x40 > get_read_data_page+0x2e6/0x4c0 [f2fs] > ? f2fs_mark_inode_dirty_sync+0x16/0x30 [f2fs] > ? truncate_data_blocks_range+0x238/0x2b0 [f2fs] > get_lock_data_page+0x30/0x190 [f2fs] > __exchange_data_block+0xaaf/0xf40 [f2fs] > f2fs_fallocate+0x418/0xd00 [f2fs] > vfs_fallocate+0x157/0x220 > SyS_fallocate+0x48/0x80 > > Signed-off-by: Yunlei He > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu