From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D27C32772 for ; Tue, 23 Aug 2022 13:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241724AbiHWNhK (ORCPT ); Tue, 23 Aug 2022 09:37:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239673AbiHWNgx (ORCPT ); Tue, 23 Aug 2022 09:36:53 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B186A1DE8DD for ; Tue, 23 Aug 2022 03:37:51 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id e21so12605268edc.7 for ; Tue, 23 Aug 2022 03:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=1E0cCe5cEaQJfe86WNnJmjkEbqjIELBXQL3k/KZdD48=; b=QSA3yhWCG+SVJuohL5IMAtHe2qODfXcRxnbjC0pXCGrCLc01hGLKlYJjItBNEgYh4P 2oqodZ1jRtDXD5Oc3bAfumtqxB5IQ6YdRiiPRZ7OrrnwI3Pu4U3mMOjhhgnvx877F1ch jtf1HReSx9JOob/Orgo1zPyhaK2lJsT7nxaXQsiraZ8a68CQwQp1q4W8+7L3CTN6YwC9 f8XJY2cEoQvDXtcfWF/QPBl1q54iQfuUwh4R3Gb7chQMxLr07oGYnUKawwkyE/qfQQIZ I640N+no44vjt4uJ172x7uqbiH+3N1d2WMGNnw+9A4G9Drc3v+qgsFLUOQuUs4rUYPET b7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=1E0cCe5cEaQJfe86WNnJmjkEbqjIELBXQL3k/KZdD48=; b=wzcY59WYzcLfVyYgC4xxlx2AMYg1qCM2nd8kyyckOBEvzFfEtJ3vJsYB6s8ZUd949v qfldz4MoxC5kDR7QeQIYD8xoYtLTorSIkLE8mGMAsQ3+MC4/qYuNUozQzMEWQS2oJnCI jC1tMzxff1U0VY0QhJETrjtw1GX6Yq89Miky1UCuz1qNf1+nHdQnAhYbRg+9zp1dmARh 46qR7Ya1zkPAIzC3zW3NX1m7lgim3fJwqZ/NefKH12dE3Zs4U1tSxQBXGa3rnnV+lJu4 v6oWOEnxmMtxYm/UU0JKtRh/fObnkp/ka+Asm41yAHc7ivvdOsT6YYkUCiLLuIDjcEhM QEBg== X-Gm-Message-State: ACgBeo2VK4Q3pHF4XOF2+GnICQsDr2mlEXfE2b3q7MuiTAdpbG5yL5iv 1W5yTLxIPDOdtgfikKxuuj5iAY/HFwRifp4U X-Google-Smtp-Source: AA6agR6el3uDAHqHIosEoBa7BJJVdeCX9cSrpx/F0nnzHgPz/5FfAVCMOm6iQIFk/R8G13WzCYBggA== X-Received: by 2002:a05:6512:3e25:b0:492:db16:4636 with SMTP id i37-20020a0565123e2500b00492db164636mr4317221lfv.657.1661250271586; Tue, 23 Aug 2022 03:24:31 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id o3-20020ac24e83000000b00492d7a7b4e3sm1655294lfr.4.2022.08.23.03.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 03:24:31 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 13:24:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis Content-Language: en-US To: Chunfeng Yun , Vinod Koul , Rob Herring Cc: Kishon Vijay Abraham I , Krzysztof Kozlowski , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Eddie Hung References: <20220819091344.2274-1-chunfeng.yun@mediatek.com> <20220819091344.2274-2-chunfeng.yun@mediatek.com> <438da392-f419-ad76-7e91-aa4aab36e12c@linaro.org> <816ecf6287533137b750c8bde9de5830e4229c56.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <816ecf6287533137b750c8bde9de5830e4229c56.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2022 10:07, Chunfeng Yun wrote: > On Fri, 2022-08-19 at 15:15 +0300, Krzysztof Kozlowski wrote: >> On 19/08/2022 12:13, Chunfeng Yun wrote: >>> Add a property to set usb2 phy's pre-emphasis. >>> >>> Signed-off-by: Chunfeng Yun >>> --- >>> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 7 >>> +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> index 848edfb1f677..aee2f3027371 100644 >>> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> @@ -219,6 +219,13 @@ patternProperties: >>> minimum: 1 >>> maximum: 15 >>> >>> + mediatek,pre-emphasis: >>> + description: >>> + The selection of pre-emphasis (U2 phy) >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + minimum: 1 >>> + maximum: 3 >> >> Instead of hard-coding register values in bindings, you should rather >> describe here feature/effect. If it is in units, use unit suffixes. >> If >> it is some choice, usually string enum is appropriate. > How about changing description as bellow: > > "The level of pre-emphasis, increases one level, boosts the relative > amplitudes of signal's higher frequencies components about 4.16% (U2 > phy)" > Still the question is what is the unit. 4.16%? Best regards, Krzysztof