From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBA21331EA3 for ; Wed, 7 Oct 2026 01:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791336737; cv=none; b=he/r7xsN0tE3FKZGfQIXZwoMV/edev5re8GqbEpLUgelmtFrjfujGCUQd/IHU4UpeCJzYHKUbAYK9uHvPD56OsSo+HNqGh7VApouz2vz9WyaYZz1gaaOWfwI9xhtLQQ6kkZA30yNNkbMX5iZjKDOXUkruxDYhWHvZA7npiQ53Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791336737; c=relaxed/simple; bh=lqtmMOq9NyJHWkCTixF/EfRvdzo9ti4x7BRbdW0dvpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rImPWfneo6Uz0rtMMReDO1wIDssNnkUsbBIVn70xV4K09ZabKiZnAEvRy/6IRKSJYooNrv7SZ7b8YlSEeVaFWCumiJ0CF5d/wRa8nWcoQqjx1lls3TtQIk6ynxpUxZT8TxW+MNpyKbdZVGVXKu5MRo7T/cGQM47PUjoKUOhSyLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FVCasvP9; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FVCasvP9" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4a16c1608faso15399065e9.0 for ; Tue, 06 Oct 2026 18:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791336734; x=1791941534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BooWm7URUcyrH2E2qkRWxlx7KQoz7GWFpr53v56Fl9k=; b=FVCasvP9FCP4taYfm6Pp/cJbtg0TdDpMFZR+V35uZjUu/heOUawDO/hCI3FrJy7fam NxnrzLwPmxlSjWwfVN7YOjGfFSMrRKOl8sd8FuEPSoc0dGOX6DWbyA2D9GZ+kaM6Tq3R WsQfYp8wfZsByC0cIN3TQTcLMXHett9eoe//LvN/EODYGz9a2a2utouHWA4BsIAGkpJw ERZME37rRAn9urM61FVbZJxXusNQ3ywvEOQMMMUQoXpyYT72VEea5HK6808szxd0JFVb ChYZ7fQERoUoIQQuMFUtmMkMNsxJ1pU3mICfe02ZgQEtL9OFGjxIduJizyWOuXpmSA3t v/NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791336734; x=1791941534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BooWm7URUcyrH2E2qkRWxlx7KQoz7GWFpr53v56Fl9k=; b=xxjxlD9FGO/YMcgtI9zM11a8pq8RmUvEA/jn1hypWS55L8g+51wLEZ2GLAQaHpaOw7 sX9GsP8bq+ZM4IGTEqYOgKJND8WoWVp/T7pJ1ecmBvEO0oRzkqUfmIy6XkGyGrVsPehH CvhWSQxd8AKt3ZdZ2eG02KBlYnd7jedRDdwqiixV5LHjD6y1+mj9wOKVZHhKENx5QsO/ yj9OjGtqg1LP3DZRcJyknnoYtfpNGOv2zbBzTe68fKKcqLBJsDy5408tfrK0E6jbfndP EOX9o+CoQGmyyl3nDGcWppQPvr5aPvxRtrSxSpC6A9UGZn+1BagbKxz8icTPj3JQjVlN gtqw== X-Forwarded-Encrypted: i=1; AKwUvBwoJ6YhJRh08hq6kHClj5/rbmil0FpRQnyLcSr2pIo9SVFZGTUBxgfaVGnueIJxWH/T1uHIaSZ3gt6HN2M=@vger.kernel.org X-Gm-Message-State: AFuF++l05Sd4TiY0+UpKZXEUodf6zAB1rXrLfiYpnLAU17XBJbGagJRz Quf0rDrofrl2JoaL9aALu7APNGmGo9UTjwV1UEpTWkt7h5ZjxrAObfTD X-Gm-Gg: AYBFou04DZU9gkY9A64VjLJ/7yqG8ZOIBLkxO7ZURKc/m/lpHL0sjXVuPmalgEZSqTQ UgWmI8AmlJQjcxG4srXvHFhjOZXVKfu6z/ud3Oh/tRlq8JewIMESkB1Lum5Dn3W3dLFlqiQ6HGD 9gc7kwTzMbhSpcDx5U9YQS1vcpOySUEhc+MlvMuAQQWwz86uKRf37GPwsharrbRaPWK8nRHSofA LFuPGD9hLuaMTGA2s3IlNvnWY3McD8iC5anuLPN2bMG4/7JhoI59W02+sju0hM4SCc4aOrFlIZO 8dXaIlxRkuZboNs9sUER12YigwDfp8ZfCCSoawEsH+GlEzC6dfRMCsMwvIomqa9J4A5dpwmtedd rjbaCDzcgKWRcV71IgFnGybGHbmHbi35+coqRqzMSAgu8xlqFWHUEBViU0NgGjIvNNTgCl612br qFTvu3GA+nw9YL5zwpsiWWrg+DXSqkc2CFtXdnesYMp3MJUxzSMD2FYqHyjpyLnGX/9PuY46qZE ahNc7vWoPHd3Fmn8rjfw/cawWY0uBW0ZoGmFA65gbyRk++7KY5UjtBoyBaYSZmpVCmmB/9ebjwV ldIMbylxwBw= X-Received: by 2002:a05:600c:810c:b0:49f:c5aa:9ef4 with SMTP id 5b1f17b1804b1-4a180422b6fmr8623225e9.8.1791336734141; Tue, 06 Oct 2026 18:32:14 -0700 (PDT) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a17f6538b7sm21183615e9.13.2026.10.06.18.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 18:32:13 -0700 (PDT) From: Pavel Begunkov To: linux-block@vger.kernel.org Cc: asml.silence@gmail.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Christoph Hellwig , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Jens Axboe , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Matthew Brost , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev Subject: [PATCH v8 01/13] block: always adjust bi_offset on bio_advance_iter Date: Wed, 7 Oct 2026 02:31:44 +0100 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend bio_no_advance_iter() iteration to also increment the offset. It's not currently needed because the currently listed request types don't have a buffer, but will be useful once we add bios backed by dma-buf, which don't have a bvec but work with a single range. Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Pavel Begunkov --- drivers/md/dm-io-rewind.c | 6 ++++-- include/linux/bio.h | 12 ++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-io-rewind.c b/drivers/md/dm-io-rewind.c index 04f3fc8aeb6f..b22719c6411c 100644 --- a/drivers/md/dm-io-rewind.c +++ b/drivers/md/dm-io-rewind.c @@ -113,10 +113,12 @@ static inline void dm_bio_rewind_iter(const struct bio *bio, iter->bi_sector -= bytes >> 9; /* No advance means no rewind */ - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size += bytes; - else + iter->bi_offset -= bytes; + } else { dm_bvec_iter_rewind(bio->bi_io_vec, iter, bytes); + } } /** diff --git a/include/linux/bio.h b/include/linux/bio.h index 17944e44b584..892ca469c570 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -113,11 +113,13 @@ static inline void bio_advance_iter(const struct bio *bio, { iter->bi_sector += bytes >> 9; - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size -= bytes; - else + iter->bi_offset += bytes; + } else { bvec_iter_advance(bio->bi_io_vec, iter, bytes); /* TODO: It is reasonable to complete bio with error here. */ + } } /* @bytes should be less or equal to bvec[i->bi_idx].bv_len */ @@ -127,10 +129,12 @@ static inline void bio_advance_iter_single(const struct bio *bio, { iter->bi_sector += bytes >> 9; - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size -= bytes; - else + iter->bi_offset += bytes; + } else { bvec_iter_advance_single(bio->bi_io_vec, iter, bytes); + } } void __bio_advance(struct bio *, unsigned bytes); -- 2.54.0