From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768E7342523 for ; Wed, 7 Oct 2026 01:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791337397; cv=none; b=RFS2AqNLsA8/OynhxA0lRu33UA+MR9zABUe52QqM6LvbmaGTNlUXwCgRqkG80K5T3U48JYbPW71BNhyOQELw6pNOeI2F3XUqScdeISMa/xK2FMrjdbqUe5BU4PD0YdnIcUHRGb27bEDZlKGKOADtcK/Vbs9QvxzLrcfRLTQHJek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791337397; c=relaxed/simple; bh=lqtmMOq9NyJHWkCTixF/EfRvdzo9ti4x7BRbdW0dvpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I8+/XDqfSDBT7Eidk6WppTxtpQLco60Zhk/za0VLijQBuGrxBhdXaEr4UDxhF2UdIAdukWLhoBabYQsilhXakQ1FQv5Z2h5+CJqmrRBxPDF1SH4ISJB88fpQ/t2BlXn7npDCUoelUL8ECzKGPdz/cieVGgaLwzdobIUNnY112ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dESaBPDV; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dESaBPDV" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4a0286c981dso31600715e9.2 for ; Tue, 06 Oct 2026 18:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791337394; x=1791942194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BooWm7URUcyrH2E2qkRWxlx7KQoz7GWFpr53v56Fl9k=; b=dESaBPDV4Ukztvcg7uEN5PPES+i8YXb+SSrNwbql8zn7D/45P7ttuJqb9mBz0cyu+E 185hKAXEd5/80OFdd6MR5jJ08p/W2Jkrc87tbfboKIPwXHSiJOOZ6gtcjWrTW9KBkO2K 2bLc6Nklp4jWRt4C3VI4gQLGV894Fhlj7XD58WhIVgGt0OyT8zeKZiRCWI9YBBblHOuK kz/ZULF2lxsyXYrNJKqlPD2r4SE3Vz7JlfgfuhUO8nR8JZB8jGXTZ/NHa2eGHFloFehz vNTOWWIt12286QIdUgJjF8AZAembvLE+8W60bRiu1T74MTutEiNMRV+OR8EeTcB1BPVS faLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791337394; x=1791942194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BooWm7URUcyrH2E2qkRWxlx7KQoz7GWFpr53v56Fl9k=; b=dqiN9+nIb7d8BJwUywdt8i4kqQTp6axqzCX/yu+WiQZe6sUVe5bs4loGposOJ9cMxj IWpAHfqoBt1s//vH+JfM4hEcfv9Sa+tR5TFrAoL2hCh9CGOIPAGlgJ7uFHswTCTzxOs/ iqGkpgrDSto/oh1uTkzp8Fk64Y0qegXRV/GM1mM92hrZRVY9xCvYagIEFITV/ZIr7wzn zRLifuWtpLcp1M5vknZJfB7CykxxQNviExslT2vSGiW8elS16SrHLeFiDGRcfqrwzhZg PsPRs9ldbvqUZCivf1WoR1X2zpod/BDi0WxJL2SVzdjG5I62moFOO+DAFppBP74P+JNg /KdA== X-Forwarded-Encrypted: i=1; AKwUvBz0T8O+kGUJ2K30F2QvN7abkilrix7lv1I1bYpiNOGGucTeo0ALoPj7if9gX4W8IDHaBxk6tVUPP8Pmr3U=@vger.kernel.org X-Gm-Message-State: AFuF++lcCfJA+c7Kg5ZsKJBzH7Zn/oHJQyxHAIXRRtcx+tOyQERqlQ6n ADy4zXtagH2YmdGN9nSbDSNUTIdLh/wX2wsLLxwrfJ5xy6C5nzCqTU1W X-Gm-Gg: AYBFou0g5VMVpjsc8rid/Zn2G6fD2gU83Fad7A4uxyAD6TeAryd052x2CLS4f8/TZHR 44PzwioN7a4kQdWbI//MCXgfxtEVtbKZ/4CsS7qUIcZIKmxEX/qZFh2q8uZD7v2CrO2MDcgaoNi HrVpIjAuJevz1GFZHcpTelB0i+ZjHfeoJ4gu9JJ8g51N7DYtedsH+xAoA/dlvZZvtQ2IkqljQ4M mzgt/uz1xexxea7d2BB2zRBFiMLBmkumlgJVG8CMYq9I+d6J0Qi1VJEwkxJD7794kMEYid4+3zn yZX+rSzuJLdIdkEEDTuijs1uLbjlBBe0UCfON3ByqnIQ3Wj842+FWG8zI8mfqvl+4Xbk638la3Q +C9rx2zoN3//C/Vx9SEEPnGxkXAifSeAo9lnKr2RloyZOXHl0hXG26yg8hH14rd1eLCJKnjjEqr spCrxkzhuUjuSRMaSvIAFQqiugA8uORKVU8Bd+mjpn2tKVn52DDwxxRzXeGI0NlO36p20OGpQOS 5VGGgGqNVjZNQJUR6E2YdA+MJ4edaVxOIS9QL9+xdN91058GIs0BYaKbiZwSAeqoJyEadScgejW w81NvJ4L/3E= X-Received: by 2002:a05:600c:6097:b0:4a0:1f90:594b with SMTP id 5b1f17b1804b1-4a18064cf5bmr6446075e9.22.1791337393761; Tue, 06 Oct 2026 18:43:13 -0700 (PDT) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a17f653d7csm26423895e9.14.2026.10.06.18.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 18:43:13 -0700 (PDT) From: Pavel Begunkov To: linux-block@vger.kernel.org Cc: asml.silence@gmail.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Christoph Hellwig , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Jens Axboe , Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Matthew Brost , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev Subject: [PATCH v9 03/13] block: always adjust bi_offset on bio_advance_iter Date: Wed, 7 Oct 2026 02:42:46 +0100 Message-ID: X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend bio_no_advance_iter() iteration to also increment the offset. It's not currently needed because the currently listed request types don't have a buffer, but will be useful once we add bios backed by dma-buf, which don't have a bvec but work with a single range. Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Pavel Begunkov --- drivers/md/dm-io-rewind.c | 6 ++++-- include/linux/bio.h | 12 ++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/md/dm-io-rewind.c b/drivers/md/dm-io-rewind.c index 04f3fc8aeb6f..b22719c6411c 100644 --- a/drivers/md/dm-io-rewind.c +++ b/drivers/md/dm-io-rewind.c @@ -113,10 +113,12 @@ static inline void dm_bio_rewind_iter(const struct bio *bio, iter->bi_sector -= bytes >> 9; /* No advance means no rewind */ - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size += bytes; - else + iter->bi_offset -= bytes; + } else { dm_bvec_iter_rewind(bio->bi_io_vec, iter, bytes); + } } /** diff --git a/include/linux/bio.h b/include/linux/bio.h index 17944e44b584..892ca469c570 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -113,11 +113,13 @@ static inline void bio_advance_iter(const struct bio *bio, { iter->bi_sector += bytes >> 9; - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size -= bytes; - else + iter->bi_offset += bytes; + } else { bvec_iter_advance(bio->bi_io_vec, iter, bytes); /* TODO: It is reasonable to complete bio with error here. */ + } } /* @bytes should be less or equal to bvec[i->bi_idx].bv_len */ @@ -127,10 +129,12 @@ static inline void bio_advance_iter_single(const struct bio *bio, { iter->bi_sector += bytes >> 9; - if (bio_no_advance_iter(bio)) + if (bio_no_advance_iter(bio)) { iter->bi_size -= bytes; - else + iter->bi_offset += bytes; + } else { bvec_iter_advance_single(bio->bi_io_vec, iter, bytes); + } } void __bio_advance(struct bio *, unsigned bytes); -- 2.54.0