Re: [PATCH v3 3/4] firmware: stratix10-svc: Add initial support for asynchronous communication with Stratix10 service channel

[Mahesh Rao <mahesh.rao@altera.com>]

Hi Krzysztof,

On 28-05-2025 05:20 pm, Krzysztof Kozlowski wrote:
> On 28/05/2025 12:29, Mahesh Rao wrote:
>>> ...
>>>
>>>> +	args.a0 = INTEL_SIP_SMC_ASYNC_POLL;
>>>> +	args.a1 =
>>>> +		STRATIX10_SIP_SMC_SET_TRANSACTIONID_X1(handle->transaction_id);
>>>> +
>>>> +	actrl->invoke_fn(actrl, &args, &handle->res);
>>>> +
>>>> +	data->status = 0;
>>>> +	if (handle->res.a0 == INTEL_SIP_SMC_STATUS_OK) {
>>>> +		return 0;
>>>> +	} else if (handle->res.a0 == INTEL_SIP_SMC_STATUS_BUSY) {
>>>> +		dev_dbg(ctrl->dev, "async message is still in progress\n");
>>>> +		return -EAGAIN;
>>>> +	}
>>>> +
>>>> +	dev_err(ctrl->dev,
>>>> +		"Failed to poll async message ,got status as %ld\n",
>>>> +		handle->res.a0);
>>>> +	return -EINVAL;
>>>> +}
>>>> +EXPORT_SYMBOL_GPL(stratix10_svc_async_poll);
>>>
>>> No, drop entire function. There is no user of it. You cannot add exports
>>> for dead code.
>>
>> These functions have been newly introduced for the Stratix10-SVC
>> platform driver. The client drivers that will utilize these APIs are
>> currently under development and are planned for inclusion in a
>> subsequent patch set. Would you prefer that I include a sample client
>> driver using these APIs in this patch set instead?
> 
> You must have user for every exported symbol. In the same patchset, usually.
> 

Ok, I will add a client usage to this patch set.

> 
> Best regards,
> Krzysztof

Thanks
Mahesh