From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4376D1624D5; Thu, 29 Jan 2026 13:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769694124; cv=none; b=aMqULUezQsxYOHicGLp+GEWuI2iJItYpIL3YkUgOTu42UWisxrW+SJ6g1/MEOACnpLhYmE0IywXjACL1/GhjdIhQucoJQ0sz9tJYPeHgzrpTd4W0lZDYgbFpxXDfPZG7++WPOuAic5nH2FN3iLCr5Uen3zEa23B59GDa8tIFmwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769694124; c=relaxed/simple; bh=Ja4fhzRsEUnTSdfgsrA2ZKz1L5CqfZ8Taw0DdGp2Jco=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=o1hawtJHzGP6HZHRD7MzagFFDSxnTcgj2UYCPAp0ii3mvc89MZDyfXHI4a6XIn5qC0hhMW+qa4RwKHiD3JZB0wjyNcHIuyuSlBIsrxRBsQJsmuBlaL+EKs3k+svsMLsFmOlLRcw8YWgR6/0GrivIk9JPGmODD/AONo6zd6cDDFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SnsHlwBW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SnsHlwBW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8B76C116D0; Thu, 29 Jan 2026 13:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769694123; bh=Ja4fhzRsEUnTSdfgsrA2ZKz1L5CqfZ8Taw0DdGp2Jco=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SnsHlwBWbh2/I4i/zvdthmuOpWz0VHYwTzQcI74CXwXzVlh2wuKf7ilx/amHj5AYC PU6tC1qO4Kvr3Ffni1DVdkpnUtj+MypilXsKQF7MPLMoKGg2UDBih6doBNjWxw0BcS +O4ClWirBk88rHEp4UG+unsxeL2eXBjt2bMRZNwj3r3G9nuCyPOYkGXfAeZ6pVatNn S93qYCLSBJxmJAcdQJ0MQbbxd52SGzDNLwBkJMXcdOXoZHRfBJ1vkOJqlu+V/58uLf kpx88V9uV7Ammn5O/G4hZmEyX1gtzcS3nU0AO2uvZ26Y3IkqfvI4YC/NV92y7OmScC dh/Pn/ygwGhJg== Message-ID: Subject: Re: [PATCH v3 1/4] open: new O_REGULAR flag support From: Jeff Layton To: Christian Brauner Cc: Dorjoy Chowdhury , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, chuck.lever@oracle.com, alex.aring@gmail.com, arnd@arndb.de, adilger@dilger.ca, smfrench@gmail.com Date: Thu, 29 Jan 2026 08:42:00 -0500 In-Reply-To: <90421b8d47484be162644e3b612daaf271bc7855.camel@kernel.org> References: <20260127180109.66691-1-dorjoychy111@gmail.com> <20260127180109.66691-2-dorjoychy111@gmail.com> <1c6cccc3e058ef16fa8b296ef6126b76a12db136.camel@kernel.org> <20260129-tierwelt-wahlabend-2cb470bcb707@brauner> <90421b8d47484be162644e3b612daaf271bc7855.camel@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-01-29 at 08:12 -0500, Jeff Layton wrote: > On Thu, 2026-01-29 at 13:33 +0100, Christian Brauner wrote: > > On Wed, Jan 28, 2026 at 10:51:07AM -0500, Jeff Layton wrote: > > > On Wed, 2026-01-28 at 21:36 +0600, Dorjoy Chowdhury wrote: > > > > On Wed, Jan 28, 2026 at 5:52=E2=80=AFAM Jeff Layton wrote: > > > > >=20 > > > > > On Tue, 2026-01-27 at 23:58 +0600, Dorjoy Chowdhury wrote: > > > > > > This flag indicates the path should be opened if it's a regular= file. > > > > > > This is useful to write secure programs that want to avoid bein= g tricked > > > > > > into opening device nodes with special semantics while thinking= they > > > > > > operate on regular files. > > > > > >=20 > > > > > > A corresponding error code ENOTREG has been introduced. For exa= mple, if > > > > > > open is called on path /dev/null with O_REGULAR in the flag par= am, it > > > > > > will return -ENOTREG. > > > > > >=20 > > > > > > When used in combination with O_CREAT, either the regular file = is > > > > > > created, or if the path already exists, it is opened if it's a = regular > > > > > > file. Otherwise, -ENOTREG is returned. > > > > > >=20 > > > > > > -EINVAL is returned when O_REGULAR is combined with O_DIRECTORY= (not > > > > > > part of O_TMPFILE) because it doesn't make sense to open a path= that > > > > > > is both a directory and a regular file. > > > > > >=20 > > > > > > Signed-off-by: Dorjoy Chowdhury > > > > > > --- > > > > > > arch/alpha/include/uapi/asm/errno.h | 2 ++ > > > > > > arch/alpha/include/uapi/asm/fcntl.h | 1 + > > > > > > arch/mips/include/uapi/asm/errno.h | 2 ++ > > > > > > arch/parisc/include/uapi/asm/errno.h | 2 ++ > > > > > > arch/parisc/include/uapi/asm/fcntl.h | 1 + > > > > > > arch/sparc/include/uapi/asm/errno.h | 2 ++ > > > > > > arch/sparc/include/uapi/asm/fcntl.h | 1 + > > > > > > fs/fcntl.c | 2 +- > > > > > > fs/namei.c | 6 ++++++ > > > > > > fs/open.c | 4 +++- > > > > > > include/linux/fcntl.h | 2 +- > > > > > > include/uapi/asm-generic/errno.h | 2 ++ > > > > > > include/uapi/asm-generic/fcntl.h | 4 ++++ > > > > > > tools/arch/alpha/include/uapi/asm/errno.h | 2 ++ > > > > > > tools/arch/mips/include/uapi/asm/errno.h | 2 ++ > > > > > > tools/arch/parisc/include/uapi/asm/errno.h | 2 ++ > > > > > > tools/arch/sparc/include/uapi/asm/errno.h | 2 ++ > > > > > > tools/include/uapi/asm-generic/errno.h | 2 ++ > > > > > > 18 files changed, 38 insertions(+), 3 deletions(-) > > > > > >=20 > > > > > > diff --git a/arch/alpha/include/uapi/asm/errno.h b/arch/alpha/i= nclude/uapi/asm/errno.h > > > > > > index 6791f6508632..8bbcaa9024f9 100644 > > > > > > --- a/arch/alpha/include/uapi/asm/errno.h > > > > > > +++ b/arch/alpha/include/uapi/asm/errno.h > > > > > > @@ -127,4 +127,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 139 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 140 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/arch/alpha/include/uapi/asm/fcntl.h b/arch/alpha/i= nclude/uapi/asm/fcntl.h > > > > > > index 50bdc8e8a271..4da5a64c23bd 100644 > > > > > > --- a/arch/alpha/include/uapi/asm/fcntl.h > > > > > > +++ b/arch/alpha/include/uapi/asm/fcntl.h > > > > > > @@ -34,6 +34,7 @@ > > > > > >=20 > > > > > > #define O_PATH 040000000 > > > > > > #define __O_TMPFILE 0100000000 > > > > > > +#define O_REGULAR 0200000000 > > > > > >=20 > > > > > > #define F_GETLK 7 > > > > > > #define F_SETLK 8 > > > > > > diff --git a/arch/mips/include/uapi/asm/errno.h b/arch/mips/inc= lude/uapi/asm/errno.h > > > > > > index c01ed91b1ef4..293c78777254 100644 > > > > > > --- a/arch/mips/include/uapi/asm/errno.h > > > > > > +++ b/arch/mips/include/uapi/asm/errno.h > > > > > > @@ -126,6 +126,8 @@ > > > > > >=20 > > > > > > #define EHWPOISON 168 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 169 /* Not a regular file */ > > > > > > + > > > > > > #define EDQUOT 1133 /* Quota exceeded */ > > > > > >=20 > > > > > >=20 > > > > > > diff --git a/arch/parisc/include/uapi/asm/errno.h b/arch/parisc= /include/uapi/asm/errno.h > > > > > > index 8cbc07c1903e..442917484f99 100644 > > > > > > --- a/arch/parisc/include/uapi/asm/errno.h > > > > > > +++ b/arch/parisc/include/uapi/asm/errno.h > > > > > > @@ -124,4 +124,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 257 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 258 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/arch/parisc/include/uapi/asm/fcntl.h b/arch/parisc= /include/uapi/asm/fcntl.h > > > > > > index 03dee816cb13..0cc3320fe326 100644 > > > > > > --- a/arch/parisc/include/uapi/asm/fcntl.h > > > > > > +++ b/arch/parisc/include/uapi/asm/fcntl.h > > > > > > @@ -19,6 +19,7 @@ > > > > > >=20 > > > > > > #define O_PATH 020000000 > > > > > > #define __O_TMPFILE 040000000 > > > > > > +#define O_REGULAR 0100000000 > > > > > >=20 > > > > > > #define F_GETLK64 8 > > > > > > #define F_SETLK64 9 > > > > > > diff --git a/arch/sparc/include/uapi/asm/errno.h b/arch/sparc/i= nclude/uapi/asm/errno.h > > > > > > index 4a41e7835fd5..8dce0bfeab74 100644 > > > > > > --- a/arch/sparc/include/uapi/asm/errno.h > > > > > > +++ b/arch/sparc/include/uapi/asm/errno.h > > > > > > @@ -117,4 +117,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 135 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 136 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/arch/sparc/include/uapi/asm/fcntl.h b/arch/sparc/i= nclude/uapi/asm/fcntl.h > > > > > > index 67dae75e5274..a93d18d2c23e 100644 > > > > > > --- a/arch/sparc/include/uapi/asm/fcntl.h > > > > > > +++ b/arch/sparc/include/uapi/asm/fcntl.h > > > > > > @@ -37,6 +37,7 @@ > > > > > >=20 > > > > > > #define O_PATH 0x1000000 > > > > > > #define __O_TMPFILE 0x2000000 > > > > > > +#define O_REGULAR 0x4000000 > > > > > >=20 > > > > > > #define F_GETOWN 5 /* for sockets. */ > > > > > > #define F_SETOWN 6 /* for sockets. */ > > > > > > diff --git a/fs/fcntl.c b/fs/fcntl.c > > > > > > index f93dbca08435..62ab4ad2b6f5 100644 > > > > > > --- a/fs/fcntl.c > > > > > > +++ b/fs/fcntl.c > > > > > > @@ -1169,7 +1169,7 @@ static int __init fcntl_init(void) > > > > > > * Exceptions: O_NONBLOCK is a two bit define on parisc; = O_NDELAY > > > > > > * is defined as O_NONBLOCK on some platforms and not on = others. > > > > > > */ > > > > > > - BUILD_BUG_ON(20 - 1 /* for O_RDONLY being 0 */ !=3D > > > > > > + BUILD_BUG_ON(21 - 1 /* for O_RDONLY being 0 */ !=3D > > > > > > HWEIGHT32( > > > > > > (VALID_OPEN_FLAGS & ~(O_NONBLOCK | O_NDEL= AY)) | > > > > > > __FMODE_EXEC)); > > > > > > diff --git a/fs/namei.c b/fs/namei.c > > > > > > index b28ecb699f32..f5504ae4b03c 100644 > > > > > > --- a/fs/namei.c > > > > > > +++ b/fs/namei.c > > > > > > @@ -4616,6 +4616,10 @@ static int do_open(struct nameidata *nd, > > > > > > if (unlikely(error)) > > > > > > return error; > > > > > > } > > > > > > + > > > > > > + if ((open_flag & O_REGULAR) && !d_is_reg(nd->path.dentry)= ) > > > > > > + return -ENOTREG; > > > > > > + > > > > > > if ((nd->flags & LOOKUP_DIRECTORY) && !d_can_lookup(nd->p= ath.dentry)) > > > > > > return -ENOTDIR; > > > > > >=20 > > > > > > @@ -4765,6 +4769,8 @@ static int do_o_path(struct nameidata *nd= , unsigned flags, struct file *file) > > > > > > struct path path; > > > > > > int error =3D path_lookupat(nd, flags, &path); > > > > > > if (!error) { > > > > > > + if ((file->f_flags & O_REGULAR) && !d_is_reg(path= .dentry)) > > > > > > + return -ENOTREG; > > > > > > audit_inode(nd->name, path.dentry, 0); > > > > > > error =3D vfs_open(&path, file); > > > > > > path_put(&path); > > > > > > diff --git a/fs/open.c b/fs/open.c > > > > > > index 74c4c1462b3e..82153e21907e 100644 > > > > > > --- a/fs/open.c > > > > > > +++ b/fs/open.c > > > > > > @@ -1173,7 +1173,7 @@ struct file *kernel_file_open(const struc= t path *path, int flags, > > > > > > EXPORT_SYMBOL_GPL(kernel_file_open); > > > > > >=20 > > > > > > #define WILL_CREATE(flags) (flags & (O_CREAT | __O_TMPFILE)) > > > > > > -#define O_PATH_FLAGS (O_DIRECTORY | O_NOFOLLOW | O_PAT= H | O_CLOEXEC) > > > > > > +#define O_PATH_FLAGS (O_DIRECTORY | O_NOFOLLOW | O_PAT= H | O_CLOEXEC | O_REGULAR) > > > > > >=20 > > > > > > inline struct open_how build_open_how(int flags, umode_t mode) > > > > > > { > > > > > > @@ -1250,6 +1250,8 @@ inline int build_open_flags(const struct = open_how *how, struct open_flags *op) > > > > > > return -EINVAL; > > > > > > if (!(acc_mode & MAY_WRITE)) > > > > > > return -EINVAL; > > > > > > + } else if ((flags & O_DIRECTORY) && (flags & O_REGULAR)) = { > > > > > > + return -EINVAL; > > > > > > } > > > > > > if (flags & O_PATH) { > > > > > > /* O_PATH only permits certain other flags to be = set. */ > > > > > > diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h > > > > > > index a332e79b3207..4fd07b0e0a17 100644 > > > > > > --- a/include/linux/fcntl.h > > > > > > +++ b/include/linux/fcntl.h > > > > > > @@ -10,7 +10,7 @@ > > > > > > (O_RDONLY | O_WRONLY | O_RDWR | O_CREAT | O_EXCL | O_NOCT= TY | O_TRUNC | \ > > > > > > O_APPEND | O_NDELAY | O_NONBLOCK | __O_SYNC | O_DSYNC | = \ > > > > > > FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLL= OW | \ > > > > > > - O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE) > > > > > > + O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE | O_REGULAR= ) > > > > > >=20 > > > > > > /* List of all valid flags for the how->resolve argument: */ > > > > > > #define VALID_RESOLVE_FLAGS \ > > > > > > diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/as= m-generic/errno.h > > > > > > index 92e7ae493ee3..2216ab9aa32e 100644 > > > > > > --- a/include/uapi/asm-generic/errno.h > > > > > > +++ b/include/uapi/asm-generic/errno.h > > > > > > @@ -122,4 +122,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 133 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 134 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/include/uapi/asm-generic/fcntl.h b/include/uapi/as= m-generic/fcntl.h > > > > > > index 613475285643..3468b352a575 100644 > > > > > > --- a/include/uapi/asm-generic/fcntl.h > > > > > > +++ b/include/uapi/asm-generic/fcntl.h > > > > > > @@ -88,6 +88,10 @@ > > > > > > #define __O_TMPFILE 020000000 > > > > > > #endif > > > > > >=20 > > > > > > +#ifndef O_REGULAR > > > > > > +#define O_REGULAR 040000000 > > > > > > +#endif > > > > > > + > > > > > > /* a horrid kludge trying to make sure that this will fail on = old kernels */ > > > > > > #define O_TMPFILE (__O_TMPFILE | O_DIRECTORY) > > > > > >=20 > > > > > > diff --git a/tools/arch/alpha/include/uapi/asm/errno.h b/tools/= arch/alpha/include/uapi/asm/errno.h > > > > > > index 6791f6508632..8bbcaa9024f9 100644 > > > > > > --- a/tools/arch/alpha/include/uapi/asm/errno.h > > > > > > +++ b/tools/arch/alpha/include/uapi/asm/errno.h > > > > > > @@ -127,4 +127,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 139 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 140 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/tools/arch/mips/include/uapi/asm/errno.h b/tools/a= rch/mips/include/uapi/asm/errno.h > > > > > > index c01ed91b1ef4..293c78777254 100644 > > > > > > --- a/tools/arch/mips/include/uapi/asm/errno.h > > > > > > +++ b/tools/arch/mips/include/uapi/asm/errno.h > > > > > > @@ -126,6 +126,8 @@ > > > > > >=20 > > > > > > #define EHWPOISON 168 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 169 /* Not a regular file */ > > > > > > + > > > > > > #define EDQUOT 1133 /* Quota exceeded */ > > > > > >=20 > > > > > >=20 > > > > > > diff --git a/tools/arch/parisc/include/uapi/asm/errno.h b/tools= /arch/parisc/include/uapi/asm/errno.h > > > > > > index 8cbc07c1903e..442917484f99 100644 > > > > > > --- a/tools/arch/parisc/include/uapi/asm/errno.h > > > > > > +++ b/tools/arch/parisc/include/uapi/asm/errno.h > > > > > > @@ -124,4 +124,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 257 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 258 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/tools/arch/sparc/include/uapi/asm/errno.h b/tools/= arch/sparc/include/uapi/asm/errno.h > > > > > > index 4a41e7835fd5..8dce0bfeab74 100644 > > > > > > --- a/tools/arch/sparc/include/uapi/asm/errno.h > > > > > > +++ b/tools/arch/sparc/include/uapi/asm/errno.h > > > > > > @@ -117,4 +117,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 135 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 136 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > > > diff --git a/tools/include/uapi/asm-generic/errno.h b/tools/inc= lude/uapi/asm-generic/errno.h > > > > > > index 92e7ae493ee3..2216ab9aa32e 100644 > > > > > > --- a/tools/include/uapi/asm-generic/errno.h > > > > > > +++ b/tools/include/uapi/asm-generic/errno.h > > > > > > @@ -122,4 +122,6 @@ > > > > > >=20 > > > > > > #define EHWPOISON 133 /* Memory page has hardware error= */ > > > > > >=20 > > > > > > +#define ENOTREG 134 /* Not a regular file */ > > > > > > + > > > > > > #endif > > > > >=20 > > > > > One thing this patch is missing is handling for ->atomic_open(). = I > > > > > imagine most of the filesystems that provide that op can't suppor= t > > > > > O_REGULAR properly (maybe cifs can? idk). What you probably want = to do > > > > > is add in some patches that make all of the atomic_open operation= s in > > > > > the kernel return -EINVAL if O_REGULAR is set. > > > > >=20 > > > > > Then, once the basic support is in, you or someone else can go ba= ck and > > > > > implement support for O_REGULAR where possible. > > > >=20 > > > > Thank you for the feedback. I don't quite understand what I need to > > > > fix. I thought open system calls always create regular files, so > > > > atomic_open probably always creates regular files? Can you please g= ive > > > > me some more details as to where I need to fix this and what the > > > > actual bug here is that is related to atomic_open? I think I had d= one > > > > some normal testing and when using O_CREAT | O_REGULAR, if the file > > > > doesn't exist, the file gets created and the file that gets created= is > > > > a regular file, so it probably makes sense? Or should the behavior = be > > > > that if file doesn't exist, -EINVAL is returned and if file exists = it > > > > is opened if regular, otherwise -ENOTREG is returned? > > > >=20 > > >=20 > > > atomic_open() is a combination lookup+open for when the dentry isn't > > > present in the dcache. The normal open codepath that you're patching > > > does not get called in this case when ->atomic_open is set for the > > > filesystem. It's mostly used by network filesystems that need to > > > optimize away the lookup since it's wasted round trip, and is often > > > racy anyway. Your patchset doesn't address those filesystems. They wi= ll > > > likely end up ignoring O_REGULAR in that case, which is not what you > > > want. > > >=20 > > > What I was suggesting is that, as an interim step, you find all of th= e > > > atomic_open operations in the kernel (there are maybe a dozen or so), > > > and just make them return -EINVAL if someone sets O_DIRECTORY. Later, > > > you or someone else can then go back and do a proper implementation o= f > > > O_REGULAR handling on those filesystems, at least on the ones where > > > it's possible. You will probably also need to similarly patch the > > > open() routines for those filesystems too. Otherwise you'll get > > > inconsistent behavior vs. when the dentry is in the cache. > > >=20 > > > One note: I think NFS probably can support O_DIRECTORY, since its OPE= N > > > call only works on files. We'll need to change how we handle errors > > > from the server when it's set though. > >=20 > > So I think you're proposing two separate things or there's a typo: > >=20 > > (1) blocking O_DIRECTORY for ->atomic_open:: > > (2) blocking O_REGULAR for ->atomic_open:: > >=20 > > The (1) point implies that O_DIRECTORY currently doesn't work correctly > > with atomic open for all filesystems. > >=20 > > Ever since 43b450632676 ("open: return EINVAL for O_DIRECTORY | > > O_CREAT") O_DIRECTORY with O_CREAT is blocked. It was accidently allowe= d > > and completely broken before that. > >=20 > > For O_DIRECTORY without O_CREAT the kernel will pass that down through > > ->atomic_open:: to the filesystem. > >=20 > > The worry that I see is that a network filesystem via ->atomic_open:: > > somehow already called open on the server side on something that wasn't > > a directory. At that point the damage such as side-effects from device > > opening is already done. > > =C2=A0 > >=20 >=20 > Exactly. I guess you could send an immediate close, but that's not > without side effects. >=20 > > =20 > > But I suspect that every filesystem implementing ->atomic_open:: just > > does finish_no_open() and punts to the VFS for the actual open. And the > > VFS will catch it in do_open() for it actually opens the file. So the > > only real worry for O_DIRECTORY I see is that there's an fs that handle= s > > it wrong. > >=20 > > For (2) it is problematic as there surely are filesystems with > > ->atomic_open:: that do handle the ~O_CREAT case and return with > > FMODE_OPENED. So that'll be problematic if the intention is to not > > trigger an actual open on a non-regular file such as a > > device/socket/fifo etc. before the VFS had a chance to validate what's > > going on. > >=20 > > So I'm not excited about having this 70% working and punting on > > ->atomic_open:: waiting for someone to fix this. One option would be to > > bypass ->atomic_open:: for OPENAT2_REGULAR without O_CREAT and fallback > > to racy and pricy lookup + open for now. How problematic would that be? > > If possible I'd prefer this a lot over merging something that works > > half-way. > >=20 > > I guess to make that really work you'd need some protocol extension? >=20 > For NFS, I think we're OK. The OPEN call on NFSv4 only works for > regular files, so it should be able to handle O_REGULAR. We just need > to rejigger the error handling when it's set (just return an error > instead of doing the open of a directory or whatever it is). >=20 > The others (at a quick glance): >=20 > cifs: I don't see a way to specify an O_REGULAR equivalent to the > SMB2_CREATE call and it looks like it can create directories. Maybe > SteveF (cc'ed) knows if this is possible? >=20 SMB2 does have this flag: FILE_NON_DIRECTORY_FILE 0x00000040 If the name of the file being created or opened matches with an existing directory file, the server MUST fail the request with STATUS_FILE_IS_A_DIRECTORY. This flag MUST NOT be used with FILE_DIRECTORY_FILE or the server MUST fail the request with STATUS_INVALID_PARAMETER. SMB2 can also present named pipes and printer files. Not sure if there is a way to exclude those with this. > ceph: I think CEPH_MDS_OP_OPEN might only work for files, in which case > O_REGULAR can probably be supported similarly to NFS. >=20 Actually I'm wrong here. That op can open a directory. We'll need someone to look at the MDS code and tell us whether this can be done in a non-racy way. > fuse: probably ok? Does finish_no_open() in most cases. May depend on > the userland driver though. >=20 > gfs2: is ok, it just does finish_no_open() in most cases anyway >=20 > vboxsf: does finish_no_open on non-creates, so you could probably just > punt to that if O_REGULAR is set. >=20 > So, it's probably possible to do this across the board. I'm not sure > about cifs though. --=20 Jeff Layton