From: Paolo Abeni <pabeni@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Wang Ming <machel@vivo.com>,
opensource.kernel@vivo.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
David Daney <david.daney@cavium.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Sunil Goutham <sgoutham@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Minjie Du <duminjie@vivo.com>
Subject: Re: [PATCH net v3] net: thunder: bgx: Fix resource leaks in device_for_each_child_node() loops
Date: Tue, 18 Jul 2023 10:51:58 +0200 [thread overview]
Message-ID: <befe05762b714948ad1f71a5d038334100f84cd0.camel@redhat.com> (raw)
In-Reply-To: <be87c113-f975-9607-1f9d-5db304e0b1b9@web.de>
On Fri, 2023-07-14 at 15:06 +0200, Markus Elfring wrote:
> > The device_for_each_child_node() loop in bgx_init_of_phy()
> > function should have fwnode_handle_put() before break which could
> > avoid resource leaks. This patch could fix this bug.
>
> Are imperative change descriptions still preferred?
Yes. The commit message should be re-phrased.
More importantly, it looks like the relevant reference is already
released by of_node_put() and the additional fwnode_handle_put() will
cause a reference underflow.
This patch does not look correct to me.
Cheers,
Paolo
prev parent reply other threads:[~2023-07-18 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 9:59 Wang Ming
[not found] ` <be87c113-f975-9607-1f9d-5db304e0b1b9@web.de>
2023-07-18 8:51 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=befe05762b714948ad1f71a5d038334100f84cd0.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=duminjie@vivo.com \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®