From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
<quic_vgarodia@quicinc.com>, <bryan.odonoghue@linaro.org>,
<krzk+dt@kernel.org>, <konradybcio@kernel.org>,
<dmitry.baryshkov@oss.qualcomm.com>, <mchehab@kernel.org>,
<robh@kernel.org>, <andersson@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 4/8] media: venus: hfi_plat_v4: Add capabilities for the 4XX lite core
Date: Mon, 11 Aug 2025 15:35:41 +0530 [thread overview]
Message-ID: <beff5494-17b6-2fe8-1a5c-6a9a820204bb@quicinc.com> (raw)
In-Reply-To: <20250808085300.1403570-5-jorge.ramirez@oss.qualcomm.com>
On 8/8/2025 2:22 PM, Jorge Ramirez-Ortiz wrote:
> Populate the HFI v4 lite capability set used by the AR50_LITE video
> core.
>
> These capabilities define the supported codec formats and operational
> limits specific to this streamlined VPU variant.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../platform/qcom/venus/hfi_platform_v4.c | 167 ++++++++++++++++--
> 1 file changed, 151 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_platform_v4.c b/drivers/media/platform/qcom/venus/hfi_platform_v4.c
> index 41e4dc28ec1b..cda888b56b5d 100644
> --- a/drivers/media/platform/qcom/venus/hfi_platform_v4.c
> +++ b/drivers/media/platform/qcom/venus/hfi_platform_v4.c
> @@ -246,28 +246,150 @@ static const struct hfi_plat_caps caps[] = {
> .num_fmts = 4,
> } };
>
> +static const struct hfi_plat_caps caps_lite[] = {
> +{
> + .codec = HFI_VIDEO_CODEC_H264,
> + .domain = VIDC_SESSION_TYPE_DEC,
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 1920, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 1920, 1},
> + .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 8160, 1},
> + .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 60000000, 1 },
> + .caps[4] = {HFI_CAPABILITY_MBS_PER_SECOND, 64, 244800, 1},
> + .caps[5] = {HFI_CAPABILITY_FRAMERATE, 1, 120, 1},
> + .caps[6] = {HFI_CAPABILITY_MAX_VIDEOCORES, 0, 1, 1},
> + .num_caps = 7,
> + .pl[0] = { HFI_H264_PROFILE_BASELINE, HFI_H264_LEVEL_5},
> + .pl[1] = {HFI_H264_PROFILE_MAIN, HFI_H264_LEVEL_5},
> + .pl[2] = {HFI_H264_PROFILE_HIGH, HFI_H264_LEVEL_5},
> + .pl[3] = {HFI_H264_PROFILE_CONSTRAINED_BASE, HFI_H264_LEVEL_5},
> + .pl[4] = {HFI_H264_PROFILE_CONSTRAINED_HIGH, HFI_H264_LEVEL_5},
> + .num_pl = 5,
> + .fmts[0] = {HFI_BUFFER_OUTPUT, HFI_COLOR_FORMAT_NV12_UBWC},
> + .fmts[1] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV12_UBWC},
> + .fmts[2] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV12},
> + .fmts[3] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV21},
> + .num_fmts = 4,
> +}, {
> + .codec = HFI_VIDEO_CODEC_HEVC,
> + .domain = VIDC_SESSION_TYPE_DEC,
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 1920, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 1920, 1},
> + .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 8160, 1},
> + .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 60000000, 1 },
> + .caps[4] = {HFI_CAPABILITY_MBS_PER_SECOND, 64, 244800, 1},
> + .caps[5] = {HFI_CAPABILITY_FRAMERATE, 1, 120, 1},
> + .caps[6] = {HFI_CAPABILITY_MAX_VIDEOCORES, 0, 1, 1},
> + .num_caps = 7,
> + .pl[0] = {HFI_HEVC_PROFILE_MAIN, HFI_HEVC_LEVEL_5 | HFI_HEVC_TIER_HIGH0 << 28 },
> + .pl[1] = {HFI_HEVC_PROFILE_MAIN10, HFI_HEVC_LEVEL_5 | HFI_HEVC_TIER_HIGH0 << 28 },
> + .num_pl = 2,
> + .fmts[0] = {HFI_BUFFER_OUTPUT, HFI_COLOR_FORMAT_NV12_UBWC},
> + .fmts[1] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV12_UBWC},
> + .fmts[2] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV12},
> + .fmts[3] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV21},
> + .num_fmts = 4,
> +}, {
> + .codec = HFI_VIDEO_CODEC_VP9,
> + .domain = VIDC_SESSION_TYPE_DEC,
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 1920, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 1920, 1},
> + .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 8160, 1},
> + .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 60000000, 1 },
> + .caps[4] = {HFI_CAPABILITY_MBS_PER_SECOND, 64, 244800, 1},
> + .caps[5] = {HFI_CAPABILITY_FRAMERATE, 1, 120, 1},
> + .caps[6] = {HFI_CAPABILITY_MAX_VIDEOCORES, 0, 1, 1},
> + .num_caps = 7,
> + .pl[0] = {HFI_VP9_PROFILE_P0, 200},
> + .pl[1] = {HFI_VP9_PROFILE_P2_10B, 200},
> + .num_pl = 2,
> + .fmts[0] = {HFI_BUFFER_OUTPUT, HFI_COLOR_FORMAT_NV12_UBWC},
> + .fmts[1] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV12_UBWC},
> + .fmts[2] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV12},
> + .fmts[3] = {HFI_BUFFER_OUTPUT2, HFI_COLOR_FORMAT_NV21},
> + .num_fmts = 4,
> +}, {
> + .codec = HFI_VIDEO_CODEC_H264,
> + .domain = VIDC_SESSION_TYPE_ENC,
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 1920, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 1920, 1},
> + .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 8160, 1},
> + .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 60000000, 1 },
> + .caps[4] = {HFI_CAPABILITY_MBS_PER_SECOND, 64, 244800, 1},
> + .caps[5] = {HFI_CAPABILITY_FRAMERATE, 1, 120, 1},
> + .caps[6] = {HFI_CAPABILITY_MAX_VIDEOCORES, 0, 1, 1},
> + .caps[7] = {HFI_CAPABILITY_HIER_P_NUM_ENH_LAYERS, 0, 6, 1},
> + .caps[8] = {HFI_CAPABILITY_ENC_LTR_COUNT, 0, 4, 1},
> + .caps[9] = {HFI_CAPABILITY_MBS_PER_SECOND_POWERSAVE, 0, 244800, 1},
> + .caps[10] = {HFI_CAPABILITY_I_FRAME_QP, 0, 51, 1},
> + .caps[11] = {HFI_CAPABILITY_P_FRAME_QP, 0, 51, 1},
> + .caps[12] = {HFI_CAPABILITY_B_FRAME_QP, 0, 51, 1},
> + .caps[13] = {HFI_CAPABILITY_SLICE_BYTE, 1, 10, 1},
> + .caps[14] = {HFI_CAPABILITY_SLICE_MB, 1, 10, 1},
> + .num_caps = 15,
> + .pl[0] = {HFI_H264_PROFILE_BASELINE, HFI_H264_LEVEL_5},
> + .pl[1] = {HFI_H264_PROFILE_MAIN, HFI_H264_LEVEL_5},
> + .pl[2] = {HFI_H264_PROFILE_HIGH, HFI_H264_LEVEL_5},
> + .pl[3] = {HFI_H264_PROFILE_CONSTRAINED_BASE, HFI_H264_LEVEL_5},
> + .pl[4] = {HFI_H264_PROFILE_CONSTRAINED_HIGH, HFI_H264_LEVEL_5},
> + .num_pl = 5,
> + .fmts[0] = {HFI_BUFFER_INPUT, HFI_COLOR_FORMAT_NV12},
> + .fmts[1] = {HFI_BUFFER_INPUT, HFI_COLOR_FORMAT_NV12_UBWC},
> + .num_fmts = 2,
> +}, {
> + .codec = HFI_VIDEO_CODEC_HEVC,
> + .domain = VIDC_SESSION_TYPE_ENC,
> + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 128, 1920, 1},
> + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 128, 1920, 1},
> + .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 64, 8160, 1},
> + .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 60000000, 1 },
> + .caps[4] = {HFI_CAPABILITY_MBS_PER_SECOND, 64, 244800, 1},
> + .caps[5] = {HFI_CAPABILITY_FRAMERATE, 1, 120, 1},
> + .caps[6] = {HFI_CAPABILITY_MAX_VIDEOCORES, 0, 1, 1},
> + .caps[7] = {HFI_CAPABILITY_HIER_P_NUM_ENH_LAYERS, 0, 6, 1},
> + .caps[8] = {HFI_CAPABILITY_ENC_LTR_COUNT, 0, 4, 1},
> + .caps[9] = {HFI_CAPABILITY_MBS_PER_SECOND_POWERSAVE, 0, 244800, 1},
> + .caps[10] = {HFI_CAPABILITY_I_FRAME_QP, 0, 51, 1},
> + .caps[11] = {HFI_CAPABILITY_P_FRAME_QP, 0, 51, 1},
> + .caps[12] = {HFI_CAPABILITY_B_FRAME_QP, 0, 51, 1},
> + .caps[13] = {HFI_CAPABILITY_SLICE_BYTE, 1, 10, 1},
> + .caps[14] = {HFI_CAPABILITY_SLICE_MB, 1, 10, 1},
> + .num_caps = 15,
> + .pl[0] = {HFI_HEVC_PROFILE_MAIN, HFI_HEVC_LEVEL_5 | HFI_HEVC_TIER_HIGH0},
> + .pl[1] = {HFI_HEVC_PROFILE_MAIN10, HFI_HEVC_LEVEL_5 | HFI_HEVC_TIER_HIGH0},
> + .num_pl = 2,
> + .fmts[0] = {HFI_BUFFER_INPUT, HFI_COLOR_FORMAT_NV12},
> + .fmts[1] = {HFI_BUFFER_INPUT, HFI_COLOR_FORMAT_NV12_UBWC},
> + .num_fmts = 2,
> +} };
> +
> static const struct hfi_plat_caps *get_capabilities(struct venus_core *core,
> unsigned int *entries)
> {
> - if (is_lite(core))
> - return NULL;
> + *entries = is_lite(core) ? ARRAY_SIZE(caps_lite) : ARRAY_SIZE(caps);
>
> - *entries = ARRAY_SIZE(caps);
> - return caps;
> + return is_lite(core) ? caps_lite : caps;
> }
>
> static void get_codecs(struct venus_core *core,
> u32 *enc_codecs, u32 *dec_codecs, u32 *count)
> {
> - if (is_lite(core))
> - return;
> + const struct hfi_plat_caps *caps;
> + unsigned int num;
> + size_t i;
> +
> + *enc_codecs = 0;
> + *dec_codecs = 0;
> +
> + caps = get_capabilities(core, &num);
>
> - *enc_codecs = HFI_VIDEO_CODEC_H264 | HFI_VIDEO_CODEC_HEVC |
> - HFI_VIDEO_CODEC_VP8;
> - *dec_codecs = HFI_VIDEO_CODEC_H264 | HFI_VIDEO_CODEC_HEVC |
> - HFI_VIDEO_CODEC_VP8 | HFI_VIDEO_CODEC_VP9 |
> - HFI_VIDEO_CODEC_MPEG2;
> - *count = 8;
> + for (i = 0; i < num; caps++, i++) {
> + if (caps->domain == VIDC_SESSION_TYPE_ENC)
> + *enc_codecs |= caps->codec;
> + else
> + *dec_codecs |= caps->codec;
> + }
> +
> + *count = num;
> }
>
> static const struct hfi_platform_codec_freq_data codec_freq_data[] = {
> @@ -281,15 +403,28 @@ static const struct hfi_platform_codec_freq_data codec_freq_data[] = {
> { V4L2_PIX_FMT_VP9, VIDC_SESSION_TYPE_DEC, 200, 10, 200 },
> };
>
> +static const struct hfi_platform_codec_freq_data codec_freq_data_lite[] = {
> + { V4L2_PIX_FMT_H264, VIDC_SESSION_TYPE_DEC, 440, 0, 440 },
> + { V4L2_PIX_FMT_HEVC, VIDC_SESSION_TYPE_DEC, 440, 0, 440 },
> + { V4L2_PIX_FMT_VP9, VIDC_SESSION_TYPE_DEC, 440, 0, 440 },
> + { V4L2_PIX_FMT_H264, VIDC_SESSION_TYPE_ENC, 675, 0, 675 },
> + { V4L2_PIX_FMT_HEVC, VIDC_SESSION_TYPE_ENC, 675, 0, 675 },
> +};
> +
> static const struct hfi_platform_codec_freq_data *
> get_codec_freq_data(struct venus_core *core, u32 session_type, u32 pixfmt)
> {
> - const struct hfi_platform_codec_freq_data *data = codec_freq_data;
> - unsigned int i, data_size = ARRAY_SIZE(codec_freq_data);
> + const struct hfi_platform_codec_freq_data *data;
> + unsigned int i, data_size;
> const struct hfi_platform_codec_freq_data *found = NULL;
>
> - if (is_lite(core))
> - return NULL;
> + if (is_lite(core)) {
> + data = codec_freq_data_lite;
> + data_size = ARRAY_SIZE(codec_freq_data_lite);
> + } else {
> + data = codec_freq_data;
> + data_size = ARRAY_SIZE(codec_freq_data);
> + }
>
> for (i = 0; i < data_size; i++) {
> if (data[i].pixfmt == pixfmt && data[i].session_type == session_type) {
Reviewed-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
next prev parent reply other threads:[~2025-08-11 10:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 8:52 [PATCH v9 0/8] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-08-08 8:52 ` [PATCH v9 1/8] media: dt-bindings: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-08-08 8:52 ` [PATCH v9 2/8] media: venus: Define minimum valid firmware version Jorge Ramirez-Ortiz
2025-08-08 9:01 ` Bryan O'Donoghue
2025-08-08 10:13 ` Dikshita Agarwal
2025-08-08 8:52 ` [PATCH v9 3/8] media: venus: Add framework support for AR50_LITE video core Jorge Ramirez-Ortiz
2025-08-08 9:10 ` Bryan O'Donoghue
2025-08-11 10:03 ` Dikshita Agarwal
2025-08-08 8:52 ` [PATCH v9 4/8] media: venus: hfi_plat_v4: Add capabilities for the 4XX lite core Jorge Ramirez-Ortiz
2025-08-11 10:05 ` Dikshita Agarwal [this message]
2025-08-08 8:52 ` [PATCH v9 5/8] media: venus: core: Sort dt_match alphabetically Jorge Ramirez-Ortiz
2025-08-08 9:11 ` Bryan O'Donoghue
2025-08-08 10:16 ` Dikshita Agarwal
2025-08-08 8:52 ` [PATCH v9 6/8] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-08-08 9:02 ` Bryan O'Donoghue
2025-08-08 10:15 ` Dikshita Agarwal
2025-08-08 8:52 ` [PATCH v9 7/8] arm64: dts: qcom: qcm2290: Add Venus video node Jorge Ramirez-Ortiz
2025-08-08 8:53 ` [PATCH v9 8/8] arm64: dts: qcom: qrb2210-rb1: Enable Venus Jorge Ramirez-Ortiz
2025-08-08 10:26 ` Dikshita Agarwal
2025-08-13 22:18 ` [PATCH v9 0/8] media: venus: Add QCM2290 support with AR50_LITE core Bryan O'Donoghue
2025-08-13 22:22 ` Jorge Ramirez
2025-08-13 22:42 ` Jorge Ramirez
-- strict thread matches above, loose matches on Subject: below --
2025-08-08 8:49 Jorge Ramirez-Ortiz
2025-08-08 8:49 ` [PATCH v9 4/8] media: venus: hfi_plat_v4: Add capabilities for the 4XX lite core Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beff5494-17b6-2fe8-1a5c-6a9a820204bb@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®