From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752386AbdGGFLq (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Jul 2017 01:11:46 -0400
Received: from mga01.intel.com ([192.55.52.88]:40532 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750844AbdGGFLp (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Fri, 7 Jul 2017 01:11:45 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,320,1496127600"; 
   d="scan'208";a="123658718"
Subject: Re: [PATCH] perf report: Fix broken arrow at row 0 in annotate view
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com,
        yao.jin@intel.com
References: <1496901704-30275-1-git-send-email-yao.jin@linux.intel.com>
From: "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <bf00e881-6189-4c6b-faef-87d32c6414c3@linux.intel.com>
Date: Fri, 7 Jul 2017 13:11:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1496901704-30275-1-git-send-email-yao.jin@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnaldo,

Could this patch be merged?

Otherwise the jump arrow is broken when it's displayed at the row 0 in 
annotate view.

Thanks

Jin Yao

On 6/8/2017 2:01 PM, Jin Yao wrote:
> When the jump instruction is displayed at the row 0 in annotate view,
> the arrow is broken. An example:
>
>   16.86 │   ┌──je     82
>    0.01 │      movsd  (%rsp),%xmm0
>         │      movsd  0x8(%rsp),%xmm4
>         │      movsd  0x8(%rsp),%xmm1
>         │      movsd  (%rsp),%xmm3
>         │      divsd  %xmm4,%xmm0
>         │      divsd  %xmm3,%xmm1
>         │      movsd  (%rsp),%xmm2
>         │      addsd  %xmm1,%xmm0
>         │      addsd  %xmm2,%xmm0
>         │      movsd  %xmm0,(%rsp)
>         │82:   sub    $0x1,%ebx
>   83.03 │    ↑ jne    38
>         │      add    $0x10,%rsp
>         │      xor    %eax,%eax
>         │      pop    %rbx
>         │    ← retq
>
> The patch increments the row number before checking with 0.
>
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> ---
>   tools/perf/ui/browser.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
> index a4d3762..83874b0 100644
> --- a/tools/perf/ui/browser.c
> +++ b/tools/perf/ui/browser.c
> @@ -704,7 +704,7 @@ static void __ui_browser__line_arrow_down(struct ui_browser *browser,
>   		ui_browser__gotorc(browser, row, column + 1);
>   		SLsmg_draw_hline(2);
>   
> -		if (row++ == 0)
> +		if (++row == 0)
>   			goto out;
>   	} else
>   		row = 0;