From: Martin KaFai Lau <martin.lau@linux.dev>
To: zhangmingyi <zhangmingyi5@huawei.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, yanan@huawei.com,
wuchangye@huawei.com, xiesongyang@huawei.com,
liuxin350@huawei.com, liwei883@huawei.com, tianmuyang@huawei.com
Subject: Re: [PATCH 1/2] ipv4, bpf: Introduced to support the ULP to get or set sockets
Date: Wed, 29 Jan 2025 13:20:27 -0800 [thread overview]
Message-ID: <bf0e9c67-b1c9-4e39-8af0-ff2bdc493359@linux.dev> (raw)
In-Reply-To: <20250127090724.3168791-2-zhangmingyi5@huawei.com>
On 1/27/25 1:07 AM, zhangmingyi wrote:
> Note that tcp_getsockopt and tcp_setsockopt support TCP_ULP, while
> bpf_getsockopt and bpf_setsockopt do not support TCP_ULP.
> I'm not sure why there is such a difference, but I noticed that
> tcp_setsockopt is called in bpf_setsockopt.I think we can add the
> handling of this case.
>
> Signed-off-by: zhangmingyi <zhangmingyi5@huawei.com>
A nit that I found it useful to recognize different authors of the mailing list.
It would be easier to have a formatted name. It seems "Mingyi Zhang" was used
earlier, as seen by searching the git log history.
next prev parent reply other threads:[~2025-01-29 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 9:07 [PATCH 0/2] " zhangmingyi
2025-01-27 9:07 ` [PATCH 1/2] " zhangmingyi
2025-01-29 21:20 ` Martin KaFai Lau [this message]
2025-01-27 9:07 ` [PATCH 2/2] add selftest for TCP_ULP in bpf_setsockopt zhangmingyi
2025-01-29 23:31 ` Martin KaFai Lau
2025-01-29 20:58 ` [PATCH 0/2] ipv4, bpf: Introduced to support the ULP to get or set sockets Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf0e9c67-b1c9-4e39-8af0-ff2bdc493359@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxin350@huawei.com \
--cc=liwei883@huawei.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tianmuyang@huawei.com \
--cc=wuchangye@huawei.com \
--cc=xiesongyang@huawei.com \
--cc=yanan@huawei.com \
--cc=yhs@fb.com \
--cc=zhangmingyi5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome