From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C3F328248 for ; Tue, 23 Dec 2025 09:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766483708; cv=none; b=KM455ufqx3YaR2y20RKeXhbq/Kqq/B4BZEg5JD6CL56uE56kThO7xCqpBlpFlPA4Sm0ZMsIIsbTrTG8UEKosKkk50WHGboEKdZKz8kFpmpVHYYNopC87iWMbVwceBYLok5PmM38CtgjoKfb+mO6Okzqfur6GvdemuY+7u19MOQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766483708; c=relaxed/simple; bh=j6tgXLyeMDtY81gzu+UAwTardCPOFsj4A05vaFcvi1E=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BJVxOZIMlg/jpkquSKoExsJ1zT/2Upgol7AhHBTMBZz4cFyGgz1AuxKseR8yVjzJ/fl5dDtBJRoK8gLhPfR32l1Ly/zWFoIawAS0+urVdUW1Gm/nnF1+uglerDInYVm4GPggnkJB5air2HohQgfzezwfXdROK4I83PzTxErI27M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fM/Gtwtv; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fM/Gtwtv" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42e2e628f8aso2031508f8f.1 for ; Tue, 23 Dec 2025 01:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766483704; x=1767088504; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=/YO5Uvts04jHxPH1E+Sg8oVaj5XxMMKC7fUH8OS5AS0=; b=fM/GtwtvqNJcMiXL0moeDxFN9c+/k3ZEg4dRjAep0jE/qMqUoVsWB8SmknulNwhGmN AYVMeRgKjalrwMvev7XkzKtrRDE/4BfB4Bq8vuRKK6SSxvVYOezueo2YFDe2uXV2uIAI RSBxFworWfHUw48oyNXXnsSIZH1FhsySf5LFesfr2PUYRUShoG4vnPMb2a91poss2Crd wZ3WN2g6eQ04XEi2LlN+nBsShkLSQVqwwRizilzY9UzcjqnI1PbODa6KY2LolM5lJmmr LQMu+C73ZietFLPnI0L+7Y27oPEc4eXqZjAgfR60tWKt4mYKrtNCOaKX6YDNazXL7IYI PdnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766483704; x=1767088504; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/YO5Uvts04jHxPH1E+Sg8oVaj5XxMMKC7fUH8OS5AS0=; b=f4ONl/aGfRDUPDxXB2UJY+YL+S96ecOIWxMLYk40/cH+9areURGdi1VGAyVKoYlpkV rh94wOEQQtCgrqxE70LJAQonglMGx76u9os1wzYypg9OkL5b4vEEipuzeMuO8+DsbjO0 o9CKhIAPGSlt1sKPERznvN9Hf6joG1F8tUrM9iTPo3jqDYmw+qXlLH6KircgXv3T7+f5 DbqGbHrrjyWRS9BwUibI3GSeEi7R3LYzUvCfjwgiJ19Q8WoeF+B9bng8nQd0AQeriasA NPZc1GvR1vWGFMzGaSzCbKVRhU6QorvxK3SnJjssdyygggmAPtUoglKVXuaV3RlXC0Ow K6kg== X-Forwarded-Encrypted: i=1; AJvYcCWvmr+GRETMjtWUGAH5leO8E3Z9WPiTNHoHBhygNnUrqKjtvHX2AFR+gDG6KkXBEGhbvPLeesocg+uCAxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxNu9sXNwVBuswBbUBMIp1YdUhPyWFxiVRrqLE6Rzz4JJZxj190 UxI497FJf0GlslWNQNEhqSWuYAIwjMDcaBVgbxQXfF7oM+aPo501SrVqIXp4YgwhSLw= X-Gm-Gg: AY/fxX4h9IOTWJw36KyGY/EV0iv2lPx2A0NomGVD5/wQDJTAva64yYLieaR2CKvf89G FuGzHw3f8OZge+codlF1A7R6uWGTJrjRipTrPac2T5M+aQ3tYfpq4AdSK8hc1XYXsqLnx6EjOkv wp9/EI8Wh14I5QAqyorKelmfPoEM+tC2APVw0tNFRozS9eAtqAg9PyaHez6DLEFCDrWjbwbQmUV BEgYoNQPIXkS3Zo2VEvbGaDjUCYri8OS7PeSN6d2+Pg5/536V/tAsIkJ2zDOwTBr/OWjlddHwA0 KnpVO+JexN2JYfLcBUXvpjHsRYRpQfPtDNWBApcJodfTeitNGNqNmPUJ3Kn485p+FDkIAIZ9uA2 mIVm1uQC2ikskf+gtBtEWhGecTeLiRkzsBF8XULK5j9xajkaHWuJXUz9S55/S2+CL7HQI7DOsyg gTQ3ML1DyPvBuJnofb X-Google-Smtp-Source: AGHT+IHn1GlPRf1Fniuh1RmFfsJ96HpQRvJXXzVmZFTdyuEV9fySR+khcoZkMgxQXIqdh1loSsJh8Q== X-Received: by 2002:a05:6000:25c1:b0:430:c76b:fadd with SMTP id ffacd0b85a97d-4324e4d3f7dmr14473947f8f.28.1766483704413; Tue, 23 Dec 2025 01:55:04 -0800 (PST) Received: from draszik.lan ([212.129.75.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830f3sm26479438f8f.22.2025.12.23.01.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 01:55:04 -0800 (PST) Message-ID: Subject: Re: [PATCH v4 2/5] soc: samsung: exynos-chipid: rename method From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Tudor Ambarus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 23 Dec 2025 09:55:15 +0000 In-Reply-To: <20251222-gs101-chipid-v4-2-aa8e20ce7bb3@linaro.org> References: <20251222-gs101-chipid-v4-0-aa8e20ce7bb3@linaro.org> <20251222-gs101-chipid-v4-2-aa8e20ce7bb3@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-12-22 at 16:30 +0000, Tudor Ambarus wrote: > s/product_id_to_soc_id/exynos_product_id_to_name. > Prepend exynos_ to avoid name space pollution. The method translates the > product id to a name, rename the method to make that clear. While > touching the code where it is called, add a blank line for readability > purposes. >=20 > Signed-off-by: Tudor Ambarus > --- > =C2=A0drivers/soc/samsung/exynos-chipid.c | 5 +++-- > =C2=A01 file changed, 3 insertions(+), 2 deletions(-) I'm not sure this change helps with anything, in particular as the return value is used to assign to soc_id, but in case it gets applied: Reviewed-by: Andr=C3=A9 Draszik >=20 > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/ex= ynos-chipid.c > index b9a30452ad21c326af35c06a341b28491cee6979..88d264ef1b8835e15f774ff5a= 31f5b3de20f74ea 100644 > --- a/drivers/soc/samsung/exynos-chipid.c > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -71,7 +71,7 @@ static const struct exynos_soc_id { > =C2=A0 { "EXYNOSAUTOV920", 0x0A920000 }, > =C2=A0}; > =C2=A0 > -static const char *product_id_to_soc_id(unsigned int product_id) > +static const char *exynos_product_id_to_name(unsigned int product_id) > =C2=A0{ > =C2=A0 int i; > =C2=A0 > @@ -150,7 +150,8 @@ static int exynos_chipid_probe(struct platform_device= *pdev) > =C2=A0 soc_info.revision); > =C2=A0 if (!soc_dev_attr->revision) > =C2=A0 return -ENOMEM; > - soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); > + > + soc_dev_attr->soc_id =3D exynos_product_id_to_name(soc_info.product_id)= ; > =C2=A0 if (!soc_dev_attr->soc_id) > =C2=A0 return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); > =C2=A0