From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFB903BE162 for ; Wed, 1 Apr 2026 10:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775039967; cv=none; b=kKSaffKF+TcFfmjy+Q6sE8zHiH93JOPwmXBBP67BAoYn4uH3bkS6UixvLDY6Tqrk83ppsJ1P5qtBp/Cq/buSQNNyVZ8dhxgfv6UVI/nzV9RMhvKWv/VF+A3apoXLCwIZDwl2jLcd7AViA7T2DmVmKYNszB9jyIv/JnD9kehU7u8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775039967; c=relaxed/simple; bh=nQ+4p8OsGuZw809xd8Eq9zhMz2sZzX8LN8rIvBt7GIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UKF0YJyKpdvISuA6GECVoYpp46IFXmeN0CT8U9YtaqmaV7M8heVH/GilYZG9P3UCFYD3fsKQgBBvZ+H3RmGQY87U35VtfgzSn7Xz0XiLWIpB3T0Gig2bWmHIea58RHhKvceS0jadrmUK0GSfKHQ0rNdaM25aiEcXvMx8WYECwrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FJ1HH3/K; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g58hX/hn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FJ1HH3/K"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g58hX/hn" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317YNpn1004301 for ; Wed, 1 Apr 2026 10:39:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CdEHA4DQK22SZOiThoLAaxq/9uTTHTJylEC9OtLnGBk=; b=FJ1HH3/K+4RqKsD9 ESnJE2pA0EsnBvibYt7HoDEATpOanA9KYtkTUKaSqzCy/9OsgpkLUsqfupbq9MhT GSENwweAbTm9GKqCsFwsRFtxbA+ZukIXFuZ6+8R19iHyK1SIqj9gk2qzXlrysD+w jDA2tCz2mCUM3rToBAaZ8t6eST9MoEk6B+S1vwXRHhjk32lkc7t0WP09aD8UpcWR ZaBVQvK0oZxWiML0yZ1eu7W3eRar+Dtmfy3JZvN9LHttshfqWwtuae7iE/qsBJhM qZrfKlv9vIPCUOheVHe6A/piDU9ted339dTaYxktXZwLlJ+0teRWQwpfxILYpeIv t+zHGQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8tfjhvre-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 10:39:25 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82442d02d11so1527298b3a.3 for ; Wed, 01 Apr 2026 03:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775039964; x=1775644764; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CdEHA4DQK22SZOiThoLAaxq/9uTTHTJylEC9OtLnGBk=; b=g58hX/hnG/1t6dCQPsbDEhpMfGHYcASUtiWSWZf1YucxLqvZLBfavIMaq08f3K1L7p GDwhE759yvj4LVjr3aj+uM9VLb5Dc74PLA+E11Y6Y3CHWfCGLmFpEfg6HrcTwsVt2iCc NNG3+7xGRchB7dloJ7l9RY/a/80AmDZpUAuLWqrukHB1bAhzwz3PV6NH9GlGiXO9xT69 888vjRjA2S/C5WXqZNOCucG3E/wOSkQI4Lj+82hmRpcNRvh2aqE0SsO/ysHL/VJQP7Lm mDHdryGo4I4k65XMvu2tcxteFahMWtxHW0vXFPoq9+iV7aboexpbF4tVbJanOQPGWq5T rmmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775039964; x=1775644764; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CdEHA4DQK22SZOiThoLAaxq/9uTTHTJylEC9OtLnGBk=; b=SEwX2qokXLU+uP+63KUExeqEjf8t5cEuPbvYr8X0Ha9MkMg3zbMEufQMENQPWOEZni hm49DCwTCEumdpDqMKhf/ZhiCa+pZSB/dcMfOc2+HLbNHWqJXCVpsgSzib9IZU8Lu7Tv gIGRMp+xxSBOp8BNc6/49G3Jy9fbcM0UBdTpdkr8ppRazG4TrobYC3c4OnJquFGiguEc w78ubhLMW4VdieoKqem6z4VfheIJe46HN65FUGe2mRuJI9pv/sCJgExg+wueSkX8mQdN EXvfew35xacmpVHzjOT5KySEBwGsa+waeFITFxCBnpBxyZCcpfRzb6U7TdaqfsOuPpwL sK9w== X-Forwarded-Encrypted: i=1; AJvYcCVC0Qp9TABlc3x+en8dSNWxf8Hw90W3wzipKb3kRBI0tVZsy/1sLYLgkX7pxM3ESPNvQc8YUmOVRYSK/QI=@vger.kernel.org X-Gm-Message-State: AOJu0YyrKBlZhF7qKhxlDq/h9mevSAi2+ni3UHx5PWQ6q0h1gtUL/ogj 2DOyd7e1Lv051yyBpo13fBDt7Yqb0GgHk6lQgxYBEw0cdmBcSntX+NgOlxtUSkQqLIfjXQ6slWj cZKZkCnZHArcw0QopDWwCato/RVuOrDs0t8t2sVdIb01HUCA0Ly+8ibuaI+Vy/0fKYEY= X-Gm-Gg: ATEYQzwB2TLI71jIT8seqbMz9K0hFr6ymi39ZJmjgqkQehMPQfeEEXTPNqbHs3yYe4y Hq28rEoEh0ew37j2PGU60bWrX9FC1MxxUsQHExvKZUZuYPJ4GG4lNuNIVHoN9yFZAlnmMgeUYoP xcXcyjoINbqZnqx+MifJ/IiCxvMWTAttL9DKkQcb9An2BbR81f6fG5v9MXGm6DMum/otoYQVfp9 MWIwbIyAsHilKJsMzBG471lav3t2eFgwGvL2vSJXLingH38fY/MX8HOO+cHuj6UEYKH5ETfvVgg fxkattkzscSUlI9iSSH9X7j6X0ubZFo31R/TJ6gqT7gtUvs4sloE7wh8q91O75hkufkY6RMReqM I7tuNTR5VuSVl6/34PiG0B7TSqh8OkTMEyp51oBO4yd+I1D313TB8fx0B76P/2B/8brW3vJ/eu6 qO/RZRi2VcST7z X-Received: by 2002:a05:6a21:7a86:b0:343:c095:c4d6 with SMTP id adf61e73a8af0-39ef76644bcmr1945359637.3.1775039964569; Wed, 01 Apr 2026 03:39:24 -0700 (PDT) X-Received: by 2002:a05:6a21:7a86:b0:343:c095:c4d6 with SMTP id adf61e73a8af0-39ef76644bcmr1945341637.3.1775039964112; Wed, 01 Apr 2026 03:39:24 -0700 (PDT) Received: from [10.133.33.205] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76bdaed389sm2016215a12.12.2026.04.01.03.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 03:39:23 -0700 (PDT) Message-ID: Date: Wed, 1 Apr 2026 18:39:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] arm64: dts: qcom: kaanapali-mtp: Enable bluetooth and Wifi To: Dmitry Baryshkov Cc: Jingyi Wang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 20260224-knp-dts-misc-v6-0-79d20dab8a60@oss.qualcomm.com References: <20260322-knp-pmic-dt-v1-0-70bc40ea4428@oss.qualcomm.com> <20260322-knp-pmic-dt-v1-4-70bc40ea4428@oss.qualcomm.com> <13745334-c2dd-4a97-90de-a5ee18cff6a7@oss.qualcomm.com> <0279f334-95ed-4df8-9e42-749fd854c551@oss.qualcomm.com> <3xb6ya4zxhmaode3u3al5r4g3rfzlq2ifbyodvwtr3qgt34pwc@ia2xqfaeufd2> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 4hfWh8m55gIAVOSk1y_moOrVOc_GqHUk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA5NyBTYWx0ZWRfX1sYkakr24R2O gqwq4aSRVTRENksvEjzr2Vs8DCW92MkwiBt6/sWgLBrsyzqhYoY/h4wVzfRDN0Joc1MZJE4OeUN 0DpJ3gPOl3BDGG2Ygtbh25bQDaP/C/4X0vmoTr5SByXXUbcbtv1oiUq6eufDEYFkrgAqX1bJ0Op 7Rw4i41V1Y6AvCSvhyE3P4gHrxcoy0d3SXlPHgJ6lM3Met8q7Dp+mITsPm3sm6LwocF8ZCtAoQu l0ocGD/JFApApwnyvwqp55mf3hBQ+eckkvHJ76jnZqJZwWuWV2A13CCHb54cHPcof9DOMk1TtWV 3gHe5YWFekXHj8uWu1rjuCzEHhnGM7egg8sTKgTwb9AEPc53MWG+HouIarGUR4H6nloG/JXy/+K KK4Drsa041UC+YetuJGf/LGg3ubQ98jH/B3vbDjxX8FWOMz45Bc9uOsKD3qQscy7Rrq5Br0lKiT 3EQChluMDYV6hTO9LLQ== X-Authority-Analysis: v=2.4 cv=fJc0HJae c=1 sm=1 tr=0 ts=69ccf5dd cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=F5tj5QwVYdw-9oKD5zgA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: 4hfWh8m55gIAVOSk1y_moOrVOc_GqHUk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010097 On 3/30/2026 7:53 PM, Dmitry Baryshkov wrote: >>> - Is the pin defined in the schema? >> schema define property 'swctrl-gpios' with description >> "GPIO line indicating the state of the clock supply to the BT module" >> >>> - Is the pin wired in the hardware? >> pin SW_CTRL is wired in hardware. > Granted your three answers, it can and should be described in the DT. > >> i have below confusions about 'swctrl-gpios' of 'qcom,wcn7850-pmu' >> which WCN7850 pin is 'swctrl-gpios' mean for ? >> Why to introduce 'swctrl-gpios' ? >> what problem does it solve ? >> how to solve the problem ? > Please descibe the hardware in the DT. Problem solving belongs to the > driver. sorry for not agreeing with your points here. it is better to correct or remove 'swctrl-gpios' within DT binding spec at least for 'qcom,wcn7850-pmu' with below reasons: 1) provided that 'swctrl-gpios' is for pin SW_CTRL of datasheet, binding spec's both description and its expected usage are wrong. 2) its driver does not parse and use the property 'swctrl-gpios', moreover, the property have no user within upstream DT tree. 3) the property is not mandatory based on binding spec. 4) upstream DT tree have had many such usages as mine which just set default pin configuration and not specify 'swctrl-gpios' explicitly. 5) kaanapali-mtp is originally preinstalled with android OS which supports some qualcomm specific feature which have not been supported by up-stream kernel. so kaanapali-mtp H/W has some wired pins which is not used by up-stream kernel sometimes