From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15C5E188733; Fri, 25 Apr 2025 18:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745605594; cv=none; b=j/xRmbnLgzfC3r0yzULdVdSP9aj3VW0IoIMc6VzY5VMi0X1XufKIO8AN97uJYLaq0Y0evF3/MrDoDWW0iqXScJfN6sCc8+h9Nh0Ys1jayYupzDPLUu3Vp97/e4xipfoG0bYtAxrYFusp+WarKRAE9jcKNv3bsIukdb9cTR0trJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745605594; c=relaxed/simple; bh=2DUsbW29zMQV7zddkgbCInIGpU7Hrsu8x/61yKM/jnA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=UxJnVgT4aYuC0/An2l/XYw+uZjyFpKTOKTVDslG/qkq8cgiBdD9zzJ9NmHszw2D9vuVpVPajJiiXMA2Yye6R0qYI/qXDX50gBQtjq7dCaaoeMx9YwDolbSvZSzTWp2Hzgi2N4NRepyq54udFXHSRtRNBRFGuAY8tUHmn7AttywU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=T4qEaufg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="T4qEaufg" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53PGK26X004870; Fri, 25 Apr 2025 18:26:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xZMv7SiIoHshOTME9bNp9P8XtaYBKhPto2h6/jAokac=; b=T4qEaufgt6xwG+3O zZT/onNhMwuPebIK0Oah9ptCnnPoAhDxbKaziYBeGK/G3y8L91qqpop50ovWX6rJ YbTHguYTHl1MAunpupcTL+26rKmJoDFgygoX20DKmV/7pVm1xLxP77nG02DW9Vrb xRtFN65gw4/gS3aBkcQ+Fim7ihxsIYWV7OA5cclgh4wztntnjPxcdM/fh3pNfKxI lNP1O/srPBB9DAyvyvcn8v8UJXI/IWNwJDa/+ykKWBBq+nrMHEea+FvHP0XWVLu1 vSvN+pPgb6yA5uBQNfWOx57p1RzQZTVrkQBI7wxM9Nt5WlhDoMDLLcF8/c4pewU/ JB06xA== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh0a0e4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Apr 2025 18:26:22 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53PIQLgC027567 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Apr 2025 18:26:21 GMT Received: from [10.134.71.99] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 25 Apr 2025 11:26:20 -0700 Message-ID: Date: Fri, 25 Apr 2025 11:26:20 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] drm/msm/dpu: enable SmartDMA on SM8150 To: Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio CC: , , , References: <20250308-dpu-rework-vig-masks-v1-0-f1b5d101ae0b@linaro.org> <20250308-dpu-rework-vig-masks-v1-1-f1b5d101ae0b@linaro.org> Content-Language: en-US From: Jessica Zhang In-Reply-To: <20250308-dpu-rework-vig-masks-v1-1-f1b5d101ae0b@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI1MDEzMSBTYWx0ZWRfX9zvCSfmEj78N vSGqAbA/px4fVmzpjUG784FVIgHBl266uZoWOlrvJ2ejyfrBVPUSfbEl9PsaJ4P9fWKNMxRc+f7 zCdhnE4E6tj+rw1Aj5ollsKzRteQy6VnnInwAG8X8HT44s/r/12lww2WpHx7q0nQ/2EvhcB4Mpg P+2wIu9f0Rg8aQ/XY7p1pBCMeWG+PDLyp3Q1HV6uFSJAf0gABRyI+0/xV/PrBrTpunFT0uuUoKq V/uCdoJkTA6jYWmURQGOdNhhcdp7mLdNYzDDm56saYnGOljmyIsN4L2Wvjr2p6Tkl/Nfgy4cTjY wMpzlLmIUMbCMD8hFIFmFSEENitcyQ4BvOr9Hf4+pQ2/kRS9U8eMl7oAeZbNga3YkYe0FEYqXWw wf9P+vL/i7U5pdTS1qiHExjkurmc42LwB2Fx74fWUC2ZEUcVIGgYVZK1TO2pS7G3zO/xS2yt X-Proofpoint-GUID: Vh98sIYu5l51usn4sAh59jX_r0H9-Ja9 X-Authority-Analysis: v=2.4 cv=ZuTtK87G c=1 sm=1 tr=0 ts=680bd3ce cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=KKAkSRfTAAAA:8 a=dNBeuL6aYRtJqjdC8AEA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: Vh98sIYu5l51usn4sAh59jX_r0H9-Ja9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-25_05,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 bulkscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504250131 On 3/7/2025 9:38 PM, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Reworking of the catalog dropped the SmartDMA feature bit on the SM8150 > platform. Renable SmartDMA support on this SoC. > > Fixes: 460c410f02e4 ("drm/msm/dpu: duplicate sdm845 catalog entries") Hi Dmitry, The code LGTM, but was just wondering why there's a fixes tag for the first two patches but not for the other catalog changes. Is there some context I'm missing with regards to this? Thanks, Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h > index 23188290001ffb45563a9953a9f710bacb4dac89..fe4de5b31644de33b77a882fa21a18f48ecd1790 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h > @@ -76,7 +76,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > { > .name = "sspp_0", .id = SSPP_VIG0, > .base = 0x4000, .len = 0x1f0, > - .features = VIG_SDM845_MASK, > + .features = VIG_SDM845_MASK_SDMA, > .sblk = &dpu_vig_sblk_qseed3_1_4, > .xin_id = 0, > .type = SSPP_TYPE_VIG, > @@ -84,7 +84,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_1", .id = SSPP_VIG1, > .base = 0x6000, .len = 0x1f0, > - .features = VIG_SDM845_MASK, > + .features = VIG_SDM845_MASK_SDMA, > .sblk = &dpu_vig_sblk_qseed3_1_4, > .xin_id = 4, > .type = SSPP_TYPE_VIG, > @@ -92,7 +92,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_2", .id = SSPP_VIG2, > .base = 0x8000, .len = 0x1f0, > - .features = VIG_SDM845_MASK, > + .features = VIG_SDM845_MASK_SDMA, > .sblk = &dpu_vig_sblk_qseed3_1_4, > .xin_id = 8, > .type = SSPP_TYPE_VIG, > @@ -100,7 +100,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_3", .id = SSPP_VIG3, > .base = 0xa000, .len = 0x1f0, > - .features = VIG_SDM845_MASK, > + .features = VIG_SDM845_MASK_SDMA, > .sblk = &dpu_vig_sblk_qseed3_1_4, > .xin_id = 12, > .type = SSPP_TYPE_VIG, > @@ -108,7 +108,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_8", .id = SSPP_DMA0, > .base = 0x24000, .len = 0x1f0, > - .features = DMA_SDM845_MASK, > + .features = DMA_SDM845_MASK_SDMA, > .sblk = &dpu_dma_sblk, > .xin_id = 1, > .type = SSPP_TYPE_DMA, > @@ -116,7 +116,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_9", .id = SSPP_DMA1, > .base = 0x26000, .len = 0x1f0, > - .features = DMA_SDM845_MASK, > + .features = DMA_SDM845_MASK_SDMA, > .sblk = &dpu_dma_sblk, > .xin_id = 5, > .type = SSPP_TYPE_DMA, > @@ -124,7 +124,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_10", .id = SSPP_DMA2, > .base = 0x28000, .len = 0x1f0, > - .features = DMA_CURSOR_SDM845_MASK, > + .features = DMA_CURSOR_SDM845_MASK_SDMA, > .sblk = &dpu_dma_sblk, > .xin_id = 9, > .type = SSPP_TYPE_DMA, > @@ -132,7 +132,7 @@ static const struct dpu_sspp_cfg sm8150_sspp[] = { > }, { > .name = "sspp_11", .id = SSPP_DMA3, > .base = 0x2a000, .len = 0x1f0, > - .features = DMA_CURSOR_SDM845_MASK, > + .features = DMA_CURSOR_SDM845_MASK_SDMA, > .sblk = &dpu_dma_sblk, > .xin_id = 13, > .type = SSPP_TYPE_DMA, >