From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Johan Hovold <johan@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Changhuang Liang <changhuang.liang@starfivetech.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org,
Stanimir Varbanov <svarbanov@suse.de>
Subject: Re: [PATCH 01/11] irqchip/bcm2712-mip: Fix OF node reference imbalance
Date: Mon, 13 Oct 2025 08:56:11 -0700 [thread overview]
Message-ID: <bf25d367-e98a-4475-b09a-55d6d47e428c@broadcom.com> (raw)
In-Reply-To: <20251013094611.11745-2-johan@kernel.org>
On 10/13/25 02:46, Johan Hovold wrote:
> The init callback must not decrement the reference count of the provided
> irqchip OF node.
>
> This should not cause any trouble currently, but if the driver ever
> starts probe deferring it could lead to warnings about reference
> underflow and saturation.
>
> Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
> Cc: Stanimir Varbanov <svarbanov@suse.de>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2025-10-13 15:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 9:46 [PATCH 00/11] irqchip: Pass platform device to platform drivers Johan Hovold
2025-10-13 9:46 ` [PATCH 01/11] irqchip/bcm2712-mip: Fix OF node reference imbalance Johan Hovold
2025-10-13 15:56 ` Florian Fainelli [this message]
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 02/11] irqchip/bcm2712-mip: Fix section mismatch Johan Hovold
2025-10-13 15:56 ` Florian Fainelli
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 03/11] irqchip/irq-bcm7038-l1: " Johan Hovold
2025-10-13 15:56 ` Florian Fainelli
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 04/11] irqchip/irq-bcm7120-l2: " Johan Hovold
2025-10-13 15:57 ` Florian Fainelli
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 05/11] irqchip/irq-brcmstb-l2: " Johan Hovold
2025-10-13 15:57 ` Florian Fainelli
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 06/11] irqchip/imx-mu-msi: " Johan Hovold
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 07/11] irqchip/renesas-rzg2l: " Johan Hovold
2025-10-13 13:19 ` Geert Uytterhoeven
2025-10-13 13:27 ` Johan Hovold
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 08/11] irqchip/starfive-jh8100: " Johan Hovold
2025-10-14 1:05 ` 回复: " Changhuang Liang
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 09/11] irqchip/qcom-irq-combiner: " Johan Hovold
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 10/11] irqchip: Drop leftover brackets Johan Hovold
2025-10-13 13:20 ` Geert Uytterhoeven
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13 9:46 ` [PATCH 11/11] irqchip: Pass platform device to platform drivers Johan Hovold
2025-10-13 17:24 ` Florian Fainelli
2025-10-14 1:11 ` 回复: " Changhuang Liang
2025-10-14 8:52 ` Stanimir Varbanov
2025-10-14 9:04 ` Johan Hovold
2025-10-16 9:51 ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-16 15:46 ` tip-bot2 for Johan Hovold
2025-10-16 15:56 ` Johan Hovold
2025-10-16 16:19 ` Thomas Gleixner
2025-10-16 19:01 ` tip-bot2 for Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf25d367-e98a-4475-b09a-55d6d47e428c@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=changhuang.liang@starfivetech.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jbrunet@baylibre.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=svarbanov@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome