From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9959EC433EF for ; Mon, 14 Mar 2022 11:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238910AbiCNL1N (ORCPT ); Mon, 14 Mar 2022 07:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238912AbiCNL1L (ORCPT ); Mon, 14 Mar 2022 07:27:11 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF44A3B280 for ; Mon, 14 Mar 2022 04:26:01 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id b8so14262550pjb.4 for ; Mon, 14 Mar 2022 04:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=o+I3gcydvpgsmI9xrJbonqfw/abZjMM8fb3Nm3LnnaY=; b=pq+bojTShDrNULnHGc2tXu0mQO7B8YiI0O5rAp52/+6qkCZPTNAMbw5xoo6QdjIS70 5f9bG5x/Mh7C04Ui7xfIfIEDlGySlwtDu4HJqDLOrEtmesalv8Whydt89mFX6MUyINsY fE91wFTBExhWtgjYmJBE7PetbeUkIxhe5dODcWwACMZD8l9Q12GVqdjGeJBk8NYC/EtR sJiLsg6QlcAQXPqq7Vi4diQlPTwwek4KG01GI7+wG0SMDz1N5W8tRGjw9/nQfMM3Cw/W jQo67ypirRrcCBysyJ6/4EcuvYwNPl+xJHOa3HpPzf4yhsJXPYj1SEdre/29iSzeNK/y Zbhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=o+I3gcydvpgsmI9xrJbonqfw/abZjMM8fb3Nm3LnnaY=; b=HOVp6nh1XO0rwZkvDmE00AyzwTMbqb0vvKrcy32FALeuR+jCCIceU2BMnKouI6evkt +3F2O9Bg6ZZRZRSfbKdR23Fwoodjvtjh3ylMHgqd2ApWaR0fv7NF6nFkmKvT0+zw0J8L t+eBC6LYPu+E3n0Qu5oVzKRvYUmsJX3jvvaekrG9labLbik7Xz0PeYzKv8YnYojk1Kyl IG7bilnrvf8Lb5mprDo1wHuCZZmAMUsMZxg6/Wwq/IgNPnJbB9WfUPNMslT7t1aGUl9k bHlpQgozp4baCyNz0dvg7VimbdRR9KzaqVJjYwUKNzyGAhaJWkyScrJUaNT1r9zfL1M/ yoCQ== X-Gm-Message-State: AOAM532vxVseA9/0h1/ObjjHoTgcBU27qzmyu4a3hzqtJ9gWWpXlDtt+ YEVKAvapXoM1sS7fsNCIeBp5f8oIjIPi6BQJ+Kk= X-Google-Smtp-Source: ABdhPJyVSK8GHgVSt6s5fJFM0Q75z+o93j5EUPjPPSuXmSEnRXPVMQ5JJdD/pp1A6fCl5z4/daL16w== X-Received: by 2002:a17:902:f70a:b0:153:88c7:774 with SMTP id h10-20020a170902f70a00b0015388c70774mr1013596plo.166.1647257161117; Mon, 14 Mar 2022 04:26:01 -0700 (PDT) Received: from [192.168.1.102] ([45.250.64.116]) by smtp.gmail.com with ESMTPSA id i11-20020a63bf4b000000b00380d3454c38sm13381561pgo.13.2022.03.14.04.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 04:26:00 -0700 (PDT) Message-ID: Date: Mon, 14 Mar 2022 16:55:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script. Content-Language: en-US To: Pavel Skripkin Cc: Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: <20220312204128.3942-1-shaikhkamal2012@gmail.com> <303ed0c8-8e2c-51a4-a4da-be973a25cdec@gmail.com> From: shaikh kamaluddin In-Reply-To: <303ed0c8-8e2c-51a4-a4da-be973a25cdec@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/2022 3:13 AM, Pavel Skripkin wrote: > Hi Shaikh, > > On 3/12/22 23:41, shaikh kamal wrote: >> Signed-off-by: shaikh kamal >> --- >>   drivers/staging/android/ashmem.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/android/ashmem.c >> b/drivers/staging/android/ashmem.c >> index ddbde3f8430e..4c6b420fbf4d 100644 >> --- a/drivers/staging/android/ashmem.c >> +++ b/drivers/staging/android/ashmem.c >> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, >> unsigned long addr, >>   static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) >>   { >> -    static struct file_operations vmfile_fops; >> +    static const struct file_operations vmfile_fops; >>       struct ashmem_area *asma = file->private_data; >>       int ret = 0; > > Are you sure this patch compiles? vmfile_fops is overrided few lines below > > odd checkpatch.pl warning... > > > > > With regards, > Pavel Skripkin Thank you,yes vmfile_fops is overrided in below code. Building the kernel - make -j4, drivers/staging/android/ashmem.c: In function ‘ashmem_mmap’: drivers/staging/android/ashmem.c:431:16: error: assignment of read-only variable ‘vmfile_fops’ vmfile_fops = *vmfile->f_op; ^ drivers/staging/android/ashmem.c:432:21: error: assignment of member ‘mmap’ in read-only object vmfile_fops.mmap = ashmem_vmfile_mmap; ^ drivers/staging/android/ashmem.c:433:34: error: assignment of member ‘get_unmapped_area’ in read-only object vmfile_fops.get_unmapped_area = ^ scripts/Makefile.build:288: recipe for target 'drivers/staging/android/ashmem.o' failed make[3]: *** [drivers/staging/android/ashmem.o] Error 1 scripts/Makefile.build:550: recipe for target 'drivers/staging/android' failed make[2]: *** [drivers/staging/android] Error 2 scripts/Makefile.build:550: recipe for target 'drivers/staging' failed make[1]: *** [drivers/staging] Error 2 Makefile:1831: recipe for target 'drivers' failed Thanks & Regards, Shaikh Kamaluddin