From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753308AbdK3QYy (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 11:24:54 -0500
Received: from mail-pg0-f49.google.com ([74.125.83.49]:34584 "EHLO
        mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753028AbdK3QYu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 11:24:50 -0500
X-Google-Smtp-Source: AGs4zMYcNj7o9HtGT9EI6t+TqaqwnCoYhZy2iFOUTBah9HnA2yWfD+KpQ/DF+J2OdehwtOZbpJcIYw==
Subject: Re: [PATCH net-next 3/5] bpftool: implement cgattach command
To: Roman Gushchin <guro@fb.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
        daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com
References: <20171130134302.2840-1-guro@fb.com>
 <20171130134302.2840-4-guro@fb.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <bf2a8929-8cd6-b6b2-7db8-6debbcfab25e@gmail.com>
Date: Thu, 30 Nov 2017 09:24:48 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171130134302.2840-4-guro@fb.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/30/17 6:43 AM, Roman Gushchin wrote:
> +	if (bpf_prog_attach(prog_fd, cgroup_fd, attach_type, 0)) {
> +		bpf_object__close(obj);
> +		close(prog_fd);
> +		close(cgroup_fd);
> +		p_err("Failed to attach program");
> +		return -1;
> +	}


Also, what about support for BPF_F_ALLOW_OVERRIDE and BPF_F_ALLOW_MULTI
flags?