From: "Imre Kaloz" <kaloz@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org,
"Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] MIPS: c-r4k: Flush the cache error vector before writing it uncached
Date: Mon, 26 Oct 2026 21:59:57 +0100 [thread overview]
Message-ID: <bf2d5ac3-42e1-4c08-ac8c-d3b19fe5049a@app.fastmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2610261935230.42255@angie.orcam.me.uk>
On Mon, Oct 26, 2026, at 21:00, Maciej W. Rozycki wrote:
<snip>
> Hmm, I'd be tempted to call the hook flush_dcache_size() or suchlike for
> consistency with our existing nomenclature where "flush" stands for WB+INV
> and to signify that this function doesn't touch I$ (the *_range() suffix
> is already taken for interfaces using start/end rather than start/size for
> the boundaries), although our naming seems messy overall.
>
> Any other suggestions, anyone?
Fine with me. Unless someone has a better name, v3 will call the hook
flush_dcache_size()
<snip>
>> @@ -1743,14 +1743,15 @@ void r4k_cache_init(void)
>>
>> flush_icache_all = r4k_flush_icache_all;
>> flush_data_cache_page = r4k_flush_data_cache_page;
>> + cache_wback_inv = r4k_cache_wback_inv;
>
> Please update arch/mips/mm/c-r3k.c accordingly.
Will do.
Thanks,
Imre
prev parent reply other threads:[~2026-10-26 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 12:04 Imre Kaloz
2026-10-26 20:00 ` Maciej W. Rozycki
2026-10-26 20:59 ` Imre Kaloz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf2d5ac3-42e1-4c08-ac8c-d3b19fe5049a@app.fastmail.com \
--to=kaloz@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®