From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7EBC432BE for ; Mon, 30 Aug 2021 12:09:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16CA661041 for ; Mon, 30 Aug 2021 12:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237464AbhH3MKT (ORCPT ); Mon, 30 Aug 2021 08:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236582AbhH3MKR (ORCPT ); Mon, 30 Aug 2021 08:10:17 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65F88C061575 for ; Mon, 30 Aug 2021 05:09:23 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id j17-20020a05600c1c1100b002e754875260so9266419wms.4 for ; Mon, 30 Aug 2021 05:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=v05CHMGkNy/7iRKZsqcb072iAMcR/4Py4W7Z6a3AFlw=; b=PRZsfWp4uIvlMEd8zyEQdp3H+MRjz4psg405lNjW2xPYzAd7ITYSWIsTHWSpzEv+2v t/mnwGLByQblAhZXVo4OcTWDLMlY6tL/ajNMcy84H0Zd56W4aj8ddouXwuM8ScBwOTI4 wsNP2rUsSd+ef8fx9BZXIaWs0H0ndPKKuJXnjh2SpIg6hO6oH4UZhFoZe+R/T5Bs9EfP cw6RAzowgH+GbZqk2l7AkKSrI6wMjWlh72biVrbR1HcLT6tSh/v0ehDBpcAlZ0iD124C Sp0Xv/9Y1NsDqqXbWDilB4KmxK3A4IzuMKZnpEO6RiELM1BXLrWRfir4SjWFIBpUhpgN xt5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=v05CHMGkNy/7iRKZsqcb072iAMcR/4Py4W7Z6a3AFlw=; b=hufIcBPMtX7c6J/bQN2foelNyzmAAgTycM1w6/nxksonoMQWNqJmObMb293uCqn2ak 7GlHCVZqovmBXNeE88NRP0Y0g26gPm9HnqfikAOZ6V5tsBvELMv8kKz9q81W9FJ1BBDG eyLxQgYhuzOi7sp7VxBudMz9wBrhdjgsHSPFpfmqFM1r2pj+NAQlqtvkNBnKkomWUM45 7yzi9N+vnnL53mVuuAuiHR/SizW83tx5W2JoSkAL+UiqAItcueZKscHwuz4s/b55cSBP vfoOe1QAi/VdIYgadMA/zOoknBPtAaf9GB2oPs5R+KPPNChYe2Kewhdiyn2ou0SWjERi L6Jg== X-Gm-Message-State: AOAM533W231TaNxdjVvDDFzWmFWU4vSIrQUIjCf+UYHx7vIlMM5caq+v unc9JKXOllAi2YRRGqF959s= X-Google-Smtp-Source: ABdhPJxLHc72SK8sGt4caZFSMgEUzyl7jwMEiCsgAu3q+ppOzWXNQYC79UJDO58a4NHQSaLk18orRw== X-Received: by 2002:a05:600c:a4b:: with SMTP id c11mr21717493wmq.97.1630325362003; Mon, 30 Aug 2021 05:09:22 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::16fa? ([2a02:8108:96c0:3b88::16fa]) by smtp.gmail.com with UTF8SMTPSA id q13sm15116117wrv.79.2021.08.30.05.09.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Aug 2021 05:09:21 -0700 (PDT) Message-ID: Date: Mon, 30 Aug 2021 14:09:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree Content-Language: en-US To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, ross.schm.dev@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Michael Straube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/21 19:00, Saurav Girepunje wrote: > Remove NULL check. NULL check before freeing function is not needed. > Correct the indentation. > > Signed-off-by: Saurav Girepunje > --- > Acked-by: Michael Straube Thanks, Michael