From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D408577E36; Wed, 9 Sep 2026 15:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788969464; cv=none; b=VlJr9ZJer/0usfM7xB1O51BTzHnfYMhnZf9YGcxXFMuBDA5irQtmY0wbxY8eLZuyZVaK5gNfRzkDAqVTCBvDPBaUWgIhBMLM+kfPwswHlq5njIui9P2Trui6NS9rCCBfcvOZNxxeiNeGV2guNqI3Lub9th6RyNqbn2hDVk9zPFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788969464; c=relaxed/simple; bh=ehvm8WX/tBES0CVtgVbxyg6Cn28xCCMPB3Dk//3dTr8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oIYJChbLUAYOD7Ts4m0yGUwhFOXmbJ/96UuCdnQ/23mXxafUEyzfNa0vgHvQsGfqzc18CNRqFdC4MN10Uu1oBXuwS+QneC0RHZam2ZkvtyvFTaNelsHwCHKmoTKAM+5NoREx8e8Rjt4yUyYXBB0eis+HOf3VhGNjoLvbYmoyIQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=JaSQu44p; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="JaSQu44p" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689B1Rtj3817360; Wed, 9 Sep 2026 15:57:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=4iy8+0 hPHH7H0KKiy1Q7l0n/i6naXWb1uop8VCTdEJI=; b=JaSQu44pl+aIEJoiFJDWMG HchHUmbXHHotFErjlf8Fe7i8rpP0Ieft5b0BQGRt36/W5daev1jbFrpn6Tiq+M/o uZ4cpMUOBZ9OjxNUfkLC1bRV6EO/6ypsipJrzeixBHCfQhLmrPgG6wLBepTfKiZG 0x0XK2QlvXdeD36NOCD5fG1s1pBI8HsnDnUz9Q++MFQCwibdOrpqABpVkieBZdIm 1wqyulr0MQdjDo5QgC50gwAGGLC7zlDH27ZDt66gHSi/pI5IUnbQqZ25V8E/CACb 1ZLoNLkFXpO6Q37XnJGIB2FVEHSAjMfQLSi+2wtyNIkiNeAvjzRWtLCtA/SQfZPA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ggbf46xjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Sep 2026 15:57:06 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 689FuGdF014562; Wed, 9 Sep 2026 15:57:04 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ggxdk35yd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Sep 2026 15:57:04 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 689Fv2UA48234994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Sep 2026 15:57:02 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 555E82004D; Wed, 9 Sep 2026 15:57:02 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA3AA20040; Wed, 9 Sep 2026 15:56:52 +0000 (GMT) Received: from [9.61.255.18] (unknown [9.61.255.18]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 9 Sep 2026 15:56:52 +0000 (GMT) Message-ID: Date: Wed, 9 Sep 2026 21:26:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/22] coredump: deduplicate the to_skip flush To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jacob Lalonde , Josef Bacik , Jann Horn , Alexander Viro , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Omar Sandoval , Jacob Lalonde , Shuah Khan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <20260820-work-coredump-sparse-v2-0-ba32dd718c51@kernel.org> <20260820-work-coredump-sparse-v2-9-ba32dd718c51@kernel.org> Content-Language: en-US From: R Nageswara Sastry In-Reply-To: <20260820-work-coredump-sparse-v2-9-ba32dd718c51@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: o_ppSA6HpClRhej38K5mg3ChmUpff7fD X-Proofpoint-GUID: bPnYIgREOEB5EeDQA6JU4_KoXaV7HYBi X-Authority-Analysis: v=2.4 cv=DbEnbPtW c=1 sm=1 tr=0 ts=6aa181d2 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=U0HCTcrEiqaaI9b4TmsA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDE3MyBTYWx0ZWRfX1INXvyjh3PgV xQbn2Uih0jsf4f6qVCpUDcjJWOb00k+Ln6MWP1HEhOKbnwX46byyERV24jF3E25LwaMtTwAoZAG JlLZGp14DEo26h1b9FeakcBQY4sy0+mZ19NERd76bxzjO6yBGJLgljT6Yt/gYZvrUn0O5JG5PwR dTB95L9owQM4u9Y55ThhxTfzzkVEIIYNmVVSdHs68AQc7YygY6nDesC7CjK7Lj5oZmaoHCafPlc YzRco/I2Cc13eUypylwhjU/ds+UEADyYW6PRnj5JonLnxV6j16SuM5ekwlPfrHQGPvuDUpoMtrM oZ6JMWmlYtbmHsh0EZ1aB0s1/DpXVQ7s2HDMwYZcEOI72U5VsJGy6SgQ19D3uShtLC3PplZYdT7 BsaR05CMnTEUC+PonGGCwFmWatR530/8w9adsbU8wPtMdP44EHtsZsZOUy64XFoLw7Vl6+y4QNx E5iKRzrAgR1p38vAmIQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDE3MyBTYWx0ZWRfX5v5JLgxSqhGg k6WRTM/rDiDuG3bMIzKiwt4bgN/RJmrPOK/vdSj+EnzdvWNnr1shv0tQh4Rh2GEl06RaHS3lbW2 9jZZMbTQ05NqRYg50QCFDq0Wjry0tYQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090173 On 20.08.2026 4:39 AM, Christian Brauner wrote: > dump_emit() and dump_emit_page() open-code the same flush of the > accumulated cprm->to_skip. Move it into a helper. > > No functional change. > > Signed-off-by: Christian Brauner (Amutable) Tested-by: R Nageswara Sastry System: ppc64le LPAR (IBM POWER), Linux 7.3-rc2 > --- > fs/coredump.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/fs/coredump.c b/fs/coredump.c > index 156688be3df0..cd36a72be445 100644 > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -1256,13 +1256,21 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr) > return __dump_emit(cprm, zeroes, nr); > } > > -int dump_emit(struct coredump_params *cprm, const void *addr, int nr) > +/* Flush the accumulated hole before writing data. */ > +static int dump_flush_skip(struct coredump_params *cprm) > { > if (cprm->to_skip) { > if (!__dump_skip(cprm, cprm->to_skip)) > return 0; > cprm->to_skip = 0; > } > + return 1; > +} > + > +int dump_emit(struct coredump_params *cprm, const void *addr, int nr) > +{ > + if (!dump_flush_skip(cprm)) > + return 0; > return __dump_emit(cprm, addr, nr); > } > EXPORT_SYMBOL(dump_emit); > @@ -1293,11 +1301,8 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page) > if (!page) > return 0; > > - if (cprm->to_skip) { > - if (!__dump_skip(cprm, cprm->to_skip)) > - return 0; > - cprm->to_skip = 0; > - } > + if (!dump_flush_skip(cprm)) > + return 0; > if (cprm->written + PAGE_SIZE > cprm->limit) > return 0; > if (dump_interrupted()) > -- Thanks and Regards R.Nageswara Sastry