From: Markus Elfring <Markus.Elfring@web.de>
To: Henry Martin <bsdhenrymartin@gmail.com>, linux-input@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH v3] HID: uclogic: Add NULL check in uclogic_input_configured()
Date: Tue, 1 Apr 2025 12:14:04 +0200 [thread overview]
Message-ID: <bf3ff4a5-e8e0-4d25-b878-1ee2308befcc@web.de> (raw)
In-Reply-To: <20250401094853.24143-1-bsdhenrymartin@gmail.com>
> devm_kasprintf() return NULL if memory allocation fails. Currently,
…
call? failed?
> Add NULL check after devm_kasprintf() to prevent this issue.
Do you propose to improve this function implementation a bit more?
…
> ---
> V2 -> V3: Kept the original switch structure, only optimized the outer
> conditional checks while maintaining safety requirements.
> V1 -> V2: Simplify the handing of the condition "suffix" with if/else.
* Under which circumstances will you begin to care more to offer such adjustments
in separate update steps?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n81
* Can another tag become more helpful?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n598
Can an other control flow variant be a bit nicer finally?
if (suffix) {
…
} else {
…
}
Regards,
Markus
next prev parent reply other threads:[~2025-04-01 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 6:31 [PATCH v2] HID: uclogic: Add NULL check in uclogic_input_configured Henry Martin
2025-04-01 8:21 ` Markus Elfring
2025-04-01 9:48 ` [PATCH v3] HID: uclogic: Add NULL check in uclogic_input_configured() Henry Martin
2025-04-01 10:14 ` Markus Elfring [this message]
2025-04-24 10:12 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf3ff4a5-e8e0-4d25-b878-1ee2308befcc@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=bsdhenrymartin@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®