From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F37C83F13 for ; Sat, 26 Aug 2023 12:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbjHZMNA (ORCPT ); Sat, 26 Aug 2023 08:13:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232308AbjHZMMi (ORCPT ); Sat, 26 Aug 2023 08:12:38 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E55392126 for ; Sat, 26 Aug 2023 05:12:33 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fee769fd53so15199935e9.1 for ; Sat, 26 Aug 2023 05:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693051952; x=1693656752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JLR4lKpSrBGh74bNs1ZhoMsFZ4xpCfbewSlODAvo1xI=; b=WeUAtpN2OtGCi6KVD0PPwUIgIrPikv8oX7vf041ZpfbehX+cAkMJe+5FddjEJO/yVL hjGA+2J9Dg8abIwsd5APkCSt3rmRTjmnKw57JQ10wj0G7V34mx2wNIOhu/eywEqtNKUf MdduoaBEC8ERZ5Rd/hn8368CpmZ6xw4v+Ro9YBbvjwvDZXCZRtERzY6Gvh2qJh6N33br qtvVmOtaeipJ2c5arbVZPJvWygLt+50bK4sNd433h4Ojm3G+QWa3BLge9fEwG7uscmEC g7um5M4knsB+gCrLJEsals1q+KHSOC9HWv4GqkMx/mPMzMNZQYiyFZvk1P9ugb54V/W4 sDvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693051952; x=1693656752; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JLR4lKpSrBGh74bNs1ZhoMsFZ4xpCfbewSlODAvo1xI=; b=D4W95wxe4FaxmKsM0TzZLQj8fcnQBYpPvuQapru+TZnVLIACZiPYUiZ8ZmuJBJtmwo RYa/VF4C4v7/o5Z3jP5HAwsO5qe8wdkPsHxWidPuVG7Vb7pBqBnknleWWLVOOddFlFZD 7B7AyUBT2NGfcilaTVb7/HTNpsqprCi5/JGIV5U7NGC+E0HzZr88KZI8Xi/VIw+W1qJb L/I4Ig7lyDtavRsqlriuW7+KVmhfVcVM3MVOXL8OuxykXCli4sMRISk+jsUBlEA1COJw vZAAtdHBV1af3gmg3iDTOklgqLrBFnOC117mIs/eK/4T/aj4UBnLV+PDJd/PznaEFQOD ru2Q== X-Gm-Message-State: AOJu0YwZM4R+Bvbj6RAVjIm8+TmySPYrC8COXx5eu9FKe4u2i1HSMzzu obHI85kHhtzYy8Z7vEU3g+uvhg== X-Google-Smtp-Source: AGHT+IHu8mB0iHzMojvDALhi+tbFwky4s75VV+xoLfdKurAr4mztVjj9KSRQxkrUdm1YG++fzS9I+Q== X-Received: by 2002:adf:f9c4:0:b0:317:690e:7b39 with SMTP id w4-20020adff9c4000000b00317690e7b39mr16519965wrr.12.1693051947627; Sat, 26 Aug 2023 05:12:27 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id r6-20020adff106000000b003197c2316ecsm4785661wro.112.2023.08.26.05.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 05:12:27 -0700 (PDT) Message-ID: Date: Sat, 26 Aug 2023 13:12:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function Content-Language: en-US To: Konrad Dybcio , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-8-bryan.odonoghue@linaro.org> <95db5a14-87dc-4f08-b8e2-52bce140354d@linaro.org> From: Bryan O'Donoghue In-Reply-To: <95db5a14-87dc-4f08-b8e2-52bce140354d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/08/2023 13:04, Konrad Dybcio wrote: >>>>  From sdm845 onwards we need to ensure the VFE is powered on prior to >>>> switching on the CSID. >>> And what's the symptom if we fail to ensure this? How can someone >>> adding support for another platform tell whether the match-list >>> should be expanded? >> That person has to understand the dependency. > If we need this workaround, there surely must be something that doesn't > work without it, a measurable symptom. What is it? The CSID lives inside of the VFE therefore the VFE must be power prior to the CSID. The symptom will be .. the CSID doesn't come out of reset. --- bod