From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751679AbcGNShq (ORCPT ); Thu, 14 Jul 2016 14:37:46 -0400 Received: from www.linutronix.de ([62.245.132.108]:45777 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbcGNShp (ORCPT ); Thu, 14 Jul 2016 14:37:45 -0400 Subject: Re: [RT PATCH 1/2] timers: wakeup all timer waiters To: Steven Rostedt References: <1468512304-15310-1-git-send-email-bigeasy@linutronix.de> <20160714121341.2b0e70f5@gandalf.local.home> <20160714131945.67cc8ce5@gandalf.local.home> Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de From: Sebastian Andrzej Siewior Message-ID: Date: Thu, 14 Jul 2016 20:37:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160714131945.67cc8ce5@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/14/2016 07:19 PM, Steven Rostedt wrote: >> While doing so I noticed that we drop the base lock during timer >> invocations and so it could be possible that we have two invocations >> of del_timer_sync() on a timer on the same "base" (one after the >> other). This is patch #1. >> >> After that I saw that we do the wake up under the base lock but there >> is no reason for it. So here is patch #2. >> >> Patch #1 is something that could happen in theory and I did not run in >> any problem. >> > > OK, so patch 2 was just discovered by reviewing code? both, not just patch 2. > > -- Steve Sebastian