From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36B2C433EF for ; Thu, 21 Jul 2022 15:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbiGUPuX (ORCPT ); Thu, 21 Jul 2022 11:50:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbiGUPuU (ORCPT ); Thu, 21 Jul 2022 11:50:20 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0A6DBE11 for ; Thu, 21 Jul 2022 08:50:17 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26LBtj1r023900; Thu, 21 Jul 2022 10:49:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=46ySDQe4xkYQJIAAZXfQ37h3NC2XgZ7nTWd8+QKiPEQ=; b=dd5tQHfjGg08umInWAm0hP9jXTLKqHMG/vo1AiHHNKCKiAZsSn5HY/qoYtXrvRtd5L2G 6cgvlpDvR06Vg3+kaYbvWpXZRIUk0aJXhlpy1y7cDUACTkbaRBxGu2uKO9GXOfjM0q5P JXpHjGamLCP15vJw5N8GdH+tMvnvvOCNUfVUPlRQ8cysxfeOfuzPouPoLU5AAFQTUtga bAhWlqh1VITvbECNJxrJwoavZ1qQmAbttGltX1DmSGr/1dt2Aj5u9q6BjwOL0A15rxv3 pc3b6PsHUEcJrLSdpo/MNpoFFXya3axWuEz8zZfyDXEHtshMaCGCXHtnhmFoACH8+iOy 2w== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3hdxffarpm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jul 2022 10:49:47 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Thu, 21 Jul 2022 10:49:45 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.9 via Frontend Transport; Thu, 21 Jul 2022 10:49:45 -0500 Received: from [198.90.202.131] (unknown [198.90.202.131]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 2D21F7C; Thu, 21 Jul 2022 15:49:45 +0000 (UTC) Message-ID: Date: Thu, 21 Jul 2022 16:49:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops Content-Language: en-US To: Kai-Heng Feng CC: , Stefan Binding , Kailang Yang , , Meng Tang , , Werner Sembach , Tim Crawford , Andy Chi , Cameron Berkenpas , Yong Wu , References: <20220719142015.244426-1-kai.heng.feng@canonical.com> <444a7ab6-d47e-6e0a-de0c-1efb292edb8a@opensource.cirrus.com> From: Lucas Tanure In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: YqwjOAJeVXq3xV5kz6NtJh_E5TYW2kNR X-Proofpoint-GUID: YqwjOAJeVXq3xV5kz6NtJh_E5TYW2kNR X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/22 03:07, Kai-Heng Feng wrote: > On Tue, Jul 19, 2022 at 11:27 PM Lucas Tanure > wrote: >> >> On 7/19/22 15:20, Kai-Heng Feng wrote: >>> Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute >>> LEDs. >>> >>> So use the existing quirk to enable them accordingly. >>> >>> Signed-off-by: Kai-Heng Feng >>> --- >>> sound/pci/hda/patch_realtek.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c >>> index 2f55bc43bfa9c..cdbee71e83216 100644 >>> --- a/sound/pci/hda/patch_realtek.c >>> +++ b/sound/pci/hda/patch_realtek.c >>> @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { >>> SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED), >>> SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), >>> SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), >>> + SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), >>> + SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), >>> SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), >>> SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED), >>> SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED), >> Hi, >> >> Can you send us the ACPI dump (DSDT file) for review for both laptops? > As attachment. Your DSDT looks good, I will +1 your patch. > >> We want to ensure that the ACPI has the correct information so the >> driver will work properly. > One thing we noticed recently is that _all_ systems that are equipped > with cs35l41 have rather weak speaker output. > Sound is barely audible when the volume is around 50%. Full speaker performance will be enabled with DSP support. The code for this has recently been merged and you may need to backport it to your code base. Additionally, the appropriate firmware and tunings need to be available for your specific SKU.  We are in the process of pushing these to the linux-firmware repo now.  If there is a particular SKU you wish to prioritize, then please let us know. > > Kai-Heng > >> Thanks >> >> Lucas Tanure >>