From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E64C2D0BF for ; Tue, 10 Dec 2019 10:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2E932053B for ; Tue, 10 Dec 2019 10:29:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c77gJqOY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727495AbfLJK3H (ORCPT ); Tue, 10 Dec 2019 05:29:07 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:37144 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727131AbfLJK3F (ORCPT ); Tue, 10 Dec 2019 05:29:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575973744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYRdhx94lZEfdmmjolViEp26vremOEQhwyKs35+L2rM=; b=c77gJqOYUsQL1d9KSg+A03qtUipZ8AXGNTqjDnUbwLIINBTvVSahW8ANhm41V8tVWDl7pg I/1K4yohJvhMRhSCytYEJroREsLotrp4OYCE5rQvfu9Esltz1SbO+XFM/UqNAU/7FLBpg0 0CAJ1TLIcjF4ZlzHpP2/rG0+mJUJGFQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-gPGThsl2MwaIk8TeNPMJOw-1; Tue, 10 Dec 2019 05:29:02 -0500 Received: by mail-wm1-f70.google.com with SMTP id j203so845640wma.2 for ; Tue, 10 Dec 2019 02:29:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iYRdhx94lZEfdmmjolViEp26vremOEQhwyKs35+L2rM=; b=UU7I8xVgKYQbEgMUWD2LguyjzA0nmMschnomhuDmyKy0MxYg+bYSPxZtC4RMVrxpEx d25dvbLPJ8GKLaGOPWK/nDut18qdyo/PBUYPDdu+ZWnjxAEHUMwl1C6lPOzcMyokTKqO BNV1tbWVrpj7acJSauyWZ/fZPOe6le/DcdcJ2MgUTjYJz/8Ucl41js4sk6St4/hpoIOs zKEJ1PPz8cTGrzHS6WbD9a6jcSWqgn3R5smJN+DhMibBLgPmicWGChQiJH+ftxZMJ79+ MUSyKSTS+V/EBpyYu1emMfdqNp8tM/5CJMKlo0mfB8xnhi5FTr4dz/yoHjGLN6Y76/LU oxmw== X-Gm-Message-State: APjAAAUEfLTnuXWkCd3L8s4Bv72PWWLNdGwvUbZygRmGVR+ZFfyvuKc4 +gWAjV1C+ZVqb2KM0QaZ4l+g6dJORk6SfCFgRYNmXV/dV/rbAVF3snc2oTEbPKp2MEH0/tsrahb dkKMUccfGIsJoMajSWnDCEpY5 X-Received: by 2002:a5d:6284:: with SMTP id k4mr2304027wru.398.1575973740920; Tue, 10 Dec 2019 02:29:00 -0800 (PST) X-Google-Smtp-Source: APXvYqzuMgkVYc+esWPIvGo0F5L891J0fK0Q3nskPFxv2CWHs5OO4BgCv23sK914Q45HzzW2+5D5HQ== X-Received: by 2002:a5d:6284:: with SMTP id k4mr2303997wru.398.1575973740718; Tue, 10 Dec 2019 02:29:00 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:e9bb:92e9:fcc3:7ba9? ([2001:b07:6468:f312:e9bb:92e9:fcc3:7ba9]) by smtp.gmail.com with ESMTPSA id f1sm2551482wml.11.2019.12.10.02.29.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2019 02:29:00 -0800 (PST) Subject: Re: [PATCH] KVM: x86: Add a WARN on TIF_NEED_FPU_LOAD in kvm_load_guest_fpu() To: Sean Christopherson , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191209200517.13382-1-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: Date: Tue, 10 Dec 2019 11:29:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191209200517.13382-1-sean.j.christopherson@intel.com> Content-Language: en-US X-MC-Unique: gPGThsl2MwaIk8TeNPMJOw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/19 21:05, Sean Christopherson wrote: > + /* > + * Reloading userspace's FPU is handled by kvm_arch_vcpu_load(), both > + * for direct calls from userspace (via vcpu_load()) and if this task > + * is preempted (via kvm_arch_sched_in()) between vcpu_load() and now. via kvm_sched_in (not the arch_ function). Applied with that change. Paolo > + */ > + WARN_ON_ONCE(test_thread_flag(TIF_NEED_FPU_LOAD)); > +