From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412EAC77B6E for ; Wed, 12 Apr 2023 11:08:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229872AbjDLLId (ORCPT ); Wed, 12 Apr 2023 07:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjDLLIb (ORCPT ); Wed, 12 Apr 2023 07:08:31 -0400 Received: from xry111.site (xry111.site [89.208.246.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F3FB7 for ; Wed, 12 Apr 2023 04:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1681297710; bh=ALuqxXkknpPb+XGh4R8O0PTpAo7fqkBau9qQsFBl8xE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Q3UzUbY44p7ukE1Tkt1fkkTKSZnCiVbjhMP40lTMU1NdYplbK/fbWmQFJ6h2N/WyC ikBWXyKkCCsKSyIe65lIOvEXErMceOLdWGm6tvO549f1cZPL8zv58JIFG+zAPaD3/4 EDvANhuTMKwll7GZI+yYHGr98enV3ChBYfl+FAhM= Received: from [192.168.124.11] (unknown [113.140.11.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 3CCC966212; Wed, 12 Apr 2023 07:08:29 -0400 (EDT) Message-ID: Subject: Re: [PATCH v1 3/4] LoongArch: Use larch_insn_gen_break() for kprobes From: Xi Ruoyao To: Tiezhu Yang , Huacai Chen , WANG Xuerui Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn Date: Wed, 12 Apr 2023 19:08:21 +0800 In-Reply-To: <1681293901-24918-4-git-send-email-yangtiezhu@loongson.cn> References: <1681293901-24918-1-git-send-email-yangtiezhu@loongson.cn> <1681293901-24918-4-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-04-12 at 18:05 +0800, Tiezhu Yang wrote: > -static inline bool insns_not_supported(union loongarch_instruction insn) > +static inline bool insns_not_supported(u32 code) > =C2=A0{ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0union loongarch_instruction in= sn; > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0insn.word =3D code; > + I remember Xuerui disliked this change. Maybe we can add __attribute__ (__transparent_union__) [1] for union loongarch_instruction instead? [1]: https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-t= ransparent_005funion-type-attribute --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University