From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 456E74218A9 for ; Tue, 16 Jun 2026 09:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781600956; cv=none; b=hEvaIVudEbVbbNE548umh8iA1X1zk9/wMX1eMBnBksAdqcD6c8V/gApEpPiF9a+3crsvlP/5Yk+rdYZicdeIxyE5NB/AZXswN0+1iSB8rkXJvYcBrGtcDFB3E3ucA0JTs3hqerh0HEiG1RwQzZ7gjJ8N0mUk/kpP6AOkZzSdSp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781600956; c=relaxed/simple; bh=Ih6jeq8wPPjziulVsHkz2i18GZmjPdSfbEXqLyxqvv0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dkeK2pEBCfL6tI1Byqtn3vv9puVeQF2oQaWoeDHwKUpbgmTQwTZDK4waSiXAuCLe87Y8e/T2z2jNAwnEw+cXmZmhusKXQr32MZSSAPpaOa79wNwmpP1dNSv+npW/e6LrQ407qcLlD6c+P+sSPtgQ2TDjOcAU008ywYMUFXCPSOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ROsV5Jy3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VxcQactk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ROsV5Jy3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VxcQactk" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65G8Oc3J006759 for ; Tue, 16 Jun 2026 09:09:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tF8QGDLALBCYPdqex0XcjlP/aqvAXjPOLvPPj6ruw/0=; b=ROsV5Jy3TdJPHVRu Wh4BBmLwk/uud2DbnPr9z+dhI/eGPXYjSDGNsLmCaWbt9KzD8k5inhdq7Lzes6PK SGcc91GGqkelEdHyw8dR/5yC2q9U05buqzYQijBuHckO2Bm//Rl83s44r7DPHNuJ WzGmj2HW0e3KLWj4SqYkjwIJus1uMqp2q1y5+/7kV+sTagu5O8CAF2nYH3RYuuv2 zjMHBJkpDdw9eKBabihqJiw2xKfNYbq8NDpOSphPt4gi+586VO+8Wrl2EYx3ZXOe VoDGBWywcoJL7zPvBo9STb+3kl2H1UX67ev3qlJn5W2G49UBe/dRcs7DhefQj3vV Ut+upQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu2xs861d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 09:09:14 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c6a48fb4d5so2071505ad.0 for ; Tue, 16 Jun 2026 02:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781600954; x=1782205754; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tF8QGDLALBCYPdqex0XcjlP/aqvAXjPOLvPPj6ruw/0=; b=VxcQactkiAyFeKbtn6XXJ9ZITb8j/b/P59Fw/vEyWai8ZNNy0te2c0L5qwUcQXIdnc KwES1GY0pNWnTjIbyXaFstZb+n1F2VDYFT81RfU4n/u7wHI4iEXocF6BRLIrG7SSgDZg Rd1zfKwVSEkWU7aXC5AdVgD/IWMmwqPL6g/1cOVhYmqPQGViC6zvaAc/b6xy7K6a0Npd z82pwUYePhn9TQdDgszFOeRfAwMvhUv8wY4qdTtT/XzV68pT/kFpe/X5gPt6r9ydPdwA T5VHtuTs3o6gIZFin/6LTOzt90vw1c1B0XKJENSfVAHTs8BbmxfTt9HAS7ibHU+fhjDF jxOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781600954; x=1782205754; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tF8QGDLALBCYPdqex0XcjlP/aqvAXjPOLvPPj6ruw/0=; b=Z5r0sxEKynu3ziqhr/BuTlXwdWsEu8mr99gfksxkyFyKApLPK6xQdZkYw13u9yi+Xv EPfpEVqFyxggMH3/4Uwjn2C5LzciEM0QNFSUlo1pi9IR/P6G2cOtVggO06v+sgx5K6t1 ymw956fYMbhA9hF7OdklP+A1Cz/psWsxbqQy5rS/0hw0XdurzyuBUlBPxUy3STkurs33 5cKVHN0Ze23CqfCFCNWY1gpfKnA11+i70nzkfiYwZUjHfQeYpM4xWV1qqR/4/FIn61xJ LgMuzPW0WQIP2mqONSe+v7eXIDNeTUI2q40Fau7GIc22LlIo1QXfGtG5g47P3mqsWdbF zKAQ== X-Forwarded-Encrypted: i=1; AFNElJ9r0GMCvtqrPQKBBbNMECctPcb/qBRTIAkUazhfbcgEh8m2GVTuFyuW1//sc1x7S4I+U9ZfWwf3xUTLQP4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4c6UF48yijZGUluYuZte15mqLvqalVZP8P3uYI8EbhaSjbGzv I/ai2dVNGHgfpRdiud3UGMEmiH82DZ4q16DXYWVLD0DDM0JkPqhHyTtN9g7kzwOj6t5kVlKUcwU fLJDwsiMArTYlQGgt6Ce/OQbB4j9ZKADQxnJR6tw3A0Z+vqOlib9BeV3O/2tPRECC2Eg= X-Gm-Gg: Acq92OGWrtHQelzaxB+D/0NLT1xNBLRcEPCbapf402zWHCVo8TNQy+cwgt2+algLHks s/YK8gJxzVZcSSI7v/Nxu7cC9TXD3UUapjhilcgF6Rr0fEtm36R4kNDQ3t3gvjyYjw67zf1tUs0 9ZmX5dSUTRBPI0R5rf2LfAWJPV9p+10xwKfV6bxOVb+jTiYIGswMpO7yVpMXBjsR+GPQGf8/4d0 Vq0sMjA49vpXKqV7NUxVudm0GPQpgfjo1C6NP0GXGaV24QAi9njyy5CzKfcCWnLPXrNifRxMjoE nqFFKjSg1HnK3bizU1EbQxbdZsLml3ntGlxV6Ep9XrSGM2cOzD3bQpPVo0/IJ2DNOPQKzZFyZQZ gcFWWSdzUXIi3JYWO6j9hyZrUzS2G+zKTp5SH48CS7G5i7ZOUKpFkcPXzUijIxPSXxpHHk+LcoV TB4SelBtDu9g== X-Received: by 2002:a17:903:1b67:b0:2bf:172d:ef7e with SMTP id d9443c01a7336-2c4135e5c1cmr209319805ad.34.1781600953857; Tue, 16 Jun 2026 02:09:13 -0700 (PDT) X-Received: by 2002:a17:903:1b67:b0:2bf:172d:ef7e with SMTP id d9443c01a7336-2c4135e5c1cmr209319425ad.34.1781600953373; Tue, 16 Jun 2026 02:09:13 -0700 (PDT) Received: from [10.133.33.52] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42f7c651dsm124810995ad.26.2026.06.16.02.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:09:12 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 17:09:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/2] scsi: ufs: core: Add support for static TX Equalization settings To: =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "beanhuo@micron.com" , "mani@kernel.org" , "bvanassche@acm.org" , "krzk@kernel.org" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "quic_nitirawa@quicinc.com" , "linux-kernel@vger.kernel.org" , "alim.akhtar@samsung.com" , "avri.altman@wdc.com" , "quic_rdwivedi@quicinc.com" , "James.Bottomley@HansenPartnership.com" References: <20260615132834.2985346-1-can.guo@oss.qualcomm.com> <20260615132834.2985346-3-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: IYzbOmk2plhWmzaZ7uXalxewSf860vaG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDA5MSBTYWx0ZWRfX8WFWcSX/Sbr4 iDv3ulcmFSA9i/GDcl9M6oytpEbXPzvHTo7PUMY94DsTk3OEH5TTpSrF/cEYLQLhhFdRJ2Doyz8 CWqtonkmPh+4aSpieoFL4QHtTtiRudN5fYpdUddEi3vcalfagF2YcAJs0Z4a6IVylGzFtKoxcl4 WdxRJnN2HqjNZq10Y1XlRDk3a8DoOHFC+R+6wtpijJ39PKWxYPPWzuhJYljKdUIm0N13JNKMF2A VfcqN8zCrdhvXMGeckljlBVRF8oIl7cmfzmPgh8eMolbew6I7gHNkv4PZVKNgkNKOGZkoZTZHQi ptH5qhK73oGQ1y6KOd1KwwglP8u+RUXRxB0oRLjs4P/tEAJyQwYSSGidqhtGP4/yN6HTauZ2oYj iEVe1FpkcpZsuzAu4v2lASGQ90BdEzWv7hh5Xj+98ihHAJk31Yd8kmQ3MUp4mQG3XNoLLGP3ags M33OXPELBAgh+8He2Sw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDA5MSBTYWx0ZWRfX4oJ7DTHWVOMf CVu6qWzGeAQnSFlAm6/E9VM62376xffWdwzOlV7xsEpKAZcf3CqhzREqnUbauy2nHh4cIZsy593 eb0+biYKirUAmBSeD5+HbTtOoGljcdc= X-Authority-Analysis: v=2.4 cv=MdJcfZ/f c=1 sm=1 tr=0 ts=6a3112ba cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=R3sHXq4109Ddd7yNOpYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: IYzbOmk2plhWmzaZ7uXalxewSf860vaG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_02,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160091 On 6/16/2026 4:04 PM, Peter Wang (王信友) wrote: > > On Mon, 2026-06-15 at 06:28 -0700, Can Guo wrote: > > Parse board-specific static TX Equalization settings from Device Tree > > for > > each HS gear and store them in hba->tx_eq_params. > > > > Parse txeq-preshoot-g[1-6] and txeq-deemphasis-g[1-6] as per-lane > > tuples: > > , []. > > > > For HS-G6, parse optional tx-precode-enable-g6 using the same per- > > lane > > Host/Device tuple format. If provided, it must contain values for all > > active lanes, and each value must be 0 or 1. > > > > Introduce from_dt in struct ufshcd_tx_eq_params to track whether TX > > EQ > > values came from static Device Tree data. > > > > When TX Equalization Training is used, static settings are not final: > > - If valid settings are retrieved from > > qTxEQGnSettings/wTxEQGnSettingsExt, > >   those retrieved settings override static Device Tree settings. > > - If retrieval is not available/valid, TX EQTR runs and trained > > settings > >   override static Device Tree settings. > > > > No behavior changes for platforms that do not provide these > > properties. > > > > Signed-off-by: Can Guo > > --- > > Hi Can, > > I agree with Bart's comment. > Regarding sashiko-bot's comment, will you have another patch to > fix this pre-existing issue? > I think force_tx_eqtr could potentially trigger this deadlock. Yes, I pushed a separate fix to address the memory reclaim deadlock issue. https://lore.kernel.org/all/20260616090654.421850-1-can.guo@oss.qualcomm.com/ Please help review. Thanks, Can Guo. > > Thanks. > Peter > > > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!