From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: remove thermal zones without trips.
Date: Tue, 20 Sep 2022 17:16:55 +0200 [thread overview]
Message-ID: <bf4d4cdf-27a1-7e09-59dc-25a8646fad1f@baylibre.com> (raw)
In-Reply-To: <ca326ce8-3eee-8a7a-a522-9ffbdf7d8a82@linaro.org>
Hi,
On 9/15/22 17:50, Daniel Lezcano wrote:
> On 14/09/2022 16:15, Matthias Brugger wrote:
>>
>>
>> On 14/09/2022 15:13, Amjad Ouled-Ameur wrote:
>>> Thermal zones without trip point are not registered by thermal core.
>>>
>>> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose
>>> only but are not supposed to remain on DT.
>>>
>>> Remove the zones above and keep only cpu_thermal.
>>>
>>
>> My understanding is that this thermal zones exist but are not used.
>> DTS should describe the HW as it is, so I propose to add
>> status = "disabled";
>> to the zones.
>>
>
> At least the trip points must be declared as stated in the bindings
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/thermal/thermal-zones.yaml#n213
>
>
In the base case we should but there are no trip points for these
sensors according to MediaTek.
Regards,
Amjad
prev parent reply other threads:[~2022-09-20 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 13:13 Amjad Ouled-Ameur
2022-09-14 14:15 ` Matthias Brugger
2022-09-14 19:44 ` Amjad Ouled-Ameur
2022-09-15 15:50 ` Daniel Lezcano
2022-09-20 15:16 ` Amjad Ouled-Ameur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4d4cdf-27a1-7e09-59dc-25a8646fad1f@baylibre.com \
--to=aouledameur@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®