From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932729AbdKGSgW (ORCPT ); Tue, 7 Nov 2017 13:36:22 -0500 Received: from osg.samsung.com ([64.30.133.232]:60787 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756688AbdKGSgE (ORCPT ); Tue, 7 Nov 2017 13:36:04 -0500 Subject: Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check To: Abhishek , Shuah Khan , Thomas Renninger , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com> <3a6fd547-b367-6e35-7fb5-5ab8d1139b5b@linux.vnet.ibm.com> Cc: Shuah Khan From: Shuah Khan Message-ID: Date: Tue, 7 Nov 2017 11:36:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <3a6fd547-b367-6e35-7fb5-5ab8d1139b5b@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 02:50 AM, Abhishek wrote: > Hi, > > Can you please have a look at this also? > > Thanks and Regards, > Abhishek Goel > System Engineer > IBM India Pvt. Ltd. > Same comment on top posting. > On 11/07/2017 03:17 PM, Abhishek Goel wrote: >> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes >> this by checking for 1 when the cpu is online. >> >> Signed-off-by: Abhishek Goel >> --- >> v2: Commit message rephrased. >> --- >>   tools/power/cpupower/bench/system.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c >> index c25a74a..2bb3eef 100644 >> --- a/tools/power/cpupower/bench/system.c >> +++ b/tools/power/cpupower/bench/system.c >> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu) >> >>       dprintf("set %s as cpufreq governor\n", governor); >> >> -    if (cpupower_is_cpu_online(cpu) != 0) { >> +    if (cpupower_is_cpu_online(cpu) != 1) { >>           perror("cpufreq_cpu_exists"); >>           fprintf(stderr, "error: cpu %u does not exist\n", cpu); >>           return -1; > Ths patch looks good to me. I still need it in my Inbox. Please send it to me directly. thanks, -- Shuah