From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 224513A1B5 for ; Fri, 3 Jul 2026 02:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783046899; cv=none; b=YGH4NZywO3H8zRv0SyEsyLaOK+SgGqraRnR+RGpcPltioaFMrcHskaD8oAmV2Ws/kcFuyXkQ7KQ4JEO57VKL13/2mcyNWxFZcxVTgW/lZrImD0LvBVzYQU6rYhP7t8CoQcCDQNjkueIrgNs92Ksw8ENgv7j+c2FrwNerplVBnxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783046899; c=relaxed/simple; bh=uV4d2UF2SZyP/JSY6we8a1lGIpeTR+I94ulVg5hzmvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B71+1ewPgYv0f9vjWWSjg1lJ5a62A7x0JNbJ8AJYPVuAfkR76M9h5DnHZBSlnJMZV2HXvJAat9+4l3kQaV5GfeWgUytROGNW1II8yk4xNemCSSrvwDi9TIuLg/U+TV5xT5PkB8YoGlKHbouA4jsZoJEomH7la+TAhXNF7C9ne24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U4ds7hK+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e9h/j3nV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U4ds7hK+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e9h/j3nV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66319Q5n2310311 for ; Fri, 3 Jul 2026 02:48:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KC4xQUr0JgE9MWl7+34AveAP7lvWSVW0npuxnAQ4r48=; b=U4ds7hK+qS+ObUqF KZXK1TCtawscb0ePcJNX0rymkgSF1rVj7oGv4fgjt9e0ZNsCoP9Fi+WQlN7iKj9d 8IUxW1veUhFTPMmb2evYDythDJAfxP/w3H17zsZ2h4dq3eIJe3LiC+XDaUgvxuq6 3/xOdy53xLGjv8A9pEYE019MAI2GzbzfZuqTMNam2LGsV4+rVGGUjNBWh2Neg0mv wQwRhHA0U9fJx1/rO1SPFWD1dFx+1RqkGZLQcwjsPDzRfcWepLQOBUY4NfpohlaZ EGmXOoW4V/DSVs8u1zKCKceUD8k2Notq+dJm51+m6wDwFn83wxmdDBhh8SvobHK4 24miow== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5s252ptb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 02:48:16 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-847a483ea41so154701b3a.0 for ; Thu, 02 Jul 2026 19:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783046896; x=1783651696; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KC4xQUr0JgE9MWl7+34AveAP7lvWSVW0npuxnAQ4r48=; b=e9h/j3nV9xixLO/QBgAqQf1TStJJ3bVtEwr6OxCty94Rxjab7EtOy7C/ubZvnHQnkw huz/Li9H1AC0/IVxmbUv6q4jcHJK4J/sAuTmkzwivSlufnmkCzrlFkCJSK04GDzEfw4G yAtoHhgrvFCcuAttHCZep+NXVRtsb4n/M1gf93v2+29MRsU+xnRQoRTjvCNVU1FeHO0w NAgIBPJtu7Rcg+gY9FJpa+BvEENkhKLERuiex7CvFg6ZeA99sOQbpbt4kc9VHlwmCar6 GiGS2lgyqNlvYOzT+gynJI+xeSS1knLAgE/zEe71JbciyxSlFr3wOvbeE0VtWFMX4vgy Xtpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783046896; x=1783651696; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KC4xQUr0JgE9MWl7+34AveAP7lvWSVW0npuxnAQ4r48=; b=EJ08SR4NoAoaITiAeCOQsgKid1KFN6/3eO3SAl1/ufEurPlcXSmDhi8ixoazdAF2O8 MmnN0hFdtkpfIi4j92NXlC8trvSPlXyPI4UjIP/dsxiZvWS0qPclDHssgfvLALor3A/B SDTyawSK9YCeJrC9cvHUTxW6nAdPngKXHvf2r2B+WGS8a856ab3Nz1OCW/6qXY9i4fwa Eg3FfXPBXSdPVu6M2P/+VD0L2nmvB52wFgzrHXPnQ09eARDQ7m14EDfnKQcdYsUavcRy Y17QNwq+fy6uqnLN/tPm3LLfs9wGokyMB34lmBHMpftMSIeEApXN1AtGlkjqloiEnU0M txOg== X-Forwarded-Encrypted: i=1; AHgh+RpdBKSOU7VUL3wWWtvReeW51szMMV4/R8NzeH7HF2otSvwzrg8U56ba/AeGiDLOGXsy2tURBe9qGaJRKvw=@vger.kernel.org X-Gm-Message-State: AOJu0YyD3BmPwQnV3tCCsmtTBgIlX19QWizBlNYtRpSL6k8tZjC6I8DP 6GcE24jGOvZiwlRzvfWDOdry5jzmTiOp5Q24GdDKbcGglE6J4YnHmUAIK3ekfL1imLEWu1j8Tky inS5NweJchpIzJwIQNH+460VRMmElJnZZ4DD3gXHvL8uX6g7ASGRhBxk6KLfkvEs9g48= X-Gm-Gg: AfdE7clB7ZKkhltnxpb8WgdyiFc4d+57cb3Kc6jhXjTwMPYhVhxP0sucvD4QIQDSJpb sgsQV9bQhyFZUyGOx5iLlGqL61zOz1B+0UwFl/RdOEQbpbL9eeIOX0rMzAWEGuUKjUiPrZrtKOA laBsoZy0Bynu0IugcVH7EM/S+AW16QTyiD9vHai+q5t7uJZGDAUHuIkgGXBP9euLL1VpczaffmN 8P24/EV4Hgej3LBBRUA9wzhQ9ReVdePDesgpOWnVUBcv9dq2CPCHRhor29HUm8vSohOgbi1WWUl 0hxqEdgi0tChPPBuEshf+FfG8zTcJPrMh9qrx3buRu+qYyzI+uRC9NRTnlD8zpxt2rhS+U4dqxy xsYuQb/o5H8r7C60Qc3xwhD0izXi4Qg+PMV4P2SXZlrz12BfdZtTnA/O0EIdoHSRA4zuC4xlbke G6VcBUE8+A X-Received: by 2002:a05:6a00:419a:b0:846:eaac:a5ea with SMTP id d2e1a72fcca58-847e177a3abmr2024420b3a.3.1783046895908; Thu, 02 Jul 2026 19:48:15 -0700 (PDT) X-Received: by 2002:a05:6a00:419a:b0:846:eaac:a5ea with SMTP id d2e1a72fcca58-847e177a3abmr2024405b3a.3.1783046895295; Thu, 02 Jul 2026 19:48:15 -0700 (PDT) Received: from [10.133.33.211] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847cb79b9adsm2251650b3a.27.2026.07.02.19.48.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 19:48:15 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 10:48:11 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] wifi: ath12k: fix channel list copy on big endian To: Alexander Wilhelm Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260629-fix-channel-list-copy-v1-1-5ab826c46d7c@westermo.com> <8b29a6f4-0742-46f3-bc86-defa6e0faeae@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=U7uiy+ru c=1 sm=1 tr=0 ts=6a4722f1 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=N9GNhs4bAAAA:8 a=c7I3wfr0XCohLxdBRdcA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-ORIG-GUID: X6kk6RiIGZNncrWzTsjXCEztQyu0OS3d X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDAyNSBTYWx0ZWRfX+MfqhMYOQRII S8Qoajznm/7WnqPIIMfh34AIbs7UEqsfnDC/Lyh9SrnULle0z81yFFKtIq/6jEJhopP9BwJnVz0 9rFs9frlDWw6KP2O08AxrArH+BOwl0wMsMM6hV6PBddgIjzp7iHuDn843SgzxI6kmv4LWlykWsd 5zGV4MHM5oK17O9zrYmX/vKM7pBGSlaMYifEgo4H2Gaa5792Rz1l+685VPuvv4kJdTveZW0gZIY mOxvscYdvEiq3Cti3KzwamqI/KbuRRCI8HECNbKwyPJPsBU9dyiCwog93pPpawxrqXzVka4ZaKO fzwX9Rr2quSw4Xr16sTPiFL2pGBITiLWhcnMZJTa2WBoBqpGczfTUbR7Lj29Qs+/BNZr/oiFQRo EsFdv3vB3iJZF8gAJFAFrWo7Qot49ckMuO143xyuwurOy9BojkN+BKzTqadV1JKeV+wTX+WVUZE uC4Rb7zhTGG+agUjxUA== X-Proofpoint-GUID: X6kk6RiIGZNncrWzTsjXCEztQyu0OS3d X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDAyNSBTYWx0ZWRfX9JWHYsYc6HV4 fDjfieYnEXZXbQgfZ9ruGvDhVEMbfd2rGjmNALTVK3RHQgvE+EI3BJqUVaQHQPFKuKNBGNIJmg8 7oKP2BdArThItpIb3yxzLfqhWqQQxto= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030025 On 7/2/2026 8:18 PM, Alexander Wilhelm wrote: > On Thu, Jul 02, 2026 at 10:44:46AM +0200, Alexander Wilhelm wrote: >> On Thu, Jul 02, 2026 at 04:27:44PM +0800, Baochen Qiang wrote: >>> >>> >>> On 6/29/2026 3:46 PM, Alexander Wilhelm wrote: >>>> The ath12k_wmi_scan_req_arg structure defines the channel list in >>>> CPU-native order, while wmi_start_scan_cmd expects the values in >>>> little-endian format. The simple memcpy causes the hardware scan to fail on >>>> big-endian architectures. Set __le32* type for the tmp_ptr and swap channel >>>> values to support both architectures correctly. >>>> >>>> Signed-off-by: Alexander Wilhelm >>>> --- >>>> drivers/net/wireless/ath/ath12k/wmi.c | 8 +++++--- >>>> 1 file changed, 5 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c >>>> index 65a05a9520ff..9e1d3c662852 100644 >>>> --- a/drivers/net/wireless/ath/ath12k/wmi.c >>>> +++ b/drivers/net/wireless/ath/ath12k/wmi.c >>>> @@ -2571,7 +2571,8 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, >>>> struct wmi_tlv *tlv; >>>> void *ptr; >>>> int i, ret, len; >>>> - u32 *tmp_ptr, extraie_len_with_pad = 0; >>>> + __le32 *tmp_ptr; >>>> + u32 extraie_len_with_pad = 0; >>>> struct ath12k_wmi_hint_short_ssid_arg *s_ssid = NULL; >>>> struct ath12k_wmi_hint_bssid_arg *hint_bssid = NULL; >>>> >>>> @@ -2656,9 +2657,10 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, >>>> tlv = ptr; >>>> tlv->header = ath12k_wmi_tlv_hdr(WMI_TAG_ARRAY_UINT32, len); >>>> ptr += TLV_HDR_SIZE; >>>> - tmp_ptr = (u32 *)ptr; >>>> + tmp_ptr = (__le32 *)ptr; >>>> >>>> - memcpy(tmp_ptr, arg->chan_list, arg->num_chan * 4); >>>> + for (i = 0; i < arg->num_chan; i++) >>>> + tmp_ptr[i] = cpu_to_le32(arg->chan_list[i]); >>>> >>>> ptr += len; >>>> >>>> >>> >>> seems hint_s_ssid and hint_bssid at the last also need the endian conversion? > > `hist_s_ssid` and `hint_bssid` are both structs within > `ath12k_wmi_scan_req_arg`, and the remaining member variables are also stored in > CPU order. Therefore, it seems wrong to me to perform byte swapping at this > point. What I actually need to swap is the data written through `ptr`, not the > structure members themselves. For that reason, I could also use the `__le32 > *tmp_ptr` approach. What do you think about that? Maybe I was not clear. I intended to mean the ptr: @@ -2728,8 +2728,8 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, ptr += TLV_HDR_SIZE; s_ssid = ptr; for (i = 0; i < arg->num_hint_s_ssid; ++i) { - s_ssid->freq_flags = arg->hint_s_ssid[i].freq_flags; - s_ssid->short_ssid = arg->hint_s_ssid[i].short_ssid; + s_ssid->freq_flags = cpu_to_le32(arg->hint_s_ssid[i].freq_flags); + s_ssid->short_ssid = cpu_to_le32(arg->hint_s_ssid[i].short_ssid); s_ssid++; } ptr += len; @@ -2743,7 +2743,7 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar, hint_bssid = ptr; for (i = 0; i < arg->num_hint_bssid; ++i) { hint_bssid->freq_flags = - arg->hint_bssid[i].freq_flags; + cpu_to_le32(arg->hint_bssid[i].freq_flags); ether_addr_copy(&arg->hint_bssid[i].bssid.addr[0], &hint_bssid->bssid.addr[0]); > > One thing I am still unsure about is the use of `ether_addr_copy()`. Can I > simply copy the bytes as-is here, or does the address also need to be > byte-swapped? I could not find any place where this address is being populated, > so I am not sure what byte order it is expected to be in. I think you are talking about ath12k_wmi_hint_bssid_arg::bssid, right? For now ath12k does not populate hint_bssid or hint_s_ssid members, so bssid always remain empty. But if we are going to populate it I think the address originates from userspace and there it is passed in byte steams, so byte-swapping not required I think. > > > Best regards > Alexander Wilhelm