mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xin Liu <xin.liu@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com,
	jie.gan@oss.qualcomm.com,
	Guodong Xu <guodong.xu@oss.qualcomm.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: hamoa-iot-evk: switch typec0 to PS8830 retimer
Date: Thu, 3 Sep 2026 15:55:51 +0800	[thread overview]
Message-ID: <bf5458e9-45dc-4a0f-8d47-50e96f22e136@oss.qualcomm.com> (raw)
In-Reply-To: <049be278-8958-4d04-8501-7fb60d2169cc@oss.qualcomm.com>


On 8/18/2026 6:49 PM, Konrad Dybcio wrote:
> On 8/3/26 3:27 PM, Xin Liu wrote:
>> The Hamoa IoT EVK hardware design uses a Parade PS8830 retimer on
>> I2C3 for USB Type-C port 0. Describe the retimer and route typec0
>> through it to enable USB 3.0 SuperSpeed and DisplayPort Alt Mode.
>>
>> Supply the PS8830 from the existing vreg_rtmr0_* rails and remove
>> their stale "Left unused" annotation.
>>
>> The FSUSB42 SBU mux chip is present on the PCB but with all signal
>> lines unconnected (NC), so remove the fsusb42 node and its pinctrl
>> group.
> [...]
>
>> +&i2c3 {
>> +	clock-frequency = <400000>;
>> +	status = "okay";
>> +
>> +	typec-mux@8 {
>> +		compatible = "parade,ps8830";
>> +		reg = <0x08>;
>> +
>> +		clocks = <&rpmhcc RPMH_RF_CLK4>;
> On other boards, the port0 retimer normally takes RF_CLK3 - have
> you verified this bit?
>
> Konrad

Hi Konrad

Thanks for pointing this out.

I re-checked the schematic and confirmed that the Type-C0 retimer refclk
is provided by a board-level external XO/local XTAL, not by PMK/RPMH.
So RPMH_RF_CLK4 is not the correct clock source.

Since the binding requires a clock, I will model the board-level XO as a
fixed-clock and use it for the PS8830/PS8833 retimer node in v3.


Thanks,

XIN


      reply	other threads:[~2026-09-03  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 13:27 Xin Liu
2026-08-03 19:35 ` Dmitry Baryshkov
2026-08-04  7:04   ` Xin Liu
2026-08-18 10:49 ` Konrad Dybcio
2026-09-03  7:55   ` Xin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf5458e9-45dc-4a0f-8d47-50e96f22e136@oss.qualcomm.com \
    --to=xin.liu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guodong.xu@oss.qualcomm.com \
    --cc=jie.gan@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®