From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 470F83C3420 for ; Fri, 29 May 2026 09:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780047760; cv=none; b=ZnqirwyxNHQE9+ujfcMRKZMa6OvvfVaF+AtSWSTwNM5RpUWrmDjDTpyLFInJt2vLCDSwdyNZynjmmc7fc/rmmLA+2UsHMkoKOUND6SKRmvaFc3sFDTS1zYCxDXF36clFlFezw7wDMDmRN5ozlbhFx4kFFJpaw0KnktK7IXwQ9ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780047760; c=relaxed/simple; bh=isASItfmZgHeSp/dcJBZBesZe5OH1kNpFjlamfqEyO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LbbuQTpk2hfEIO650t/EABhQcHlVtJg1Ej6UhUeyq6uH3wHXY6vUDfL2tSvONigqED7qJYIusGFDIDwS1QnN1iESPwl1XkF2xuB+isX1iRUizZdbGngeR79tnSUfNVfY1ApOExUHxwOR25KVlHAtJeHLn4gGpVIaa/9aTZV2ez0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NmsNbqhF; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NmsNbqhF" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49041fb8c23so58876225e9.0 for ; Fri, 29 May 2026 02:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780047757; x=1780652557; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vV1zx1+zZXbYX7ohob99roya0Trf7vZYsGCeAF2uekc=; b=NmsNbqhFMl+Y5R3tF70ojex0jI4qObXI3MOI5ZR8bFgZjuEqTJ8n+0xu3nHluC2tbh sTl58uNUuajXNslbXZCn/n2bjkDUHDc2QPS/W73SCq88moUn1F8q/XSMUGIJ/T60hn6o 7JW4VgeDF/bkIgegSJlnTz53oTlxKCaQ1J3ehpl/z6XSfimw7snd4IZY8rG4wT+U9tzx r76/UmTdKvjRUrmAZUE9sQ3Vw7IYaWSZ+eg7nxqhlqCsgXPvhYLeGu+1cagXQgreN6ff oS6GUgXsk1rDehbxbxN21jBSfDWv87xqkXMIflymuev+ad1jC0Pm31W0JI+Td7KZtEhI rgqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780047757; x=1780652557; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vV1zx1+zZXbYX7ohob99roya0Trf7vZYsGCeAF2uekc=; b=E5y4fy28XBP6JeMRksgOAXHT5i2eoXTtEHfbbt7ZyijSkEmL3hAcHNHbaOGIehY5pQ 6c63n7s97VEfZpLILCzTPRapsNBhol9rXpMij/KnvvnI0jrWALZk03LBd5pllEGZwyKd uH1wNsD+QKqcuAhdWVBsCjhGUUhywsQLXSvKSwO5wmZV9UjzLOsbnolN8ne6akBnImGN 2HzBUlDCF2Y7G3//BpxNjCk6d+ojUhDni4h/Qtmx031hzvAKPf0Ftd8EH8Y+IHsAfNB3 /F91RLa78qrJEkGN1TX7iigheutqqGRPi32YdW/PLjKQBAaFjxfjI0Xo4bPBwyKoRmL0 mT4w== X-Forwarded-Encrypted: i=1; AFNElJ+SbGde5ykftVikMU+TlgfxalfyqhFD+p5HJ/rY99ftNlrSwqLoRskZMyhOcku2AOZ89RCGlv0rfJlUSn8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywce7+mRTyY55Zbk95NLdLf6AWMRu+LH2gGNPraC9N3Rbzefbq1 ST6m2OVaqxTxuVXZnum4QIhimzWilrrL1XtnSlvN9Tt+kFJChiBctd5997vjawRi1s8= X-Gm-Gg: Acq92OGiC3rgrFajF6jKZN3JAXXdEL/uVF/nDjAAu9Dy3hiOKYx0A+wwUw/e0aZjuqR HwD2wgNsDI+7me1eDoefgp1MDV/7IbYcKkJTdFIOQW5HErefT1wA8DyHDMbVCAwlx8uQVEnVX+9 nfwpf4iwitp+Pidr/HMjS3S4LGFUdx/nlZ5KfgWSc+D+hh55MC4bJWzh2JFlgNrHrPtZdSPSZea FXpqguCFwIvafHIMFp4oOdC8djw7RmtfVwK/x9Iok5XIAt5g3rLmPDMlQzV9MyaHB8BSVExyUL3 QmTEDW99XV172ixbZDTcFa38gIdDWKkorIH9I2iTEYCxKYayX98cLGxabH+b1xVtp9AfndjIVPo fERrFz+2NvSJJw3fQ2m3uaEA29Z4WhtG+/fXREeFHN8UEFHWbzVmDaPl9oXH3zzpmrD1TousIbE BFalAQlrb8/6D4ZJFIiEGhjRCvWkYicxxsVD5JdUk= X-Received: by 2002:a05:600c:6008:b0:490:44eb:c1e0 with SMTP id 5b1f17b1804b1-4909c0ac911mr29067875e9.21.1780047756739; Fri, 29 May 2026 02:42:36 -0700 (PDT) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909ca72cfbsm33571475e9.8.2026.05.29.02.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 02:42:35 -0700 (PDT) Message-ID: Date: Fri, 29 May 2026 10:42:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist To: Namhyung Kim , Arnaldo Carvalho de Melo Cc: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Rogers , Leo Yan References: <20260410-james-spe-discard-warning-v1-1-985c02756ee4@linaro.org> <20260513102024.GE34802@e132581.arm.com> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/05/2026 1:55 pm, Ian Rogers wrote: > On Wed, May 13, 2026 at 3:20 AM Leo Yan wrote: >> >> On Fri, Apr 10, 2026 at 12:05:12PM +0100, James Clark wrote: >>> Opening an SPE event shows a warning that doesn't concern the user: >>> >>> $ perf record -e arm_spe >>> Unknown/empty format name: discard >>> >>> Perf only wants to know if the discard bit is set for configuring the >>> event, not in response to anything the user has done. Fix it by adding >>> another helper that returns if a config bit exists without warning. >>> >>> We should probably keep the warning in evsel__get_config_val() to avoid >>> having every caller having to do it, and most format bits should never >>> be missing. >>> >>> Add a test for the new helper. Rename the parent test function to be >>> more generic rather than adding a new one as it requires a lot of >>> boilerplate. >>> >>> Signed-off-by: James Clark >> >> Reviewed-by: Leo Yan > > Reviewed-by: Ian Rogers > > Thanks, > Ian Ping, thanks