mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org, perex@perex.cz,
	tiwai@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: soc-topology: fix __le32 conversion in printed values
Date: Mon, 23 Mar 2026 12:31:31 +0000	[thread overview]
Message-ID: <bf59d766-d081-4548-b347-d2b40e1b2ba1@codethink.co.uk> (raw)
In-Reply-To: <6c2114d1-cccc-4857-b3a4-3fdcb9932c76@sirena.org.uk>

On 19/03/2026 13:58, Mark Brown wrote:
> On Wed, Mar 18, 2026 at 04:34:27PM +0000, Ben Dooks wrote:
> 
>> @@ -1957,9 +1962,9 @@ static int soc_tplg_valid_header(struct soc_tplg *tplg,
>>   
>>   	if (soc_tplg_get_hdr_offset(tplg) + le32_to_cpu(hdr->payload_size) >= tplg->fw->size) {
>>   		dev_err(tplg->dev,
>> -			"ASoC: invalid header of type %d at offset %ld payload_size %d\n",
>> +			"ASoC: invalid header of type %u at offset %ld payload_size %d\n",
>>   			le32_to_cpu(hdr->type), soc_tplg_get_hdr_offset(tplg),
>> -			hdr->payload_size);
>> +			le32_to_cpu(hdr->payload_size));
>>   		return -EINVAL;
>>   	}
> 
> The format string for the type got converted but not that for the
> payload size, both of which got le32_to_cpu() conversions.

Thanks, since there's been no-other reviews shall I fix and re-send v3?

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html

  reply	other threads:[~2026-03-23 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 16:34 Ben Dooks
2026-03-19 13:58 ` Mark Brown
2026-03-23 12:31   ` Ben Dooks [this message]
2026-03-23 14:52     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf59d766-d081-4548-b347-d2b40e1b2ba1@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®